diff options
| author | Yasuo Honda <yasuo.honda@gmail.com> | 2019-08-03 02:23:29 +0000 |
|---|---|---|
| committer | Yasuo Honda <yasuo.honda@gmail.com> | 2019-08-03 02:27:56 +0000 |
| commit | 20772f6c5372ce29afb23efa7605f5c80107f51d (patch) | |
| tree | cddd5e5aab3832bf99b81b6771f370d3b39810c5 | |
| parent | 5944a312921b9a27fce7bef317e42213c4efaa3b (diff) | |
| download | rails-20772f6c5372ce29afb23efa7605f5c80107f51d.tar.gz rails-20772f6c5372ce29afb23efa7605f5c80107f51d.tar.bz2 rails-20772f6c5372ce29afb23efa7605f5c80107f51d.zip | |
Address `DEPRECATED: Use assert_nil if expecting nil`
```ruby
$ cd activerecord
$ bin/test test/cases/dirty_test.rb:494
... snip ...
DEPRECATED: Use assert_nil if expecting nil from /home/yahonda/git/rails/activerecord/test/cases/dirty_test.rb:494. This will fail in Minitest 6.
DEPRECATED: Use assert_nil if expecting nil from /home/yahonda/git/rails/activerecord/test/cases/dirty_test.rb:511. This will fail in Minitest 6.
.
Finished in 0.061593s, 16.2356 runs/s, 795.5428 assertions/s.
1 runs, 49 assertions, 0 failures, 0 errors, 0 skips
$
```
Refer seattlerb/minitest#666 rails/rails#27712
| -rw-r--r-- | activerecord/test/cases/dirty_test.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/activerecord/test/cases/dirty_test.rb b/activerecord/test/cases/dirty_test.rb index 6aca7d93ad..38baf0509c 100644 --- a/activerecord/test/cases/dirty_test.rb +++ b/activerecord/test/cases/dirty_test.rb @@ -491,7 +491,7 @@ class DirtyTest < ActiveRecord::TestCase assert_equal 4, pirate.previous_changes.size assert_equal [nil, "arrr"], pirate.previous_changes["catchphrase"] - assert_equal nil, pirate.catchphrase_previously_was + assert_nil pirate.catchphrase_previously_was assert_equal [nil, pirate.id], pirate.previous_changes["id"] assert_nil pirate.previous_changes["updated_on"][0] assert_not_nil pirate.previous_changes["updated_on"][1] @@ -508,7 +508,7 @@ class DirtyTest < ActiveRecord::TestCase assert_equal 4, pirate.previous_changes.size assert_equal [nil, "arrr"], pirate.previous_changes["catchphrase"] - assert_equal nil, pirate.catchphrase_previously_was + assert_nil pirate.catchphrase_previously_was assert_equal [nil, pirate.id], pirate.previous_changes["id"] assert_includes pirate.previous_changes, "updated_on" assert_includes pirate.previous_changes, "created_on" |