diff options
author | David Heinemeier Hansson <david@loudthinking.com> | 2014-05-20 17:36:17 +0200 |
---|---|---|
committer | David Heinemeier Hansson <david@loudthinking.com> | 2014-05-20 17:36:17 +0200 |
commit | 1d519aae29228186d3e82906d5d6e8dda2e91bd3 (patch) | |
tree | f52f472d2c23daffd9a87f3c5f0f9ea7da3e1a70 | |
parent | 3649ebc8b4e1990da88d06ebe04324d4cddc6496 (diff) | |
download | rails-1d519aae29228186d3e82906d5d6e8dda2e91bd3.tar.gz rails-1d519aae29228186d3e82906d5d6e8dda2e91bd3.tar.bz2 rails-1d519aae29228186d3e82906d5d6e8dda2e91bd3.zip |
Reformat the logging line and ensure we are logging the serialized args
-rw-r--r-- | lib/active_job/enqueuing.rb | 5 | ||||
-rw-r--r-- | lib/active_job/log_subscriber.rb | 11 |
2 files changed, 9 insertions, 7 deletions
diff --git a/lib/active_job/enqueuing.rb b/lib/active_job/enqueuing.rb index 46f703481a..6fb6f15ce2 100644 --- a/lib/active_job/enqueuing.rb +++ b/lib/active_job/enqueuing.rb @@ -11,8 +11,9 @@ module ActiveJob # The return value is adapter-specific and may change in a future # ActiveJob release. def enqueue(*args) - ActiveSupport::Notifications.instrument "enqueue.active_job", adapter: queue_adapter, job: self, params: args - queue_adapter.queue self, *Parameters.serialize(args) + serialized_args = Parameters.serialize(args) + ActiveSupport::Notifications.instrument "enqueue.active_job", adapter: queue_adapter, job: self, args: serialized_args + queue_adapter.queue self, *serialized_args end end end diff --git a/lib/active_job/log_subscriber.rb b/lib/active_job/log_subscriber.rb index 31c61a6068..472c9f3081 100644 --- a/lib/active_job/log_subscriber.rb +++ b/lib/active_job/log_subscriber.rb @@ -1,12 +1,13 @@ +require 'active_support/core_ext/string/filters' + module ActiveJob class LogSubscriber < ActiveSupport::LogSubscriber def enqueue(event) - payload = event.payload - params = payload[:params] - adapter = payload[:adapter] - job = payload[:job] + queue_name = event.payload[:adapter].name.demodulize.remove('Adapter') + job_name = event.payload[:job].name + args = event.payload[:args].any? ? ": #{event.payload[:args].inspect}" : "" - info "ActiveJob enqueued to #{adapter.name.demodulize} job #{job.name}: #{params.inspect}" + info "Enqueued #{job_name} to #{queue_name}" + args end def logger |