aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAaron Patterson <aaron.patterson@gmail.com>2011-08-03 16:55:00 -0700
committerAaron Patterson <aaron.patterson@gmail.com>2011-08-03 16:55:00 -0700
commit171881f610fdff1903b2bdd1c8894cbe1ab98303 (patch)
treee5625eda8df4af2db9fb9912bb48022f159adbfc
parentcc9ed157853bf9c7932efbe8a06f4e39a0ad1c08 (diff)
downloadrails-171881f610fdff1903b2bdd1c8894cbe1ab98303.tar.gz
rails-171881f610fdff1903b2bdd1c8894cbe1ab98303.tar.bz2
rails-171881f610fdff1903b2bdd1c8894cbe1ab98303.zip
make assert_difference error message not suck
-rw-r--r--activesupport/lib/active_support/testing/assertions.rb11
1 files changed, 6 insertions, 5 deletions
diff --git a/activesupport/lib/active_support/testing/assertions.rb b/activesupport/lib/active_support/testing/assertions.rb
index 3864b1f5a6..ba34e9853c 100644
--- a/activesupport/lib/active_support/testing/assertions.rb
+++ b/activesupport/lib/active_support/testing/assertions.rb
@@ -46,16 +46,17 @@ module ActiveSupport
# end
def assert_difference(expression, difference = 1, message = nil, &block)
exps = Array.wrap(expression).map { |e|
- e.respond_to?(:call) ? e : lambda { eval(e, block.binding) }
+ callee = e.respond_to?(:call) ? e : lambda { eval(e, block.binding) }
+ [e, callee]
}
- before = exps.map { |e| e.call }
+ before = exps.map { |_, block| block.call }
yield
- exps.each_with_index do |e, i|
- error = "#{e.inspect} didn't change by #{difference}"
+ exps.each_with_index do |(code, block), i|
+ error = "#{code.inspect} didn't change by #{difference}"
error = "#{message}.\n#{error}" if message
- assert_equal(before[i] + difference, e.call, error)
+ assert_equal(before[i] + difference, block.call, error)
end
end