aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRafael Mendonça França <rafaelmfranca@gmail.com>2015-01-04 00:45:54 -0300
committerRafael Mendonça França <rafaelmfranca@gmail.com>2015-01-04 11:58:44 -0300
commit0fbd1fc888ffb8cbe1191193bf86933110693dfc (patch)
treed93e0ad64e57cc3efb0f9038845b6d4f1a89d178
parentefdc20f36ccc37afbb2705eb9acca76dd8aabd4f (diff)
downloadrails-0fbd1fc888ffb8cbe1191193bf86933110693dfc.tar.gz
rails-0fbd1fc888ffb8cbe1191193bf86933110693dfc.tar.bz2
rails-0fbd1fc888ffb8cbe1191193bf86933110693dfc.zip
Remove deprecated `ActiveRecord::Base.disable_implicit_join_references=`
-rw-r--r--activerecord/CHANGELOG.md4
-rw-r--r--activerecord/lib/active_record/core.rb7
-rw-r--r--activerecord/test/cases/relations_test.rb6
3 files changed, 4 insertions, 13 deletions
diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md
index 72410ab496..d1ffdd480d 100644
--- a/activerecord/CHANGELOG.md
+++ b/activerecord/CHANGELOG.md
@@ -1,3 +1,7 @@
+* Remove deprecated `ActiveRecord::Base.disable_implicit_join_references=`.
+
+ *Rafael Mendonça França*
+
* Remove deprecated access to connection specification using a string acessor.
Now all strings will be handled as a URL.
diff --git a/activerecord/lib/active_record/core.rb b/activerecord/lib/active_record/core.rb
index 38b2d632d2..5c7c0feeb7 100644
--- a/activerecord/lib/active_record/core.rb
+++ b/activerecord/lib/active_record/core.rb
@@ -87,13 +87,6 @@ module ActiveRecord
mattr_accessor :maintain_test_schema, instance_accessor: false
- def self.disable_implicit_join_references=(value)
- ActiveSupport::Deprecation.warn(<<-MSG.squish)
- Implicit join references were removed with Rails 4.1.
- Make sure to remove this configuration because it does nothing.
- MSG
- end
-
class_attribute :default_connection_handler, instance_writer: false
class_attribute :find_by_statement_cache
diff --git a/activerecord/test/cases/relations_test.rb b/activerecord/test/cases/relations_test.rb
index fb9258c038..2e2c5ee10b 100644
--- a/activerecord/test/cases/relations_test.rb
+++ b/activerecord/test/cases/relations_test.rb
@@ -1382,12 +1382,6 @@ class RelationTest < ActiveRecord::TestCase
assert_equal "id", Post.all.primary_key
end
- def test_disable_implicit_join_references_is_deprecated
- assert_deprecated do
- ActiveRecord::Base.disable_implicit_join_references = true
- end
- end
-
def test_ordering_with_extra_spaces
assert_equal authors(:david), Author.order('id DESC , name DESC').last
end