aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJosé Valim <jose.valim@gmail.com>2012-05-30 02:34:09 -0700
committerJosé Valim <jose.valim@gmail.com>2012-05-30 02:34:09 -0700
commit0cc4e37178e3ed9ed8722d1335e1e789e7c95fd3 (patch)
treed2c1c37ef6892303affa21f728668a56a4989e51
parent555d8152c79eabc575413a0ddd199ac8304d776b (diff)
parent397e47d807529416da62d428eae5760c7e9e0705 (diff)
downloadrails-0cc4e37178e3ed9ed8722d1335e1e789e7c95fd3.tar.gz
rails-0cc4e37178e3ed9ed8722d1335e1e789e7c95fd3.tar.bz2
rails-0cc4e37178e3ed9ed8722d1335e1e789e7c95fd3.zip
Merge pull request #6550 from arunagw/warning_removed_assert_match
Some of the warnings removed from "railties"
-rw-r--r--railties/test/application/configuration_test.rb6
-rw-r--r--railties/test/application/rake/notes_test.rb40
-rw-r--r--railties/test/commands/console_test.rb8
-rw-r--r--railties/test/commands/dbconsole_test.rb8
-rw-r--r--railties/test/generators_test.rb4
5 files changed, 33 insertions, 33 deletions
diff --git a/railties/test/application/configuration_test.rb b/railties/test/application/configuration_test.rb
index 252dd0e31a..d7689863e6 100644
--- a/railties/test/application/configuration_test.rb
+++ b/railties/test/application/configuration_test.rb
@@ -288,16 +288,16 @@ module ApplicationTests
params = {:authenticity_token => token}
get "/posts/1"
- assert_match /patch/, last_response.body
+ assert_match(/patch/, last_response.body)
patch "/posts/1", params
- assert_match /update/, last_response.body
+ assert_match(/update/, last_response.body)
patch "/posts/1", params
assert_equal 200, last_response.status
put "/posts/1", params
- assert_match /update/, last_response.body
+ assert_match(/update/, last_response.body)
put "/posts/1", params
assert_equal 200, last_response.status
diff --git a/railties/test/application/rake/notes_test.rb b/railties/test/application/rake/notes_test.rb
index 05d73dfc5c..3f4db77897 100644
--- a/railties/test/application/rake/notes_test.rb
+++ b/railties/test/application/rake/notes_test.rb
@@ -33,14 +33,14 @@ module ApplicationTests
output = `bundle exec rake notes`
lines = output.scan(/\[([0-9\s]+)\](\s)/)
- assert_match /note in erb/, output
- assert_match /note in haml/, output
- assert_match /note in slim/, output
- assert_match /note in ruby/, output
- assert_match /note in coffee/, output
- assert_match /note in js/, output
- assert_match /note in css/, output
- assert_match /note in scss/, output
+ assert_match(/note in erb/, output)
+ assert_match(/note in haml/, output)
+ assert_match(/note in slim/, output)
+ assert_match(/note in ruby/, output)
+ assert_match(/note in coffee/, output)
+ assert_match(/note in js/, output)
+ assert_match(/note in css/, output)
+ assert_match(/note in scss/, output)
assert_equal 8, lines.size
@@ -72,12 +72,12 @@ module ApplicationTests
output = `bundle exec rake notes`
lines = output.scan(/\[([0-9\s]+)\]/).flatten
- assert_match /note in app directory/, output
- assert_match /note in config directory/, output
- assert_match /note in lib directory/, output
- assert_match /note in script directory/, output
- assert_match /note in test directory/, output
- assert_no_match /note in some_other directory/, output
+ assert_match(/note in app directory/, output)
+ assert_match(/note in config directory/, output)
+ assert_match(/note in lib directory/, output)
+ assert_match(/note in script directory/, output)
+ assert_match(/note in test directory/, output)
+ assert_no_match(/note in some_other directory/, output)
assert_equal 5, lines.size
@@ -108,13 +108,13 @@ module ApplicationTests
output = `SOURCE_ANNOTATION_DIRECTORIES='some_other_dir' bundle exec rake notes`
lines = output.scan(/\[([0-9\s]+)\]/).flatten
- assert_match /note in app directory/, output
- assert_match /note in config directory/, output
- assert_match /note in lib directory/, output
- assert_match /note in script directory/, output
- assert_match /note in test directory/, output
+ assert_match(/note in app directory/, output)
+ assert_match(/note in config directory/, output)
+ assert_match(/note in lib directory/, output)
+ assert_match(/note in script directory/, output)
+ assert_match(/note in test directory/, output)
- assert_match /note in some_other directory/, output
+ assert_match(/note in some_other directory/, output)
assert_equal 6, lines.size
diff --git a/railties/test/commands/console_test.rb b/railties/test/commands/console_test.rb
index 9aa1d68675..78648a16b3 100644
--- a/railties/test/commands/console_test.rb
+++ b/railties/test/commands/console_test.rb
@@ -35,7 +35,7 @@ class Rails::ConsoleTest < ActiveSupport::TestCase
start
- assert_match /Loading \w+ environment \(Rails/, output
+ assert_match(/Loading \w+ environment \(Rails/, output)
end
def test_start_with_debugger
@@ -52,7 +52,7 @@ class Rails::ConsoleTest < ActiveSupport::TestCase
start ["--sandbox"]
- assert_match /Loading \w+ environment in sandbox \(Rails/, output
+ assert_match(/Loading \w+ environment in sandbox \(Rails/, output)
end
def test_console_with_environment
@@ -61,7 +61,7 @@ class Rails::ConsoleTest < ActiveSupport::TestCase
start ["-e production"]
- assert_match /production/, output
+ assert_match(/production/, output)
end
def test_console_with_rails_environment
@@ -70,7 +70,7 @@ class Rails::ConsoleTest < ActiveSupport::TestCase
start ["RAILS_ENV=production"]
- assert_match /production/, output
+ assert_match(/production/, output)
end
diff --git a/railties/test/commands/dbconsole_test.rb b/railties/test/commands/dbconsole_test.rb
index 6d0f5ca073..562b83713b 100644
--- a/railties/test/commands/dbconsole_test.rb
+++ b/railties/test/commands/dbconsole_test.rb
@@ -12,7 +12,7 @@ class Rails::DBConsoleTest < ActiveSupport::TestCase
app_config({})
capture_abort { Rails::DBConsole.config }
assert aborted
- assert_match /No database is configured for the environment '\w+'/, output
+ assert_match(/No database is configured for the environment '\w+'/, output)
app_config(test: "with_init")
assert_equal Rails::DBConsole.config, "with_init"
@@ -129,7 +129,7 @@ class Rails::DBConsoleTest < ActiveSupport::TestCase
def test_unknown_command_line_client
start(adapter: 'unknown', database: 'db')
assert aborted
- assert_match /Unknown command-line client for db/, output
+ assert_match(/Unknown command-line client for db/, output)
end
def test_print_help_short
@@ -138,7 +138,7 @@ class Rails::DBConsoleTest < ActiveSupport::TestCase
end
assert aborted
assert_equal '', output
- assert_match /Usage:.*dbconsole/, stdout
+ assert_match(/Usage:.*dbconsole/, stdout)
end
def test_print_help_long
@@ -147,7 +147,7 @@ class Rails::DBConsoleTest < ActiveSupport::TestCase
end
assert aborted
assert_equal '', output
- assert_match /Usage:.*dbconsole/, stdout
+ assert_match(/Usage:.*dbconsole/, stdout)
end
private
diff --git a/railties/test/generators_test.rb b/railties/test/generators_test.rb
index 60e7e57a91..417d019178 100644
--- a/railties/test/generators_test.rb
+++ b/railties/test/generators_test.rb
@@ -186,7 +186,7 @@ class GeneratorsTest < Rails::Generators::TestCase
mkdir_p(File.dirname(template))
File.open(template, 'w'){ |f| f.write "empty" }
- output = capture(:stdout) do
+ capture(:stdout) do
Rails::Generators.invoke :model, ["user"], :destination_root => destination_root
end
@@ -205,7 +205,7 @@ class GeneratorsTest < Rails::Generators::TestCase
def test_usage_with_embedded_ruby
require File.expand_path("fixtures/lib/generators/usage_template/usage_template_generator", File.dirname(__FILE__))
output = capture(:stdout) { Rails::Generators.invoke :usage_template, ['--help'] }
- assert_match /:: 2 ::/, output
+ assert_match(/:: 2 ::/, output)
end
def test_hide_namespace