aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYves Senn <yves.senn@gmail.com>2014-04-13 14:50:35 +0200
committerYves Senn <yves.senn@gmail.com>2014-04-13 14:50:35 +0200
commit090db0ff7d2611846aef0b38f741dda6204849ce (patch)
tree5f22d074af4934166de9129f5b4a7f09b184e320
parent47d9321a1ee88368cc24de7cad5f42a28066d1a0 (diff)
parent5d5beccc8ce0e844dca3ebac6e0ec8dd3fcc1b91 (diff)
downloadrails-090db0ff7d2611846aef0b38f741dda6204849ce.tar.gz
rails-090db0ff7d2611846aef0b38f741dda6204849ce.tar.bz2
rails-090db0ff7d2611846aef0b38f741dda6204849ce.zip
Merge pull request #14727 from robin850/patch-17
Add a changelog entry for #14546 [ci skip]
-rw-r--r--activerecord/CHANGELOG.md14
1 files changed, 14 insertions, 0 deletions
diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md
index dead555cca..3893292cee 100644
--- a/activerecord/CHANGELOG.md
+++ b/activerecord/CHANGELOG.md
@@ -1,3 +1,17 @@
+* Calling `delete_all` on an unloaded `CollectionProxy` no longer
+ generates a SQL statement containing each id of the collection:
+
+ Before:
+
+ DELETE FROM `model` WHERE `model`.`parent_id` = 1
+ AND `model`.`id` IN (1, 2, 3...)
+
+ After:
+
+ DELETE FROM `model` WHERE `model`.`parent_id` = 1
+
+ *Eileen M. Uchitelle*, *Aaron Patterson*
+
* Fixed error for aggregate methods (`empty?`, `any?`, `count`) with `select`
which created invalid SQL.