Merge pull request #8202 from nikitug/regression_test_on_dynamic_finder_result

Regression test for #7238

2 files changed, 13 insertions, 0 deletions

diff --git a/activerecord/test/cases/finder_test.rb b/activerecord/test/cases/finder_test.rb
index d44ac21b05..f68d7de3ae 100644
--- a/activerecord/test/cases/finder_test.rb
+++ b/activerecord/test/cases/finder_test.rb
@@ -610,6 +610,13 @@ class FinderTest < ActiveRecord::TestCase
     assert_nil Topic.find_by_heading("The First Topic!")
   end
 
+  def test_find_by_one_attribute_bang_with_blank_defined
+    BlankTopic.create(title: "The Blank One")
+    assert_nothing_raised do
+      BlankTopic.find_by_title!("The Blank One")
+    end
+  end
+
   def test_find_by_one_attribute_with_conditions
     assert_equal accounts(:rails_core_account), Account.where('firm_id = ?', 6).find_by_credit_limit(50)
   end
diff --git a/activerecord/test/models/topic.rb b/activerecord/test/models/topic.rb
index ab31d85e46..f7f4cebc5a 100644
--- a/activerecord/test/models/topic.rb
+++ b/activerecord/test/models/topic.rb
@@ -107,6 +107,12 @@ class ImportantTopic < Topic
   serialize :important, Hash
 end
 
+class BlankTopic < Topic
+  def blank?
+    true
+  end
+end
+
 module Web
   class Topic < ActiveRecord::Base
     has_many :replies, :dependent => :destroy, :foreign_key => "parent_id", :class_name => 'Web::Reply'