diff options
author | Michael Koziarski <michael@koziarski.com> | 2005-10-14 02:07:51 +0000 |
---|---|---|
committer | Michael Koziarski <michael@koziarski.com> | 2005-10-14 02:07:51 +0000 |
commit | 59709d9188b7afff3ee53a4a20b9e40a7699e298 (patch) | |
tree | 2a60478c18cad20cea25586b732a74855a9b76e3 | |
parent | acb80e3d0e96725fffad7caa42cc33281714450a (diff) | |
download | rails-59709d9188b7afff3ee53a4a20b9e40a7699e298.tar.gz rails-59709d9188b7afff3ee53a4a20b9e40a7699e298.tar.bz2 rails-59709d9188b7afff3ee53a4a20b9e40a7699e298.zip |
Ensure radio_button works as expected with values other than strings.
Thanks to:
* grant.mcinnes@utoronto.ca
* rails@jeffcole.net
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2573 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
-rw-r--r-- | actionpack/lib/action_view/helpers/form_helper.rb | 2 | ||||
-rw-r--r-- | actionpack/test/template/form_helper_test.rb | 6 |
2 files changed, 7 insertions, 1 deletions
diff --git a/actionpack/lib/action_view/helpers/form_helper.rb b/actionpack/lib/action_view/helpers/form_helper.rb index 95132d130b..eadaeaea00 100644 --- a/actionpack/lib/action_view/helpers/form_helper.rb +++ b/actionpack/lib/action_view/helpers/form_helper.rb @@ -174,7 +174,7 @@ module ActionView options = DEFAULT_RADIO_OPTIONS.merge(options.stringify_keys) options["type"] = "radio" options["value"] = tag_value - options["checked"] = "checked" if value == tag_value + options["checked"] = "checked" if value.to_s == tag_value.to_s pretty_tag_value = tag_value.to_s.gsub(/\s/, "_").gsub(/\W/, "").downcase options["id"] = @auto_index ? "#{@object_name}_#{@auto_index}_#{@method_name}_#{pretty_tag_value}" : diff --git a/actionpack/test/template/form_helper_test.rb b/actionpack/test/template/form_helper_test.rb index 51141770bd..08b5421c81 100644 --- a/actionpack/test/template/form_helper_test.rb +++ b/actionpack/test/template/form_helper_test.rb @@ -98,6 +98,12 @@ class FormHelperTest < Test::Unit::TestCase ) end + def test_radio_button_is_checked_with_integers + assert_dom_equal('<input checked="checked" id="post_secret_1" name="post[secret]" type="radio" value="1" />', + radio_button("post", "secret", "1") + ) + end + def test_text_area assert_dom_equal( '<textarea cols="40" id="post_body" name="post[body]" rows="20">Back to the hill and over it again!</textarea>', |