From 59709d9188b7afff3ee53a4a20b9e40a7699e298 Mon Sep 17 00:00:00 2001 From: Michael Koziarski Date: Fri, 14 Oct 2005 02:07:51 +0000 Subject: Ensure radio_button works as expected with values other than strings. Thanks to: * grant.mcinnes@utoronto.ca * rails@jeffcole.net git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2573 5ecf4fe2-1ee6-0310-87b1-e25e094e27de --- actionpack/lib/action_view/helpers/form_helper.rb | 2 +- actionpack/test/template/form_helper_test.rb | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/actionpack/lib/action_view/helpers/form_helper.rb b/actionpack/lib/action_view/helpers/form_helper.rb index 95132d130b..eadaeaea00 100644 --- a/actionpack/lib/action_view/helpers/form_helper.rb +++ b/actionpack/lib/action_view/helpers/form_helper.rb @@ -174,7 +174,7 @@ module ActionView options = DEFAULT_RADIO_OPTIONS.merge(options.stringify_keys) options["type"] = "radio" options["value"] = tag_value - options["checked"] = "checked" if value == tag_value + options["checked"] = "checked" if value.to_s == tag_value.to_s pretty_tag_value = tag_value.to_s.gsub(/\s/, "_").gsub(/\W/, "").downcase options["id"] = @auto_index ? "#{@object_name}_#{@auto_index}_#{@method_name}_#{pretty_tag_value}" : diff --git a/actionpack/test/template/form_helper_test.rb b/actionpack/test/template/form_helper_test.rb index 51141770bd..08b5421c81 100644 --- a/actionpack/test/template/form_helper_test.rb +++ b/actionpack/test/template/form_helper_test.rb @@ -98,6 +98,12 @@ class FormHelperTest < Test::Unit::TestCase ) end + def test_radio_button_is_checked_with_integers + assert_dom_equal('', + radio_button("post", "secret", "1") + ) + end + def test_text_area assert_dom_equal( '', -- cgit v1.2.3