adds a few cops and sorts

1 files changed, 48 insertions, 21 deletions

diff --git a/.rubocop.yml b/.rubocop.yml
index fbca606605..6ab1146b40 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -1,34 +1,35 @@
 AllCops:
   TargetRubyVersion: 2.3
+  # RuboCop has a bunch of cops enabled by default. This setting tells RuboCop
+  # to ignore them, so only the ones explictily set in this file are enabled.
   DisabledByDefault: true
+  Exclude:
+    - '**/templates/**/*'
+    - '**/vendor/**/*'
 
-# Two spaces, no tabs (for indentation).
-Style/IndentationWidth:
+# Prefer &&/|| over and/or.
+Style/AndOr:
   Enabled: true
 
-# No trailing whitespace.
-Style/TrailingWhitespace:
+# Do not use braces for hash literals when they are the last argument of a
+# method call.
+Style/BracesAroundHashParameters:
   Enabled: true
 
-# Blank lines should not have any spaces.
-Style/TrailingBlankLines:
+# Align `when` with `case`.
+Style/CaseIndentation:
   Enabled: true
 
-# Use Ruby >= 1.9 syntax for hashes. Prefer { a: :b } over { :a => :b }.
-Style/HashSyntax:
-  Enabled: true
-
-# Prefer &&/|| over and/or.
-Style/AndOr:
+# In a regular class definition, no empty lines around the body.
+Style/EmptyLinesAroundClassBody:
   Enabled: true
 
-# Use my_method(my_arg) not my_method( my_arg ) or my_method my_arg.
-Lint/RequireParentheses:
+# In a regular module definition, no empty lines around the body.
+Style/EmptyLinesAroundModuleBody:
   Enabled: true
 
-# Do not use braces for hash literals when they are the last argument of a
-# method call.
-Style/BracesAroundHashParameters:
+# Use Ruby >= 1.9 syntax for hashes. Prefer { a: :b } over { :a => :b }.
+Style/HashSyntax:
   Enabled: true
 
 # Method definitions after `private` or `protected` isolated calls need one
@@ -37,15 +38,41 @@ Style/IndentationConsistency:
   Enabled: true
   EnforcedStyle: rails
 
-# In a regular class definition, no empty lines around the body.
-Style/EmptyLinesAroundClassBody:
+# Two spaces, no tabs (for indentation).
+Style/IndentationWidth:
   Enabled: true
 
-# In a regular module definition, no empty lines around the body.
-Style/EmptyLinesAroundModuleBody:
+# Defining a method with parameters needs parentheses.
+Style/MethodDefParentheses:
+  Enabled: true
+
+# Check quotes usage according to lint rule below.
+Style/StringLiterals:
+  Enabled: true
+  EnforcedStyle: double_quotes
+
+# Detect hard tabs, no hard tabs.
+Style/Tab:
+  Enabled: true
+
+# Blank lines should not have any spaces.
+Style/TrailingBlankLines:
+  Enabled: true
+
+# No trailing whitespace.
+Style/TrailingWhitespace:
+  Enabled: true
+
+# Use quotes for string literals when they are enough.
+Style/UnneededPercentQ:
   Enabled: true
 
 # Align `end` with the matching keyword or starting expression except for
 # assignments, where it should be aligned with the LHS.
 Lint/EndAlignment:
+  Enabled: true
   AlignWith: variable
+
+# Use my_method(my_arg) not my_method( my_arg ) or my_method my_arg.
+Lint/RequireParentheses:
+  Enabled: true