diff options
| author | Yves Senn <yves.senn@gmail.com> | 2014-02-28 09:49:52 +0100 |
|---|---|---|
| committer | Yves Senn <yves.senn@gmail.com> | 2014-02-28 09:56:07 +0100 |
| commit | d1e7cd14c29f1ef45f2f36e79cd99eb580036991 (patch) | |
| tree | be4a5428a28c5a9a0c92a5108f9b0c6adee14bfb /.gitignore | |
| parent | 544c78a4e964b1971c2409f4dc805f2d4161990e (diff) | |
| download | rails-d1e7cd14c29f1ef45f2f36e79cd99eb580036991.tar.gz rails-d1e7cd14c29f1ef45f2f36e79cd99eb580036991.tar.bz2 rails-d1e7cd14c29f1ef45f2f36e79cd99eb580036991.zip | |
`includes` uses SQL parsing when String joins are involved.
This is a partial revert of 22b3481ba2aa55fad1f9a5db94072312b345fb55.
The current implementation of `references_eager_loaded_tables?` needs to know
every table involved in the query. With the current API this is not possible
without SQL parsing.
While a2dab46cae35a06fd5c5500037177492a047c252 deprecated SQL parsing for `includes`.
It did not issue deprecation warnings when String joins are involved. This resulted
in a breaking change after the deprecated behavior was removed (22b3481ba2aa55fad1f9a5db94072312b345fb55).
We will need to rethink the usage of `includes`, `preload` and `eager_load` but for now,
this brings back the old *working* behavior.
Diffstat (limited to '.gitignore')
0 files changed, 0 insertions, 0 deletions