diff options
author | John Hawthorn <john@hawthorn.email> | 2019-04-01 16:35:07 -0700 |
---|---|---|
committer | John Hawthorn <john@hawthorn.email> | 2019-04-03 09:02:28 -0700 |
commit | eb52904eb5c19ab4e8ff7a7d4f501fe5e1142ad0 (patch) | |
tree | 69e7486d27a6c0555473cea655cc4ab36c9f6c1a /.github | |
parent | beb0bc9907a31d0cbd2ca68c79c57a9e375761e8 (diff) | |
download | rails-eb52904eb5c19ab4e8ff7a7d4f501fe5e1142ad0.tar.gz rails-eb52904eb5c19ab4e8ff7a7d4f501fe5e1142ad0.tar.bz2 rails-eb52904eb5c19ab4e8ff7a7d4f501fe5e1142ad0.zip |
Always reject files external to app
Previously, when using `render file:`, it was possible to render files
not only at an absolute path or relative to the current directory, but
relative to ANY view paths. This was probably done for absolutely
maximum compatibility when addressing CVE-2016-0752, but I think is
unlikely to be used in practice.
Tihs commit removes the ability to `render file:` with a path relative
to a non-fallback view path.
Make FallbackResolver.new private
To ensure nobody is making FallbackResolvers other than "/" and "".
Make reject_files_external_... no-op for fallbacks
Because there are only two values used for path: "" and "/", and
File.join("", "") == File.join("/", "") == "/", this method was only
testing that the absolute paths started at "/" (which of course all do).
This commit doesn't change any behaviour, but it makes it explicit that
the FallbackFileSystemResolver works this way.
Remove outside_app_allowed argument
Deprecate find_all_anywhere
This is now equivalent to find_all
Remove outside_app argument
Deprecate find_file for find
Both LookupContext#find_file and PathSet#find_file are now equivalent to
their respective #find methods.
Diffstat (limited to '.github')
0 files changed, 0 insertions, 0 deletions