Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Support Oracle bind parameter value | Yasuo Honda | 2014-11-20 | 1 | -1/+12 |
| | |||||
* | Use class objects rather than strings for the dispatch cache | Sean Griffin | 2014-11-18 | 1 | -1/+1 |
| | | | | | | | | The only reason we're using strings is to pre-populate the cache, but `Class#name` returns a new string instance on every call. This is a pretty major source of memory usage. We don't technically need to pre-populate the cache, and not doing so allows us to go back to using cache objects | ||||
* | Add order to BindParams in the ToSql collector | Sean Griffin | 2014-11-17 | 6 | -10/+27 |
| | | | | | | | | | | | | This removes the need for us to do the re-ordering by walking the AST in ActiveRecord. We're using a block to communicate with the collector, since the collector needs to be the thing which knows about the index, while the visitor is the thing that needs to know the syntax. The BindParam needs to know about neither of these things, so it's been changed to stop being a subclass of SqlLiteral I could also see an alternative implementation using format strings if for some reason blocks cause a problem. | ||||
* | Revert "Revert "Merge pull request #300 from jpcody/master"" | Sean Griffin | 2014-10-31 | 1 | -10/+7 |
| | | | | | | This reverts commit 9b92af7098b2728ced578ab9a7679176d20f120f. beta2 is out, and we've fixed the issue that this caused in Rails | ||||
* | Revert "Merge pull request #300 from jpcody/master" | Sean Griffin | 2014-10-30 | 1 | -7/+10 |
| | | | | | This reverts commit 36836fa5e7c084c0dce2818577e6fd0cf815f786, reversing changes made to 53bc8426648cc93695525e8f12102cd416b2d772. | ||||
* | Deprecate passing ranges to `#in` and `#not_in` | Sean Griffin | 2014-10-25 | 3 | -145/+143 |
| | | | | | | | The goal of these methods should be to generate in nodes, not handle every possible permutation of more than one value. The `#between` and `#not_between` methods have been extracted, which better represent the semantics of handling ranges in SQL. | ||||
* | 💣 | Sean Griffin | 2014-10-25 | 1 | -4/+4 |
| | |||||
* | Merge pull request #331 from sgrif/sg-in-should-not-break-queries | Sean Griffin | 2014-10-24 | 1 | -6/+6 |
|\ | | | | | `#not_in` with a range should respect proper precedence | ||||
| * | `#not_in` with a range should respect proper precedence | Sean Griffin | 2014-10-24 | 1 | -6/+6 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, doing ```ruby relation[:id].not_eq(4).and(relation[:id].not_in(1..3)) ``` will generate ```sql "id" != 4 AND "id" < 1 OR "id" > 3 ``` Which would incorrectly include records with an id of 4, as the OR statement has higher precidence than the AND statement. The `or` method on `Node` properly groups the statement in parenthesis. | ||||
* | | Merge pull request #332 from sgrif/sg-include-in-test-coverage | Sean Griffin | 2014-10-24 | 1 | -8/+201 |
|\ \ | | | | | | | Improve test coverage for `#in` and `#not_in` | ||||
| * | | Improve test coverage for `#in` and `#not_in` | Sean Griffin | 2014-10-24 | 1 | -8/+201 |
| |/ | | | | | | | | | | | These methods are going to go through some heavy refactoring, and moving logic around. This adds missing tests for each of the branches on the predicate. | ||||
* / | Binary nodes should not generate the same hash as nodes of other classes | Sean Griffin | 2014-10-24 | 1 | -0/+26 |
|/ | |||||
* | {Matches,DoesNotMatch} support the ESCAPE clause | Tamir Duberstein | 2014-09-25 | 1 | -0/+14 |
| | |||||
* | move the dispatch table to be per-instance | Aaron Patterson | 2014-09-22 | 2 | -7/+1 |
| | | | | | | | visitors are not shared among threads, so any mutations to the cache should be OK. The cache is also pre-populated on construction, but we should pull that out so we can share the cache among visitors in the future. | ||||
* | Fix set visiting spec | Dimko | 2014-09-17 | 1 | -1/+1 |
| | |||||
* | Merge pull request #167 from pparidans/informix-v9-support | Rafael Mendonça França | 2014-09-17 | 1 | -6/+6 |
|\ | | | | | Informix versions < 10 use 'FIRST' keyword instead of 'LIMIT' | ||||
| * | Informix versions < 10 use 'FIRST' keyword instead of 'LIMIT' | Pierre Paridans | 2014-09-16 | 1 | -6/+6 |
| | | | | | | | | Still supported in versions 10+ | ||||
* | | Merge pull request #137 from dimko/visit_set | Rafael Mendonça França | 2014-09-17 | 2 | -0/+13 |
|\ \ | |/ |/| | Added a visitor for Set objects | ||||
| * | added a visitor for Set objects | Dimko | 2012-09-18 | 2 | -0/+13 |
| | | |||||
* | | Wrap group_by sql with a subquery for limiting rows in Oracle. | Chris Dinger | 2014-09-16 | 1 | -0/+10 |
| | | | | | | | | Fixes #128 | ||||
* | | `Extract#as` should not mutate the receiver | Tamir Duberstein | 2014-09-13 | 1 | -0/+8 |
| | | | | | | | | Fixes https://github.com/rails/rails/issues/16913 | ||||
* | | Merge pull request #306 from mxhold/master | Rafael Mendonça França | 2014-09-12 | 1 | -0/+21 |
|\ \ | | | | | | | Add SelectManager#distinct_on to set/unset Arel::Nodes::DistinctOn quantifier | ||||
| * | | Add SelectManager#distinct_on to set/unset Arel::Nodes::DistinctOn quantifier | Max Holder | 2014-08-30 | 1 | -0/+21 |
| | | | |||||
* | | | Merge pull request #304 from bigxiang/fix_lt_and_lteq_error | Rafael Mendonça França | 2014-09-12 | 1 | -0/+44 |
|\ \ \ | | | | | | | | | Fix lt & lteq don't accept most of values. | ||||
| * | | | Change specs to cover lt, lteq, gt and gteq. | bigxiang | 2014-08-31 | 1 | -4/+42 |
| | | | | |||||
| * | | | Fix lt & lteq don't accept most of values. | bigxiang | 2014-08-23 | 1 | -0/+6 |
| | | | | |||||
* | | | | Merge pull request #277 from sergey-alekseev/wrap-nested-gropings-only-once | Rafael Mendonça França | 2014-09-12 | 1 | -0/+7 |
|\ \ \ \ | |_|/ / |/| | | | Wrap nested Nodes::Grouping in brackets only once | ||||
| * | | | Wrap nested Nodes::Grouping in brackets only once | Sergey Alekseev | 2014-05-26 | 1 | -0/+7 |
| | | | | |||||
* | | | | Merge pull request #300 from jpcody/master | Matthew Draper | 2014-08-26 | 1 | -10/+7 |
|\ \ \ \ | |_|/ / |/| | | | Allow for alias omission in aggregate expressions | ||||
| * | | | Remove default aliases from aggregate functions | Joshua Cody | 2014-07-31 | 2 | -39/+7 |
| | | | | |||||
| * | | | Allow for alias omission in aggregate expressions | Joshua Cody | 2014-07-26 | 1 | -0/+29 |
| | | | | |||||
* | | | | Fix typo `gt` means `>` | ksss | 2014-08-21 | 1 | -1/+1 |
|/ / / | |||||
* | | | Merge pull request #291 from vipulnsward/rename-test | Rafael Mendonça França | 2014-06-30 | 1 | -52/+53 |
|\ \ \ | | | | | | | | | Cleanup SelectManager Test | ||||
| * | | | - Stop passing redundant `:engine => Table.engine` to `Table#new` | Vipul A M | 2014-06-15 | 1 | -51/+52 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Remove redundant `ast` variable creation - Rename similar join tests name to what they actually test - Move "joins itself" test to "joins" describe instead of defining describe block twice - Move update manager statement tests in logical order - Move `project` tests in logical order | ||||
| * | | | Rename ambiguous test name to what it actually tests | Vipul A M | 2014-06-15 | 1 | -1/+1 |
| | | | | |||||
* | | | | Add test for window + partition + order. | Alexander Staubo | 2014-06-22 | 1 | -0/+11 |
| | | | | |||||
* | | | | Windowing support for PARTITION BY clause. | Alexander Staubo | 2014-06-20 | 2 | -3/+39 |
| | | | | |||||
* | | | | Merge pull request #292 from mekishizufu/dot_visitor_api | Rafael Mendonça França | 2014-06-15 | 1 | -4/+4 |
|\ \ \ \ | | | | | | | | | | | Modify Visitors::Dot's API to use collectors | ||||
| * | | | | Modify Visitors::Dot's API to use collectors | Jiri Pospisil | 2014-06-14 | 1 | -4/+4 |
| |/ / / | |||||
* / / / | - Test noop when passing empty list to `insert` | Vipul A M | 2014-06-15 | 1 | -3/+8 |
|/ / / | | | | | | | | | | | | | - Rename into test to indicate it accepts table and chains on it - Rename "combo" test to what it actually tests | ||||
* | | | Merge pull request #290 from mekishizufu/fix_select_manager_as_subquery | Rafael Mendonça França | 2014-06-13 | 1 | -0/+11 |
|\ \ \ | | | | | | | | | Support passing of SelectManager to attribute methods | ||||
| * | | | Make sure Arel::SelectManager is not mistaken for an attribute | Jiri Pospisil | 2014-06-12 | 1 | -0/+11 |
| | | | | |||||
* | | | | Add test for non-recursive WITH statement | Jiri Pospisil | 2014-06-12 | 1 | -0/+14 |
|/ / / | |||||
* | | | rm empty spec which is covered by other specs | Vipul A M | 2014-06-07 | 1 | -2/+0 |
| | | | |||||
* | | | - Fix ambiguous argument warning | Vipul A M | 2014-05-31 | 2 | -2/+2 |
| | | | | | | | | | | | | - Fix typo: `test_opertaion_ordering` => `test_operation_ordering` | ||||
* | | | Merge pull request #276 from brocktimus/master | Rafael Mendonça França | 2014-05-28 | 1 | -0/+5 |
|\ \ \ | | | | | | | | | Fixing method signature for unsupported visits in the ToSQL Visitor | ||||
| * | | | Asserting on error message | Brock Trappitt | 2014-05-28 | 1 | -3/+2 |
| | | | | |||||
| * | | | Test which checks the error being raised by #unsupported in ToSql Visitor | Brock Trappitt | 2014-05-27 | 1 | -0/+6 |
| |/ / | |||||
* / / | Fix warning form bind collector test | Vipul A M | 2014-05-25 | 1 | -1/+1 |
|/ / | |||||
* | | Merge pull request #271 from jordansexton/patch-2 | Rafael Mendonça França | 2014-05-19 | 1 | -0/+16 |
|\ \ | | | | | | | Added update and delete convenience methods |