aboutsummaryrefslogtreecommitdiffstats
path: root/test/visitors
Commit message (Collapse)AuthorAgeFilesLines
* Support `columns_for_distinct`Yasuo Honda2013-10-141-1/+2
|
* Cache visitor dispatch on a per-visitor basisColin Jones2013-08-141-0/+22
|
* Make visitors threadsafe by removing @last_columnErnie Miller2013-04-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | The last_column feature of the ToSql visitor and its descendants is what enabled quoting based on the column last visited -- in other words, if you have a standard condition like an equality with a string attribute on the left side and an integer on the right side, then when ARel visits the node, it'll first visit the left side attribute, setting the column of the string attribute as the last column, and resulting in the right side of the condition getting the appropriate quoting. The downside is that this means that visitors can't be shared between threads, because of the state mutation. It also makes for some really weird behavior in the event that the visitor visits a node that happens to contain an attribute you weren't expecting to be there, since it'll potentially quote something based on that attribute. So, it prevents reversing an equality condition. column = value will work, but not value = column, since the last column wouldn't be the column you're hoping for. This is a first pass at fixing this by changing the signature of the visit methods to accept the currently-relevant attribute, if any.
* Update test_oracle.rbEduardo Mourao2013-03-151-1/+2
|
* Support Float::INFINITY in rangesTim Pope2013-02-191-0/+34
|
* Merge pull request #161 from Noemj/masterAaron Patterson2013-02-051-1/+20
|\ | | | | Mysql2 prepared statements bind substitution fix
| * Added unit test for the mysql2 bind substitutionNoemj2013-02-051-1/+20
| |
* | Add oracle paging optimization discussed in issue 99tom2013-01-081-1/+1
|/
* Merge pull request #140 from sunaku/GH-139Aaron Patterson2012-09-241-0/+39
|\ | | | | bugfix: some aggregations lacked DISTINCT emission
| * GH-139: some aggregations lacked DISTINCT emissionSuraj N. Kurapati2012-09-211-0/+39
| |
* | to_sql: add support for emitting SQL subqueriesSuraj N. Kurapati2012-09-221-0/+5
|/
* Fix in [] to be false, in [] to be trueErnie Miller2012-06-141-8/+4
| | | | This is in response to discussion on 62207fa
* Do not generate NOT IN (NULL) when empty rightSantiago Pastorino2012-06-131-4/+4
|
* Adds visit_Arel_Nodes_InfixOperation to Arel::Visitors::DepthFirstBenedikt Deicke2012-03-221-0/+6
|
* Patch Informix Visitor so that it includes joinsJordan2012-02-291-0/+10
|
* Support ANSI SQL2003 window functions.Alexander Staubo2012-02-221-2/+4
|
* added a module for visiting and transforming bind valuesAaron Patterson2012-02-211-0/+39
|
* bind parameters can be differentiated from sql literalsAaron Patterson2012-02-201-0/+6
|
* Oracle limit and offset issue when query is ordered, issue #99 solved.babinho2012-02-171-2/+1
|
* calling cache methods against the connectionAaron Patterson2011-11-197-27/+9
|
* Support locking by default and disable it only for SQLite.Edgars Beigarts2011-08-261-0/+5
|
* Support locking in OracleEdgars Beigarts2011-08-261-0/+7
|
* Make it the responsibility of the connection to hold on to a visitor for ↵Jon Leighton2011-08-089-11/+11
| | | | generating SQL, rather than the TreeManager. (There is a related commit coming in Active Record.)
* Add nodes for boolean constantsDaniel Cadenas2011-08-031-0/+16
| | | | | | | | | | | | This is useful for dynamically created predicates e.g: expr1 = table.create_false expr2 = table.create_false expr1 = create_a_predicate() if some_condition expr2 = create_another_predicate() if some_other_condition table.where(expr1.and(expr2))
* supressing nested parenthesis in multiple unions on mysql. thanks jhtwong. ↵Aaron Patterson2011-07-201-0/+10
| | | | fixes #58
* Merge branch 'master' into Khronos/masterAaron Patterson2011-06-274-11/+67
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | * master: visitors can define their own cache strategy for dispatch. fixes #57 Break Ordering into Ascending/Descending nodes, allow reversal remove unnecessary guarding agains literal LIMIT and OFFSET support for MS SQL Include Arel::Predicates to Arel::Nodes::Function so you can do table[:id].count.eq(2) updating spec zomg prep release make sure thread runs do not cache sql literal values no longer use this instance variable
| * visitors can define their own cache strategy for dispatch. fixes #57Aaron Patterson2011-06-271-0/+16
| |
| * Merge pull request #60 from arkadiyk/masterAaron Patterson2011-06-241-8/+47
| |\ | | | | | | Better support for MSSQL
| | * remove unnecessary guarding agains literalarkadiy kraportov2011-06-101-8/+0
| | |
| | * LIMIT and OFFSET support for MS SQLarkadiy kraportov2011-06-091-8/+55
| | |
| * | Break Ordering into Ascending/Descending nodes, allow reversalErnie Miller2011-06-152-2/+2
| |/
| * make sure thread runsAaron Patterson2011-05-171-0/+1
| |
| * no longer use this instance variableAaron Patterson2011-05-171-1/+1
| |
* | Added an additional test since skip/limit can not be used in reverse orderMartin Little2011-05-161-0/+8
| |
* | Added a basic test for the informix visitorMartin Little2011-05-161-0/+34
|/
* Make ToSql more thread safe.Damon McCormick + Cameron Walters2011-05-101-0/+17
| | | | | | | Because the ToSql visitor instance is shared across all threads, there is a race condition around column types for binary nodes. It's possible, for instance, to end up with ActiveRecord converting a string value in the final SQL to an integer during heavy concurrent operations.
* Stop calling to_s on aliases, require them to be strings already.Ernie Miller2011-04-292-4/+4
|
* Move #as to AliasPredication, stop overriding Function's #as.Ernie Miller2011-04-291-3/+3
|
* replace 'LIMIT n' with 'FETCH FIRST n ROWS ONLY' when using ibm_dbShane Emmons2011-04-291-0/+27
|
* raising not implemented exceptions for distinct on where it is not supportedAaron Patterson2011-04-211-0/+11
|
* adding Distinct ON nodeAaron Patterson2011-04-212-2/+13
|
* Replace MathOperation with InfixOperation to support more operatorsErnie Miller2011-03-091-1/+10
|
* Merge branch 'master' of github.com:rails/arelAaron Patterson2011-03-071-0/+9
|\ | | | | | | | | * 'master' of github.com:rails/arel: Add an #table_name method to Table and TableAlias, which always returns the actual table name, not the alias. Then fix ToSql#column_for to use this table name when checking whether the table exists (rather than before, where it was checking whether a table with the alias name exists, which was incorrect).
| * Add an #table_name method to Table and TableAlias, which always returns the ↵Jon Leighton2011-03-041-0/+9
| | | | | | | | actual table name, not the alias. Then fix ToSql#column_for to use this table name when checking whether the table exists (rather than before, where it was checking whether a table with the alias name exists, which was incorrect).
* | Merge remote branch 'stiff/master' into omgAaron Patterson2011-03-071-0/+22
|\ \ | |/ |/| | | | | * stiff/master: implemented support for math operations in numeric attributes
| * implemented support for math operations in numeric attributesVladimir Meremyanin2011-01-291-0/+22
| |
* | refactoring custom lock logic to use sql literalsAaron Patterson2011-02-212-4/+4
| |
* | Lock should be a unary nodeAaron Patterson2011-02-213-3/+3
| |
* | Merge remote branch 'jstorimer/master' into omgAaron Patterson2011-02-212-9/+23
|\ \ | | | | | | | | | | | | * jstorimer/master: Allow database specific locking clauses to be used
| * | Allow database specific locking clauses to be usedJesse Storimer2011-01-202-9/+23
| | |