aboutsummaryrefslogtreecommitdiffstats
path: root/test/visitors
Commit message (Collapse)AuthorAgeFilesLines
* Address `undefined method `value_for_database'` in Oracle visitorYasuo Honda2017-07-251-1/+1
| | | | | | Here `offset` is bound twice. It used to be `:b1` appeared twice. This commit changes the second `offset` name changed from `:b1` to `:b3` which should not affect the actual bind values for offset.
* Fix test failuresSean Griffin2017-07-245-11/+11
|
* Add a value field `Nodes::BindParam`Sean Griffin2017-07-216-72/+11
| | | | | | | | | | | | | | | | | | | | This is part of a greater refactoring to have the `BindParam` nodes hold onto their values. We want to generally keep the AST decoupled from what you're actually doing with those values, but ultimately the usage of `BindParam` is almost identical to how you'd use `Casted` or `Quoted`. Forcing consumers of Arel's API to maintain the bind values separately from the AST makes manipulating the AST essentially impossible, as you would need to perform a full walk of the AST to determine whether a given node contains bind parameters, and which value it maps to. By storing the value on the bind parameter directly, we can collect them in another AST pass (realistically it'll be part of the same pass that performs SQL construction for performance reasons). This will dramatically simplify AST manipulation for Rails or any other consumers that work with bind params. As part of this change I've removed the `BindVisitor`, which appears to be dead code, and had tests break from this change.
* Merge pull request #472 from film42/masterMatthew Draper2017-06-051-0/+49
|\ | | | | Make Visitor visit thread safe by holding dispatch method reference
| * Test concurrency of visitor superclass fallbackMatthew Draper2017-06-051-0/+49
| |
* | Revert "Merge pull request #482 from kirs/multiple-insert"Rafael Mendonça França2017-05-041-1/+1
| | | | | | | | | | | | | | This reverts commit 6d105c7f891a14316eab47dfff3bf1b94f3204e7, reversing changes made to 437aa3a4bb8ad4f3f4eba299dbb1112852f9c7ac. This broke Active Record when the values are sql literals
* | Support multiple insertsKir Shatrov2017-05-011-1/+1
| |
* | Merge pull request #470 from kmmndr/named_function_eq_nilRafael França2017-02-211-0/+6
|\ \ | |/ |/| named functions compared to nil
| * named functions compared to nilThomas Kienlen2017-02-021-0/+6
| |
* | Enable frozen_string_literal in all files in arelRafael Mendonça França2017-02-1313-0/+13
|/
* Fix identationRafael Mendonça França2016-12-291-7/+7
|
* Remove deprecated type cast support in ArelRafael Mendonça França2016-12-291-71/+2
|
* Merge pull request #445 from oliverguenther/fix/dot-visitor-casted-nodeRafael França2016-10-071-0/+1
|\ | | | | Add Arel::Nodes::Casted to dot visitor
| * Add Arel::Nodes::Casted to dot visitorOliver Günther2016-08-271-0/+1
| | | | | | | | | | | | | | Adds casted node to the dot visitor with outgoing edges to val and attribute. Fixes #419
* | Merge pull request #447 from ojab/masterRafael França2016-10-071-1/+1
|\ \ | | | | | | Freeze all the strings in visitors
| * | Drop unneeded assignmentojab2016-08-311-1/+1
| | |
* | | Fix issue #438 when oracle visitor gets BindParamsRodrigo Castro2016-10-071-1/+15
|/ /
* / Add failing test for Dot visitor and BindParamAdam Lassek2016-08-261-0/+6
|/ | | | | | | | | Since BindParam has no value, treating it like a string causes it to fallback to Object#to_s, leading to output like `#<Arel::Nodes::BindParam:0x007fa43c866108>`. Since angle brackets are significant in Dot labels, this causes `Error: bad label format` when passing the graph into dot.
* Merge pull request #417 from tlkahn/masterRafael França2016-07-191-0/+7
|\ | | | | Fix issue #415 - Should Arel::Nodes::True.new() be 1 in sqlite3?
| * Fix issue #415 - Should Arel::Nodes::True.new() be 1 in sqlite3?Yong Guo2016-03-011-0/+7
| |
* | Merge pull request #422 from yahonda/oracle12_support_bind_valueSean Griffin2016-05-061-2/+13
|\ \ | | | | | | Support Oracle bind parameter value for Oracle12 visitor
| * | Support Oracle bind parameter value for Oracle12 visitorYasuo Honda2016-04-111-2/+13
| |/
* | Merge pull request #432 from tradegecko/pg-grouping-elements-supportRafael França2016-05-051-0/+78
|\ \ | | | | | | PG: Add Support for GroupBy's Cube, Rollup and Grouping Set
| * | Add Support for GroupBy Cube, Rollup and Grouping Set Syntax for PostgreSQL ↵Mohammad Habbab2016-05-041-0/+78
| | | | | | | | | | | | Visitor
* | | Raise ArgumentError if limit and lock are used for Oracle12 visitorYasuo Honda2016-05-021-3/+4
|/ / | | | | | | | | | | | | it would generates `SELECT ... FETCH FIRST n ROWS ONLY FOR UPDATE` which causes Oracle 12c database returns this error : ORA-02014: cannot select FOR UPDATE from view with DISTINCT, GROUP BY, etc.
* / Fix warnings from test_to_sql testVipul A M2016-04-111-1/+1
|/
* * Support for bitwise operations as infix operators. Tests included.Shahbaz Javeed2016-01-061-0/+37
| | | | | | | | | | | | | | | | | | | | | | *** Individual commit messages included below *** * Preliminary support for bitwise operations as infix operators. Tests to follow. * Added bitwise xor, shift left and shift right operators * Fixed the BitwiseOr class so it uses the :| operator instead of :& * All the methods for the bitwise operators in the Arel::Math module now wrap them up in Arel::Nodes::Grouping so the operation becomes isolated like addition and subtraction * Preliminary set of tests for the new operators * Updated README with examples of bitwise operations * Added a new UnaryOperation class which is a riff on the InfixOperation class * Added tests for UnaryOperation (inspired by InfixOperation tests) * Added the bitwise not (~) operator as a UnaryOperation * Added tests for the bitwise not operator * Added documentation for the bitwise not operator * Updated gemspec using `rake arel.gemspec`
* Add database specific string concatenationKeenan Brock2016-01-053-2/+27
|
* Implement CASE Conditional ExpressionFelix Bünemann2016-01-052-0/+72
|
* Merge pull request #369 from codeodor/patch-1Rafael França2015-12-171-3/+3
|\ | | | | Improve error message when passed unsupported type
| * Use a specific exception for unsupported visitsSammy Larbi2015-07-141-3/+3
| |
* | Merge pull request #390 from yahonda/expr_oracle12Rafael França2015-12-171-2/+2
|\ \ | | | | | | No need to quote limit for Oracle12 visitor
| * | No need to quote limit for Oracle12 visitorYasuo Honda2015-09-011-2/+2
| |/
* | test match predicate case sensitivity attributeKeenan Brock2015-12-051-0/+6
| |
* | introduce predicate {does_not_}matches_regexp Keenan Brock2015-12-051-6/+13
| |
* | use valid regular expression in regexp testKeenan Brock2015-12-051-12/+12
| |
* | Add case sensitive regexpKeenan Brock2015-12-051-0/+14
| | | | | | | | | | | | | | Explicitly declare if this is case sensitive or not currently postgres assumes case insensitive regexp no other databases support regexps
* | Add case sensitive matchKeenan Brock2015-12-051-0/+14
|/ | | | | | | Explicitly declare if this is case sensitive or not most implementation assume case sensitive postgres assumes case insensitive
* Merge pull request #337 from yahonda/support_oracle12_top_n_2Aaron Patterson2015-07-141-0/+47
|\ | | | | Support Oracle 12c top-N query
| * Create Arel::Visitors::Oracle12 to provide better top-N queryYasuo Honda2015-06-191-0/+47
| | | | | | | | to support `FETCH FIRST n ROWS` and `OFFSET` for Oracle 12c database
* | Follow up #370 for Oracle, to fix undefined method `expr' for 10:Fixnum bug.Eric Guo2015-07-141-2/+2
|/
* Special limited delete handling in MSSQLTamir Duberstein2015-02-231-0/+9
| | | | | Refernce: https://technet.microsoft.com/en-us/library/ms175486%28v=sql.105%29.aspx
* Change the interface of `having` to match that of `where`Sean Griffin2015-01-272-4/+2
| | | | | | These two clauses have nearly identical semantics with regards to how they would be constructed as an AST. It doesn't make sense for their interfaces to be separate.
* {Matches,DoesNotMatch} support the ESCAPE clause with PostgreSQLKazuya NUMATA2014-12-251-0/+14
| | | | | to_SQL already has supported the ESCAPE clause in #318. PostgreSQL can use the ESCAPE clause too.
* Remove `engine` from `TreeManager` and subclassesSean Griffin2014-11-291-1/+1
| | | | | | This constructor parameter was unused for everything except the convenience methods `to_sql` and `where_sql`. We can pass the engine into those methods directly.
* Remove deprecated method "Table#primary_key"Sean Griffin2014-11-261-0/+19
| | | | | | | The only place this method was still used is on the MSSQL visitor. The visitor has all of the objects required to inline this lookup there. Since the `primary_key` method on the connection adapter will perform a query when called, we can cache the result on the visitor.
* remove extra space before 'ORDER BY'Nihad Abbasov2014-11-261-1/+8
|
* Support Oracle bind parameter valueYasuo Honda2014-11-201-1/+12
|
* Use class objects rather than strings for the dispatch cacheSean Griffin2014-11-181-1/+1
| | | | | | | | The only reason we're using strings is to pre-populate the cache, but `Class#name` returns a new string instance on every call. This is a pretty major source of memory usage. We don't technically need to pre-populate the cache, and not doing so allows us to go back to using cache objects
* Add order to BindParams in the ToSql collectorSean Griffin2014-11-173-4/+21
| | | | | | | | | | | | This removes the need for us to do the re-ordering by walking the AST in ActiveRecord. We're using a block to communicate with the collector, since the collector needs to be the thing which knows about the index, while the visitor is the thing that needs to know the syntax. The BindParam needs to know about neither of these things, so it's been changed to stop being a subclass of SqlLiteral I could also see an alternative implementation using format strings if for some reason blocks cause a problem.
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-26 19:56:49 +0000