aboutsummaryrefslogtreecommitdiffstats
path: root/test/visitors/test_to_sql.rb
Commit message (Collapse)AuthorAgeFilesLines
* Make visitors threadsafe by removing @last_columnErnie Miller2013-04-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | The last_column feature of the ToSql visitor and its descendants is what enabled quoting based on the column last visited -- in other words, if you have a standard condition like an equality with a string attribute on the left side and an integer on the right side, then when ARel visits the node, it'll first visit the left side attribute, setting the column of the string attribute as the last column, and resulting in the right side of the condition getting the appropriate quoting. The downside is that this means that visitors can't be shared between threads, because of the state mutation. It also makes for some really weird behavior in the event that the visitor visits a node that happens to contain an attribute you weren't expecting to be there, since it'll potentially quote something based on that attribute. So, it prevents reversing an equality condition. column = value will work, but not value = column, since the last column wouldn't be the column you're hoping for. This is a first pass at fixing this by changing the signature of the visit methods to accept the currently-relevant attribute, if any.
* Support Float::INFINITY in rangesTim Pope2013-02-191-0/+34
|
* Merge pull request #140 from sunaku/GH-139Aaron Patterson2012-09-241-0/+39
|\ | | | | bugfix: some aggregations lacked DISTINCT emission
| * GH-139: some aggregations lacked DISTINCT emissionSuraj N. Kurapati2012-09-211-0/+39
| |
* | to_sql: add support for emitting SQL subqueriesSuraj N. Kurapati2012-09-221-0/+5
|/
* Fix in [] to be false, in [] to be trueErnie Miller2012-06-141-8/+4
| | | | This is in response to discussion on 62207fa
* Do not generate NOT IN (NULL) when empty rightSantiago Pastorino2012-06-131-4/+4
|
* bind parameters can be differentiated from sql literalsAaron Patterson2012-02-201-0/+6
|
* calling cache methods against the connectionAaron Patterson2011-11-191-21/+3
|
* Make it the responsibility of the connection to hold on to a visitor for ↵Jon Leighton2011-08-081-3/+3
| | | | generating SQL, rather than the TreeManager. (There is a related commit coming in Active Record.)
* Add nodes for boolean constantsDaniel Cadenas2011-08-031-0/+16
| | | | | | | | | | | | This is useful for dynamically created predicates e.g: expr1 = table.create_false expr2 = table.create_false expr1 = create_a_predicate() if some_condition expr2 = create_another_predicate() if some_other_condition table.where(expr1.and(expr2))
* visitors can define their own cache strategy for dispatch. fixes #57Aaron Patterson2011-06-271-0/+16
|
* make sure thread runsAaron Patterson2011-05-171-0/+1
|
* no longer use this instance variableAaron Patterson2011-05-171-1/+1
|
* Make ToSql more thread safe.Damon McCormick + Cameron Walters2011-05-101-0/+17
| | | | | | | Because the ToSql visitor instance is shared across all threads, there is a race condition around column types for binary nodes. It's possible, for instance, to end up with ActiveRecord converting a string value in the final SQL to an integer during heavy concurrent operations.
* raising not implemented exceptions for distinct on where it is not supportedAaron Patterson2011-04-211-0/+11
|
* Replace MathOperation with InfixOperation to support more operatorsErnie Miller2011-03-091-1/+10
|
* Merge branch 'master' of github.com:rails/arelAaron Patterson2011-03-071-0/+9
|\ | | | | | | | | * 'master' of github.com:rails/arel: Add an #table_name method to Table and TableAlias, which always returns the actual table name, not the alias. Then fix ToSql#column_for to use this table name when checking whether the table exists (rather than before, where it was checking whether a table with the alias name exists, which was incorrect).
| * Add an #table_name method to Table and TableAlias, which always returns the ↵Jon Leighton2011-03-041-0/+9
| | | | | | | | actual table name, not the alias. Then fix ToSql#column_for to use this table name when checking whether the table exists (rather than before, where it was checking whether a table with the alias name exists, which was incorrect).
* | Merge remote branch 'stiff/master' into omgAaron Patterson2011-03-071-0/+22
|\ \ | |/ |/| | | | | * stiff/master: implemented support for math operations in numeric attributes
| * implemented support for math operations in numeric attributesVladimir Meremyanin2011-01-291-0/+22
| |
* | Test for NamedFunction predication chainingDaniel Azuma2011-01-191-0/+6
|/
* Added Arel::Nodes::NamedFunction for representing generic SQL functionsAaron Patterson2011-01-041-0/+10
|
* Merge branch '2-0-stable' into mergeAaron Patterson2011-01-031-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * 2-0-stable: updating history Patched Arel v2.0.6 to support MSSQL SQL queries. Based on work of James Abley (https://github.com/jabley/arel). consolidating dot visitor methods refactoring where, fixing subselect implementation for passing a subquery to #in and #not_in tests for passing a subquery to #in and #not_in limit members of the AST are visited quoting limit nodes Conflicts: History.txt lib/arel/nodes.rb lib/arel/nodes/select_core.rb lib/arel/select_manager.rb lib/arel/visitors/to_sql.rb test/visitors/test_to_sql.rb
| * Patched Arel v2.0.6 to support MSSQL SQL queries. Based on work of James ↵Viacheslav Petrenko2011-01-031-1/+1
| | | | | | | | Abley (https://github.com/jabley/arel).
| * tests for passing a subquery to #in and #not_inSven Fuchs2010-12-071-0/+18
| |
| * quoting limit nodesAaron Patterson2010-12-071-0/+6
| |
* | sql literals may be used as column attributesAaron Patterson2010-12-221-1/+8
| |
* | stop using deprecated AND usageAaron Patterson2010-12-091-2/+2
| |
* | Merge remote branch 'sven/in-subquery' into subqueryAaron Patterson2010-12-071-0/+18
|\ \ | | | | | | | | | | | | | | | * sven/in-subquery: implementation for passing a subquery to #in and #not_in tests for passing a subquery to #in and #not_in
| * | tests for passing a subquery to #in and #not_inSven Fuchs2010-12-071-0/+18
| | |
* | | Merge branch '2-0-stable'Aaron Patterson2010-12-061-0/+6
|\ \ \ | |/ / |/| | | | | | | | | | | * 2-0-stable: quoting limit nodes Make "not" apply to the whole sub-expression when generating sql.
| * | quoting limit nodesAaron Patterson2010-12-061-0/+6
| |/
| * Make "not" apply to the whole sub-expression when generating sql.Ryan Rempel2010-12-061-1/+7
| |
* | Make "not" apply to the whole sub-expression when generating sql.Ryan Rempel2010-12-061-1/+7
| |
* | attributes do not need a column memberAaron Patterson2010-12-031-3/+7
|/
* adding deprecated support for walking ancestor treesAaron Patterson2010-11-301-0/+5
|
* adding an AS nodeAaron Patterson2010-11-231-0/+6
|
* adding a "not" factory method for creating Not nodesAaron Patterson2010-11-231-0/+5
|
* Added tests for Nodes::NotIn.Rolf Timmermans2010-11-181-0/+46
|
* added a visitor for Class objectsAaron Patterson2010-11-161-0/+4
|
* adding proper columns to our fake tableAaron Patterson2010-11-051-7/+6
|
* Add ToSql NilClass visitorErnie Miller2010-11-041-0/+4
|
* Added Bignum to visitorrugek2010-10-261-0/+4
|
* renaming test_helper to helper so that it is not double requiredAaron Patterson2010-10-181-1/+1
|
* Renamed spec_helper to test_helperRyan Davis2010-10-181-1/+1
|
* Fisting arel specs -- still needs tree_manager and cleanupRyan Davis2010-10-181-0/+134
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-24 11:18:23 +0000