Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix test failures | Sean Griffin | 2017-07-24 | 1 | -4/+4 |
| | |||||
* | Add a value field `Nodes::BindParam` | Sean Griffin | 2017-07-21 | 1 | -4/+4 |
| | | | | | | | | | | | | | | | | | | | | This is part of a greater refactoring to have the `BindParam` nodes hold onto their values. We want to generally keep the AST decoupled from what you're actually doing with those values, but ultimately the usage of `BindParam` is almost identical to how you'd use `Casted` or `Quoted`. Forcing consumers of Arel's API to maintain the bind values separately from the AST makes manipulating the AST essentially impossible, as you would need to perform a full walk of the AST to determine whether a given node contains bind parameters, and which value it maps to. By storing the value on the bind parameter directly, we can collect them in another AST pass (realistically it'll be part of the same pass that performs SQL construction for performance reasons). This will dramatically simplify AST manipulation for Rails or any other consumers that work with bind params. As part of this change I've removed the `BindVisitor`, which appears to be dead code, and had tests break from this change. | ||||
* | Enable frozen_string_literal in all files in arel | Rafael Mendonça França | 2017-02-13 | 1 | -0/+1 |
| | |||||
* | Fix issue #438 when oracle visitor gets BindParams | Rodrigo Castro | 2016-10-07 | 1 | -1/+15 |
| | |||||
* | Follow up #370 for Oracle, to fix undefined method `expr' for 10:Fixnum bug. | Eric Guo | 2015-07-14 | 1 | -2/+2 |
| | |||||
* | Support Oracle bind parameter value | Yasuo Honda | 2014-11-20 | 1 | -1/+12 |
| | |||||
* | Wrap group_by sql with a subquery for limiting rows in Oracle. | Chris Dinger | 2014-09-16 | 1 | -0/+10 |
| | | | | Fixes #128 | ||||
* | Support to add the casting node to the AST at build time | Yasuo Honda | 2014-05-05 | 1 | -2/+2 |
| | | | | Ref https://github.com/rails/arel/commit/93d72131bcc24ccb5536bec672d2dac94f8de651 | ||||
* | oracle tests passing | Aaron Patterson | 2014-04-08 | 1 | -19/+23 |
| | |||||
* | Support `columns_for_distinct` | Yasuo Honda | 2013-10-14 | 1 | -1/+2 |
| | |||||
* | Update test_oracle.rb | Eduardo Mourao | 2013-03-15 | 1 | -1/+2 |
| | |||||
* | Add oracle paging optimization discussed in issue 99 | tom | 2013-01-08 | 1 | -1/+1 |
| | |||||
* | Oracle limit and offset issue when query is ordered, issue #99 solved. | babinho | 2012-02-17 | 1 | -2/+1 |
| | |||||
* | Support locking in Oracle | Edgars Beigarts | 2011-08-26 | 1 | -0/+7 |
| | |||||
* | Make it the responsibility of the connection to hold on to a visitor for ↵ | Jon Leighton | 2011-08-08 | 1 | -1/+1 |
| | | | | generating SQL, rather than the TreeManager. (There is a related commit coming in Active Record.) | ||||
* | adding Distinct ON node | Aaron Patterson | 2011-04-21 | 1 | -2/+2 |
| | |||||
* | Added MINUS for Oracle | Brian Cardarella | 2011-01-23 | 1 | -0/+9 |
| | | | | Aliased :minus to :except for the SelectManager | ||||
* | fixing tests for oracle visitor | Aaron Patterson | 2011-01-03 | 1 | -6/+6 |
| | |||||
* | fix one more time order_hacks method for Oracle | Raimonds Simanovskis | 2010-11-16 | 1 | -0/+12 |
| | | | correctly split order string by commas ignoring commas which separate function arguments | ||||
* | generate correct select if only offset is present (in Oracle) | Raimonds Simanovskis | 2010-10-21 | 1 | -0/+16 |
| | |||||
* | renaming test_helper to helper so that it is not double required | Aaron Patterson | 2010-10-18 | 1 | -1/+1 |
| | |||||
* | got rid of retarded check method. down with rspec | Ryan Davis | 2010-10-18 | 1 | -3/+3 |
| | |||||
* | Renamed spec_helper to test_helper | Ryan Davis | 2010-10-18 | 1 | -1/+1 |
| | |||||
* | Fisting arel specs -- still needs tree_manager and cleanup | Ryan Davis | 2010-10-18 | 1 | -0/+111 |