Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Don't store all aliases to a table | Sean Griffin | 2016-09-13 | 1 | -8/+1 |
| | | | | | | | The aliases property of a table is never used other than for equality. However, the aliases that have been created for a table aren't really something that should affect whether a table is considered to be the same table or not. This removal does not appear to have any affect within Active Record or within Arel. | ||||
* | Remove `engine` from `TreeManager` and subclasses | Sean Griffin | 2014-11-29 | 1 | -4/+0 |
| | | | | | | This constructor parameter was unused for everything except the convenience methods `to_sql` and `where_sql`. We can pass the engine into those methods directly. | ||||
* | Remove engine from the constructor arguments `Arel::Table` | Sean Griffin | 2014-11-29 | 1 | -40/+6 |
| | | | | | | | | | | | | | | | It is never used outside of convenience methods which are only used in tests. In practice, it just made constructing tables more complicated on the rails side. This is the minimum possible change to remove the constructor argument, but continue to have the tests passing. I'm not sure if we have a reason to keep `project` and friends, and the solution might actually just be to remove the engine from `SelectManager` and friends. As such I've held off on deleting those methods. We need to figure out what to do with `Table#from`. It's old invocation, which read `table.from(table)` was certainly nonsensical. | ||||
* | Merge pull request #271 from jordansexton/patch-2 | Rafael Mendonça França | 2014-05-19 | 1 | -0/+16 |
|\ | | | | | Added update and delete convenience methods | ||||
| * | Added #update_manager and #delete_manager convenience methods for consistency | Jordan Sexton | 2014-05-17 | 1 | -0/+16 |
| | | |||||
* | | convenience method for outer_join | Brian Hahn | 2014-05-18 | 1 | -0/+14 |
|/ | |||||
* | Added right and full outer joins | Stephen Prater & Fire-Dragon-DoL | 2014-03-30 | 1 | -0/+14 |
| | |||||
* | add the casting node to the AST at build time | Aaron Patterson | 2014-03-24 | 1 | -1/+2 |
| | | | | | If we add the casting node to the ast at build time, then we can avoid doing the lookup at visit time. | ||||
* | Remove deprecated Arel::SqlLiteral | Rafael Mendonça França | 2014-02-10 | 1 | -3/+3 |
| | |||||
* | Add equality to ALL THE THINGS (that matter) | Ernie Miller | 2012-08-18 | 1 | -0/+24 |
| | | | | | | | | | | | | People are often trying to use ARel nodes inside ActiveRecord, and when they do so, lots of things can break, because ActiveRecord relies on Array#uniq and sometimes hash key equality to handle values that end up in wheres, havings, etc. By implementing equality for all the nodes, we should hopefully be able to prevent any nodes (even nodes containing other nodes) from failing an equality check they should otherwise pass, and alleviate many of these errors. Fixes #130 | ||||
* | Add an #table_name method to Table and TableAlias, which always returns the ↵ | Jon Leighton | 2011-03-04 | 1 | -0/+4 |
| | | | | actual table name, not the alias. Then fix ToSql#column_for to use this table name when checking whether the table exists (rather than before, where it was checking whether a table with the alias name exists, which was incorrect). | ||||
* | fixing create_string_join factory method | Aaron Patterson | 2010-12-14 | 1 | -2/+1 |
| | |||||
* | adding a join source node | Aaron Patterson | 2010-12-14 | 1 | -4/+2 |
| | |||||
* | removing tests of deprecated methods | Aaron Patterson | 2010-12-14 | 1 | -32/+0 |
| | |||||
* | creating string join nodes | Aaron Patterson | 2010-12-07 | 1 | -0/+7 |
| | |||||
* | adding a join factory method on the select manager | Aaron Patterson | 2010-12-07 | 1 | -0/+16 |
| | |||||
* | attributes do not need a column member | Aaron Patterson | 2010-12-03 | 1 | -7/+0 |
| | |||||
* | deprecating the update method in favor of compile_update | Aaron Patterson | 2010-12-02 | 1 | -6/+0 |
| | |||||
* | deprecating "insert" | Aaron Patterson | 2010-12-02 | 1 | -0/+12 |
| | |||||
* | do not use private methods | Aaron Patterson | 2010-11-16 | 1 | -1/+1 |
| | |||||
* | Fix typos in the description of the test | Ivan Ukhov | 2010-11-17 | 1 | -2/+2 |
| | |||||
* | Write a test for checking the presence of table names in the cache | Ivan Ukhov | 2010-11-17 | 1 | -1/+12 |
| | |||||
* | adding proper columns to our fake table | Aaron Patterson | 2010-11-05 | 1 | -2/+2 |
| | |||||
* | adding default limits when there is an offset for sqlite and mysql [#5316 ↵ | Aaron Patterson | 2010-10-20 | 1 | -0/+7 |
| | | | | state:resolved] | ||||
* | renaming test_helper to helper so that it is not double required | Aaron Patterson | 2010-10-18 | 1 | -1/+1 |
| | |||||
* | got rid of retarded check method. down with rspec | Ryan Davis | 2010-10-18 | 1 | -12/+12 |
| | |||||
* | Renamed spec_helper to test_helper | Ryan Davis | 2010-10-18 | 1 | -1/+1 |
| | |||||
* | Fisting arel specs -- still needs tree_manager and cleanup | Ryan Davis | 2010-10-18 | 1 | -0/+175 |