Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Delegate to Connection Visitor in WhereSQL Visitor | Edward Paget | 2015-12-17 | 1 | -0/+21 |
| | | | | | | | | | | | | The WhereSQL visitor always uses the generic ToSQL visitor to create the where clause sql statement. This means that it'll miss database specific statements, such as 'ILIKE' in PostgreSQL. Since the `#where_sql` method is mainly used for ActiveRecord error reporting, this discrepancy could be confusing to users. This patch changes the WhereSQL visitor to use the its connection visitor to generate SQL for each statement in the SelectManager's wheres array. Then lets them be joined together with ' AND '. | ||||
* | Fix visit_Arel_Nodes_FullOuterJoin and visit_Arel_Nodes_RightOuterJoin to ↵ | evgenim | 2015-03-16 | 1 | -0/+30 |
| | | | | make them work with collectors. | ||||
* | Change the interface of `having` to match that of `where` | Sean Griffin | 2015-01-27 | 1 | -5/+5 |
| | | | | | | These two clauses have nearly identical semantics with regards to how they would be constructed as an AST. It doesn't make sense for their interfaces to be separate. | ||||
* | Remove `engine` from `TreeManager` and subclasses | Sean Griffin | 2014-11-29 | 1 | -96/+96 |
| | | | | | | This constructor parameter was unused for everything except the convenience methods `to_sql` and `where_sql`. We can pass the engine into those methods directly. | ||||
* | Remove engine from the constructor arguments `Arel::Table` | Sean Griffin | 2014-11-29 | 1 | -16/+16 |
| | | | | | | | | | | | | | | | It is never used outside of convenience methods which are only used in tests. In practice, it just made constructing tables more complicated on the rails side. This is the minimum possible change to remove the constructor argument, but continue to have the tests passing. I'm not sure if we have a reason to keep `project` and friends, and the solution might actually just be to remove the engine from `SelectManager` and friends. As such I've held off on deleting those methods. We need to figure out what to do with `Table#from`. It's old invocation, which read `table.from(table)` was certainly nonsensical. | ||||
* | Deprecate passing ranges to `#in` and `#not_in` | Sean Griffin | 2014-10-25 | 1 | -4/+2 |
| | | | | | | | The goal of these methods should be to generate in nodes, not handle every possible permutation of more than one value. The `#between` and `#not_between` methods have been extracted, which better represent the semantics of handling ranges in SQL. | ||||
* | Add SelectManager#distinct_on to set/unset Arel::Nodes::DistinctOn quantifier | Max Holder | 2014-08-30 | 1 | -0/+21 |
| | |||||
* | Merge pull request #291 from vipulnsward/rename-test | Rafael Mendonça França | 2014-06-30 | 1 | -52/+53 |
|\ | | | | | Cleanup SelectManager Test | ||||
| * | - Stop passing redundant `:engine => Table.engine` to `Table#new` | Vipul A M | 2014-06-15 | 1 | -51/+52 |
| | | | | | | | | | | | | | | | | - Remove redundant `ast` variable creation - Rename similar join tests name to what they actually test - Move "joins itself" test to "joins" describe instead of defining describe block twice - Move update manager statement tests in logical order - Move `project` tests in logical order | ||||
| * | Rename ambiguous test name to what it actually tests | Vipul A M | 2014-06-15 | 1 | -1/+1 |
| | | |||||
* | | Add test for window + partition + order. | Alexander Staubo | 2014-06-22 | 1 | -0/+11 |
| | | |||||
* | | Windowing support for PARTITION BY clause. | Alexander Staubo | 2014-06-20 | 1 | -0/+30 |
|/ | |||||
* | Add test for non-recursive WITH statement | Jiri Pospisil | 2014-06-12 | 1 | -0/+14 |
| | |||||
* | Merge pull request #272 from jduff/rebased_outer_join | Rafael Mendonça França | 2014-05-19 | 1 | -0/+22 |
|\ | | | | | Add convenience #outer_join | ||||
| * | convenience method for outer_join | Brian Hahn | 2014-05-18 | 1 | -0/+22 |
| | | |||||
* | | Return self from #distinct so it's chainable | Jordan Sexton | 2014-05-17 | 1 | -0/+6 |
|/ | |||||
* | more select manager tests passing | Aaron Patterson | 2014-04-08 | 1 | -1/+2 |
| | |||||
* | removing unused join_sql method | Aaron Patterson | 2014-04-08 | 1 | -12/+5 |
| | |||||
* | remove order_clauses since we do not use it | Aaron Patterson | 2014-04-08 | 1 | -10/+0 |
| | |||||
* | Added right and full outer joins | Stephen Prater & Fire-Dragon-DoL | 2014-03-30 | 1 | -0/+16 |
| | |||||
* | add the casting node to the AST at build time | Aaron Patterson | 2014-03-24 | 1 | -2/+2 |
| | | | | | If we add the casting node to the ast at build time, then we can avoid doing the lookup at visit time. | ||||
* | Remove deprecated Arel::Expression | Rafael Mendonça França | 2014-02-10 | 1 | -12/+0 |
| | |||||
* | Remove deprecated Arel::SqlLiteral | Rafael Mendonça França | 2014-02-10 | 1 | -10/+10 |
| | |||||
* | add bind values to the manager class | Aaron Patterson | 2014-01-14 | 1 | -0/+7 |
| | |||||
* | Merge pull request #234 from aackerman/remove-test-engine-proxy | Rafael Mendonça França | 2014-01-04 | 1 | -68/+8 |
|\ | | | | | Removed EngineProxy in SelectManager tests | ||||
| * | Removed EngineProxy in SelectManager tests | Aaron Ackerman | 2014-01-04 | 1 | -68/+8 |
| | | |||||
* | | Assert that SelectManager#project accepts a raw String | Aaron Ackerman | 2014-01-04 | 1 | -4/+2 |
|/ | |||||
* | Remove deprecated calls from the tests | Rafael Mendonça França | 2013-12-05 | 1 | -6/+6 |
| | |||||
* | explicitly pass the pk to compile_update | Aaron Patterson | 2013-11-16 | 1 | -6/+6 |
| | |||||
* | Remove deprecated calls to `SelectManage#insert` with preference to using ↵ | Vipul A M | 2013-11-10 | 1 | -14/+0 |
| | | | | `compile_insert` | ||||
* | Remove some test warnings | Carlos Antonio da Silva | 2012-11-17 | 1 | -3/+0 |
| | |||||
* | more roflscaling strings in the visitor | Aaron Patterson | 2012-10-12 | 1 | -2/+2 |
| | |||||
* | GH-138: add Arel::SelectManager#projections method | Suraj N. Kurapati | 2012-09-21 | 1 | -0/+8 |
| | |||||
* | Support ANSI SQL2003 window functions. | Alexander Staubo | 2012-02-22 | 1 | -0/+156 |
| | |||||
* | Add SelectManager#distinct to set/unset the Arel::Nodes::Distinct.new quantifier | Jon Leighton | 2011-11-04 | 1 | -0/+13 |
| | |||||
* | Removed trailing space on the test sql string statement. | Joel Bryan Juliano | 2011-10-31 | 1 | -1/+0 |
| | |||||
* | Added a failing test for a non-table alias as rhs relation name | Joel Bryan Juliano | 2011-10-31 | 1 | -0/+18 |
| | |||||
* | Support locking by default and disable it only for SQLite. | Edgars Beigarts | 2011-08-26 | 1 | -1/+1 |
| | |||||
* | Add SelectManager#source method to get the source of the ctx | Jon Leighton | 2011-08-11 | 1 | -0/+8 |
| | |||||
* | Add SelectManager#projections= method to overwrite projections | Jon Leighton | 2011-08-11 | 1 | -0/+9 |
| | |||||
* | Make it the responsibility of the connection to hold on to a visitor for ↵ | Jon Leighton | 2011-08-08 | 1 | -0/+4 |
| | | | | generating SQL, rather than the TreeManager. (There is a related commit coming in Active Record.) | ||||
* | fix depth first visitor to support ascending and descending nodes | Aaron Patterson | 2011-06-29 | 1 | -0/+9 |
| | |||||
* | do not cache sql literal values | Aaron Patterson | 2011-05-17 | 1 | -1/+1 |
| | |||||
* | Add support for ordering on expressions | Arthur Taylor | 2011-04-28 | 1 | -0/+23 |
| | | | | | | | | | | | | | | Conflicts: lib/arel.rb lib/arel/attributes/attribute.rb lib/arel/nodes/infix_operation.rb lib/arel/nodes/named_function.rb Conflicts: lib/arel.rb lib/arel/attributes/attribute.rb | ||||
* | adding Distinct ON node | Aaron Patterson | 2011-04-21 | 1 | -1/+1 |
| | |||||
* | adding a spec to demonstrate subqueries | Aaron Patterson | 2011-04-18 | 1 | -0/+12 |
| | |||||
* | fixing Table tests | Aaron Patterson | 2011-04-18 | 1 | -1/+1 |
| | |||||
* | Fixed deep copy bug in SelectManager clone | Arthur Taylor | 2011-04-19 | 1 | -0/+10 |
| | |||||
* | use TableAlias nodes for aliasing subselects | Aaron Patterson | 2011-03-30 | 1 | -1/+1 |
| | |||||
* | Make SelectManager#as act like node predications | John Mileham | 2011-03-25 | 1 | -2/+18 |
| |