| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is part of a greater refactoring to have the `BindParam` nodes hold
onto their values. We want to generally keep the AST decoupled from what
you're actually doing with those values, but ultimately the usage of
`BindParam` is almost identical to how you'd use `Casted` or `Quoted`.
Forcing consumers of Arel's API to maintain the bind values separately
from the AST makes manipulating the AST essentially impossible, as you
would need to perform a full walk of the AST to determine whether a
given node contains bind parameters, and which value it maps to.
By storing the value on the bind parameter directly, we can collect them
in another AST pass (realistically it'll be part of the same pass that
performs SQL construction for performance reasons). This will
dramatically simplify AST manipulation for Rails or any other consumers
that work with bind params.
As part of this change I've removed the `BindVisitor`, which appears to
be dead code, and had tests break from this change.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Individual commit messages included below ***
* Preliminary support for bitwise operations as infix operators. Tests to follow.
* Added bitwise xor, shift left and shift right operators
* Fixed the BitwiseOr class so it uses the :| operator instead of :&
* All the methods for the bitwise operators in the Arel::Math module now wrap them up in Arel::Nodes::Grouping so the operation becomes isolated like addition and subtraction
* Preliminary set of tests for the new operators
* Updated README with examples of bitwise operations
* Added a new UnaryOperation class which is a riff on the InfixOperation class
* Added tests for UnaryOperation (inspired by InfixOperation tests)
* Added the bitwise not (~) operator as a UnaryOperation
* Added tests for the bitwise not operator
* Added documentation for the bitwise not operator
* Updated gemspec using `rake arel.gemspec`
|
| | |
|
| |
|
|
| |
Expression)
|
| | |
|
| |
|
|
|
|
| |
These two clauses have nearly identical semantics with regards to how
they would be constructed as an AST. It doesn't make sense for their
interfaces to be separate.
|
| |
|
|
|
| |
It is impossible to test equality of things constructing trees with bind
params otherwise.
|
| |
|
|
|
|
| |
This constructor parameter was unused for everything except the
convenience methods `to_sql` and `where_sql`. We can pass the engine
into those methods directly.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is never used outside of convenience methods which are only used in
tests. In practice, it just made constructing tables more complicated on
the rails side. This is the minimum possible change to remove the
constructor argument, but continue to have the tests passing.
I'm not sure if we have a reason to keep `project` and friends, and the
solution might actually just be to remove the engine from
`SelectManager` and friends. As such I've held off on deleting those
methods.
We need to figure out what to do with `Table#from`. It's old invocation,
which read `table.from(table)` was certainly nonsensical.
|
| | |
|
| |
|
|
| |
Fixes https://github.com/rails/rails/issues/16913
|
| | |
|
| |
|
|
| |
- Fix typo: `test_opertaion_ordering` => `test_operation_ordering`
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
If we add the casting node to the ast at build time, then we can avoid
doing the lookup at visit time.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
People are often trying to use ARel nodes inside ActiveRecord, and when
they do so, lots of things can break, because ActiveRecord relies on
Array#uniq and sometimes hash key equality to handle values that end up
in wheres, havings, etc. By implementing equality for all the nodes, we
should hopefully be able to prevent any nodes (even nodes containing
other nodes) from failing an equality check they should otherwise pass,
and alleviate many of these errors.
Fixes #130
|
| |
|
|
|
| |
Eventually #engine should go away, but until that time, this means that
Table and Nodes::TableAlias can be used more interchangeably.
|
| |
|
|
|
|
| |
Also, removed unused ordering.rb file, since it is identical
to the one being created in unary.rb already, and isn't
required anywhere.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
generating SQL, rather than the TreeManager. (There is a related commit coming in Active Record.)
|
| | |
|
| |
|
|
| |
table[:id].count.eq(2)
|
| |
|
|
| |
should support ordering
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
