| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
removed `@current` as it is not used
|
| | |
|
|/ |
|
| |
|
| |
|
|\
| |
| | |
Add Yarn support in new apps using --yarn option
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
`@target_dir` variable was changed to local variable in 8e1714b.
|
|\ \
| | |
| | |
| | |
| | | |
supercaracal/fix-force-ssl-if-session-store-disabled
Fix a force ssl redirection bug that occur when session store disabled.
|
| | | |
|
| |/
|/|
| |
| |
| |
| | |
MiniTest was renamed to Minitest.
Already renamed on https://github.com/rails/rails/pull/13366
But slipped into on https://github.com/rails/rails/pull/18413/files#diff-6bb90a693835b0e92910b796c8b0ef59R27
|
| | |
|
|/ |
|
| |
|
|
|
|
|
|
|
|
|
| |
When making the new command insfrastructure I had missed that
`bin/rails runner some_file.rb some args` would pass the extra
args onto the file in `ARGV`.
Now fixed by allowing the command to take extra args again, and
make sure to remove the file name from `ARGV`.
|
|
|
|
| |
if turbolinks is present in gemfile list
|
|\
| |
| | |
Add missing test for singular resource output in rake routes
|
| |
| |
| |
| |
| |
| |
| |
| | |
- This test was present in https://github.com/rails/rails/pull/27089
but not present on master, may be removed in merge commit?
- There was discussion about moving this to `application/rake_test` so
may be this happened in merge commit.
- https://github.com/rails/rails/pull/27089#discussion_r88731157
|
|/
|
|
| |
Follow up to #27098
|
|\
| |
| |
| | |
Fix incorrect output from rails routes when using singular resources …
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
#26606
Rails routes (even rake routes in previous versions) output showed incorrect routes when an application use resource :controller, implying that edit_controller_path match with controller#show.
The order of the output has changed to correct this. View #26606 for more information.
Added a test case, change unit test in rake to expect the new output.
Since the output of resource :controller is changing, the string spected of the railties/test/application/rake_test.rb test_rails_routes_with_controller_environment had to be modified.
|
|\ \
| | |
| | | |
Use secure source for gems referencing "github" in the generated apps
|
| |/
| |
| |
| |
| |
| |
| | |
- New apps generated on master and latest bundler give warning about
"github" source being insecure.
- Use the same solution used for Rails master in the generated app's
Gemfile to fix this issue.
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reset a new session directly after its creation in
`ActionDispatch::IntegrationTest#open_session`. Reset the session to a clean
state before making it available to the client's test code.
Issue #22742 reports unexpected behavior of integration tests that run multiple
sessions. For example an `ActionDispatch::Flash` instance is shared across
multiple sessions, though a client code will rightfully assume that each new
session has its own flash hash.
The following test failed due to this behavior:
class Issue22742Test < ActionDispatch::IntegrationTest
test 'issue #22742' do
integration_session # initialize first session
a = open_session
b = open_session
refute_same(a.integration_session, b.integration_session)
end
end
Instead of creating a new `ActionDispatch::Integration::Session` instance,
the same instance is shared across all newly opened test sessions. This is
due to the way how new test sessions are created in
`ActionDispatch::IntegrationTest#open_session`. The already existing
`ActionDispatch::IntegrationTest` instance is duplicated with `Object#dup`,
This approach was introduced in commit 15c31c7639b. `Object#dup` copies the
instance variables, but not the objects they reference. Therefore this issue
only occurred when the current test instance had been tapped in such a way that
the instance variable `@integration_session` was initialized before creating the
new test session.
Close #22742
[Tawan Sierek + Sina Sadeghian]
|
|
|
|
|
|
|
|
|
|
|
|
| |
`rails plugin new` with `--full` and `--skip-sprockets` options generates a dummy application that throws `NoMethodError`.
```
% rails plugin new my_engine -S --full --skip-gemspec
% cd my_engine
% bin/rails test
rails aborted!
NoMethodError: undefined method `assets' for #<Rails::Application::Configuration:0x007f83aa1e6100>
```
|
|\
| |
| | |
Add missing `+` around a some literals.
|
| |
| |
| |
| |
| |
| | |
Mainly around `nil`
[ci skip]
|
| | |
|
|\ \
| | |
| | |
| | | |
Add --skip-coffee generating option
|
| | |
| | |
| | |
| | |
| | |
| | | |
Usage
`rails new awesome-project --skip-coffee`
|
| | |
| | |
| | |
| | | |
YAML and ERB were removed at 971d510
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This removes the following warnings.
```ruby
rails/railties/lib/rails/railtie.rb:186: warning: instance variable @rake_tasks not initialized
rails/railties/lib/rails/railtie.rb:186: warning: instance variable @rake_tasks not initialized
rails/railties/lib/rails/railtie.rb:186: warning: instance variable @load_console not initialized
rails/railties/lib/rails/railtie.rb:186: warning: instance variable @rake_tasks not initialized
```
|
| | | |
|
| | | |
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
runner blocks
fixing @generators var initialization
pre initializing variables values
Changing from var init to symbol to instance var get/set
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
meinac/add_missing_types_into_ar_model_generator_usage"
This reverts commit aaf561d26cf9a879ff40190b625155015c6225da, reversing
changes made to 83776676e54b387fc52081ff31cfd7710bae9e03.
Reason: It is not a good idea to connect to the database on generators
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
meinac/add_missing_types_into_ar_model_generator_usage
Dynamically show available sql types [ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | | |
Dynamically list available sql data types based on current database adapter.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
They're just barren on the site and confure more than guide, instead
rely on the built in --help to guide users.
|
| |_|_|/
|/| | |
| | | |
| | | |
| | | |
| | | | |
I'm sorry for causing #24168. I wasn't aware of --no-helper and --no-assets.
So I'm adding them to the help message.
I'm still not sure how to show `--no-test-framework` though.
|
| | | |
| | | |
| | | |
| | | | |
If `sprockets` is not loaded, `Rails.application.config.assets` is not defined.
|
| | | |
| | | |
| | | |
| | | | |
We need to use on_load so that plugins will get the same functionality
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The test framework should not be autoloaded in production mode. Before
this commit, the testing railtie would extend AS::TestCase. This caused
AS::TestCase to be preloaded regardless of the environment in which we
were running.
This commit just moves the code that adds line filtering support in to
the test command where we actually execute the test runner. That allows
us to maintain the line runner feature but only load the minimal amount
of code we need.
|