Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | Update test generators to use ActionDispatch::IntegrationTest | Abdelkader Boudih | 2015-12-15 | 8 | -49/+61 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In Rails 5.1 `ActionController::TestCase` will be moved out of Rails into it's own gem. Please use `ActionDispatch::IntegrationTest` going forward. This changes the generators to use `ActionDispatch::IntegrationTest` and the required URL setup (rather than symbols) for each of the controller actions. Updated fix to #22076. | |||||
| * | | Do not default to any Serializer | Santiago Pastorino | 2015-12-15 | 3 | -8/+2 | |
| |/ | | | | | | | We will wait until 5.1 to make a decision | |||||
* | | Only include action cable meta tags if it is not skipped | Rafael Mendonça França | 2015-12-16 | 1 | -0/+2 | |
| | | ||||||
* | | Needless whitespace | David Heinemeier Hansson | 2015-12-16 | 1 | -2/+0 | |
| | | ||||||
* | | Include the action cable URL meta tag by default | David Heinemeier Hansson | 2015-12-16 | 1 | -1/+3 | |
| | | ||||||
* | | Assume that the cable server is running in-process by default, offer option ↵ | David Heinemeier Hansson | 2015-12-16 | 1 | -0/+3 | |
| | | | | | | | | to change that in config/environments/production.rb | |||||
* | | Fix the engine reference | Rafael Mendonça França | 2015-12-16 | 1 | -1/+1 | |
| | | ||||||
* | | Doh, should have read ff370ee61754b00f864f3ddd0af62be4dfa0de67 | David Heinemeier Hansson | 2015-12-16 | 1 | -1/+1 | |
| | | | | | | | | Indeed we need this to be an engine for the internal assets to work | |||||
* | | Another bad reference to engine instead of railtie | David Heinemeier Hansson | 2015-12-16 | 1 | -1/+1 | |
| | | ||||||
* | | We are using railtie, not engine | David Heinemeier Hansson | 2015-12-16 | 1 | -1/+1 | |
| | | ||||||
* | | Accept a Pathname in Application#config_for | Rafael Mendonça França | 2015-12-15 | 2 | -1/+20 | |
| | | | | | | | | That would make possible to use it with action cable configuration. | |||||
* | | Merge remote-tracking branch 'origin/master' into merge-action-cable | Rafael Mendonça França | 2015-12-15 | 8 | -31/+31 | |
|\| | ||||||
| * | Internal test migrations use the private 'Current' version | Matthew Draper | 2015-12-15 | 4 | -15/+15 | |
| | | | | | | | | | | | | | | | | Apart from specific versioning support, our tests should focus on the behaviour of whatever version they're accompanying, regardless of when they were written. Application code should *not* do this. | |||||
| * | Ensure generated migrations include a version number | Matthew Draper | 2015-12-15 | 3 | -14/+14 | |
| | | ||||||
| * | Update seeds.rb.tt | Paul Clegg | 2015-12-14 | 1 | -2/+2 | |
| | | | | | | | | Rahm Emanuel doesn't deserve to be in Rails. | |||||
* | | Action Cable need to be a engine | Rafael Mendonça França | 2015-12-15 | 1 | -1/+1 | |
| | | | | | | | | Otherwise assets will not work | |||||
* | | Switch from engine to railtie | David Heinemeier Hansson | 2015-12-15 | 1 | -1/+1 | |
| | | ||||||
* | | Add option to skip Action Cable | Rafael Mendonça França | 2015-12-14 | 3 | -2/+10 | |
| | | ||||||
* | | Add action_cable to rails/all and application.rb | Rafael Mendonça França | 2015-12-14 | 2 | -9/+11 | |
|/ | ||||||
* | Revert "Merge pull request #22569 from seuros/remove-test-case" | eileencodes | 2015-12-13 | 9 | -31/+30 | |
| | | | | | | | | | This reverts commit 9712a7a12b7f9e4dcef751ceda8a73c3f4beb11f, reversing changes made to 3e65c3d3886336e9145438cdeacaf4ebec6a48b8. Reverting because this caused test failures and while we have a followup branch there is still one failure that happens randomly and isn't straight forward to fix. | |||||
* | Merge pull request #22569 from seuros/remove-test-case | Eileen M. Uchitelle | 2015-12-13 | 9 | -30/+31 | |
|\ | | | | | Controller generators should be creating IntegrationTest stubs instea… | |||||
| * | Controller generators should be creating IntegrationTest stubs instead of ↵ | Abdelkader Boudih | 2015-12-13 | 9 | -30/+31 | |
| | | | | | | | | ControllerTest | |||||
* | | Merge branch 'rails-rake-proxy' | Kasper Timm Hansen | 2015-12-13 | 3 | -6/+56 | |
|\ \ | ||||||
| * | | Implement Rake proxy for Rails' command line interface. | Dharam Gollapudi | 2015-12-13 | 3 | -1/+57 | |
|/ / | | | | | | | | | | | | | Allows any Rake task to be run through `bin/rails` such as `bin/rails db:migrate`, `bin/rails notes` etc. The Rake tasks are appended to Rails' help output, and blend in as standard commands. | |||||
* | | Merge pull request #22574 from gsamokovarov/scaffold-500 | Kasper Timm Hansen | 2015-12-13 | 3 | -3/+3 | |
|\ \ | | | | | | | Prevent a 500 in the default controller scaffold | |||||
| * | | Prevent a 500 in the default controller scaffold | Genadi Samokovarov | 2015-12-13 | 3 | -3/+3 | |
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If you update a record with no attributes, you'll hit a 500 from a guard in `assign_attributes` raising: ```ruby ArgumentError: When assigning attributes, you must pass a hash as an argument. app/controllers/users_controller.rb:44:in `block in update' app/controllers/users_controller.rb:43:in `update' test/controllers/users_controller_test.rb:37:in `block in <class:UsersControllerTest>' ``` Not a biggie, but may be quite confusing for the folks new to the framework. | |||||
* | | Merge pull request #22573 from gsamokovarov/web-console-3-0 | Kasper Timm Hansen | 2015-12-13 | 2 | -3/+3 | |
|\ \ | | | | | | | Update web-console to 3.0.0 | |||||
| * | | Update web-console to 3.0.0 | Genadi Samokovarov | 2015-12-13 | 2 | -3/+3 | |
| |/ | | | | | | | | | Web Console 3.0.0 is compatible with Rails 5, while the 2.x.x releases aren't. | |||||
* | | Nodoc Rails command. | Kasper Timm Hansen | 2015-12-13 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | The API isn't ready yet, which means we haven't documented it. People can't make their own commands, so there's no reason to show it in generated documentation. | |||||
* | | let config.file_watcher be the way to enable the evented file watcher | Xavier Noria | 2015-12-13 | 4 | -26/+21 | |
|/ | | | | | | | | | | | Before this commit, the sole presence of the Listen constant enabled the evented file watcher (unless listen resorted to the polling backend). This way, applications may depend on listen for other stuff independently of this feature. Also, allows teams with mixed setups to decide at boot time whether the evented watcher should be enabled for each particular instance. | |||||
* | show relative path the rerun snippet of test runner in rails engine | yuuji.yaginuma | 2015-12-10 | 4 | -23/+63 | |
| | | | | | | | | | | | | | Since the absolute path is not required to re-run the test, modified so that unnecessary information is not displayed. ```ruby # before bin/rails test /path/to/blorgh/test/integration/navigation_test.rb:5 # after bin/rails test test/integration/navigation_test.rb:5 ``` | |||||
* | Fixed typo in mysql client parameter | Kent Sibilev | 2015-12-09 | 1 | -1/+1 | |
| | ||||||
* | Remove duplicated assertion from api_app_generator tests | Jorge Bejar | 2015-12-09 | 1 | -2/+0 | |
| | ||||||
* | We don't need to set config.debug_exception_response_format given that :api ↵ | Jorge Bejar | 2015-12-09 | 2 | -10/+0 | |
| | | | | is the default value for only API apps | |||||
* | Make debug_exception_response_format config depends on api_only when is not set | Jorge Bejar | 2015-12-09 | 2 | -2/+37 | |
| | ||||||
* | Add tests for api_only configuration setting | Jorge Bejar | 2015-12-09 | 1 | -0/+15 | |
| | ||||||
* | Adjust comment in development.rb template file for app generator | Jorge Bejar | 2015-12-09 | 1 | -3/+0 | |
| | ||||||
* | Update Changelog with the added response_format option in AD::DebugExceptions | Jorge Bejar | 2015-12-09 | 1 | -0/+9 | |
| | ||||||
* | debug_exception_response_format needs to be writeable in Configuration | Jorge Bejar | 2015-12-09 | 1 | -2/+2 | |
| | ||||||
* | Fix indent in generated Rails API env file | Jorge Bejar | 2015-12-09 | 1 | -6/+6 | |
| | ||||||
* | DebugException initialize with a response_format value | Jorge Bejar | 2015-12-09 | 1 | -1/+1 | |
| | ||||||
* | Add debug_exception_response_format config to configure DebugException | Jorge Bejar | 2015-12-09 | 3 | -30/+43 | |
| | | | | behavior | |||||
* | Do not include web-console in Rails API apps | Jorge Bejar | 2015-12-09 | 1 | -0/+2 | |
| | ||||||
* | Response when error should be formatted properly in Rails API if local request | Jorge Bejar | 2015-12-09 | 1 | -1/+1 | |
| | ||||||
* | Fix #22232: rake test tasks exit status code | Arkadiusz Fal | 2015-12-07 | 2 | -1/+10 | |
| | | | | | | | The exit status code was not set when tests were fired with `rake`. Now, it is being set and it matches behavior of running tests via `rails` command (`rails test`), so no matter if `rake test` or `rails test` command is used the exit code will be set. | |||||
* | Clarify the need to run command twice. | Kasper Timm Hansen | 2015-12-07 | 1 | -2/+2 | |
| | | | | | We had 2 pull requests erronously trying to remove the first command. Add some comments for clarity. | |||||
* | Merge pull request #22508 from ↵ | Santiago Pastorino | 2015-12-07 | 2 | -0/+2 | |
|\ | | | | | | | | | y-yagi/remove_request_forgery_protection_from_rails_api remove `request_forgery_protection` initializer from rails api | |||||
| * | remove `request_forgery_protection` initializer from rails api | yuuji.yaginuma | 2015-12-06 | 2 | -0/+2 | |
| | | | | | | | | | | In rails api, since default is so as not to use the `protect_from_forgery`, `request_forgery_protection` initializer I think that's unnecessary | |||||
* | | Ditch `Commands` namespace for base command. | Kasper Timm Hansen | 2015-12-06 | 4 | -83/+78 | |
| | | | | | | | | | | | | | | Reading `Rails::Commands::Command` feels excessive. Especially if users can subclass command to write their own commands — which I'd like to aim for. Switch to `Rails::Command` before we get too far into things. | |||||
* | | Invert command and commands tasks reference. | Kasper Timm Hansen | 2015-12-06 | 3 | -10/+14 | |
| | | | | | | | | | | | | | | We should first attempt to run commands through Rails command, and then fall back to trying the commands tasks. Because eventually the commands tasks should be their own commands. |