aboutsummaryrefslogtreecommitdiffstats
path: root/railties
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | move CHANGELOG entry to the appropriate file [ci skip]yuuji.yaginuma2016-11-191-6/+0
|/ / / / | | | | | | | | | | | | Follow up to #27098
* | | | Merge pull request #27089 from erickueen/erickueen_fix_26606Rafael Mendonça França2016-11-181-3/+3
|\ \ \ \ | | | | | | | | | | | | | | | Fix incorrect output from rails routes when using singular resources …
| * | | | Fix incorrect output from rails routes when using singular resources issue ↵Erick Reyna2016-11-182-3/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #26606 Rails routes (even rake routes in previous versions) output showed incorrect routes when an application use resource :controller, implying that edit_controller_path match with controller#show. The order of the output has changed to correct this. View #26606 for more information. Added a test case, change unit test in rake to expect the new output. Since the output of resource :controller is changing, the string spected of the railties/test/application/rake_test.rb test_rails_routes_with_controller_environment had to be modified.
* | | | | Merge pull request #27092 from prathamesh-sonpatki/https-source-bundlerRafael França2016-11-181-0/+5
|\ \ \ \ \ | | | | | | | | | | | | Use secure source for gems referencing "github" in the generated apps
| * | | | | Use secure source for gems referencing "github" in the generated appsPrathamesh Sonpatki2016-11-181-0/+5
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - New apps generated on master and latest bundler give warning about "github" source being insecure. - Use the same solution used for Rails master in the generated app's Gemfile to fix this issue.
* / / / / Fix `ActionDispatch::IntegrationTest#open_session`Tawan Sierek2016-11-181-0/+6
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reset a new session directly after its creation in `ActionDispatch::IntegrationTest#open_session`. Reset the session to a clean state before making it available to the client's test code. Issue #22742 reports unexpected behavior of integration tests that run multiple sessions. For example an `ActionDispatch::Flash` instance is shared across multiple sessions, though a client code will rightfully assume that each new session has its own flash hash. The following test failed due to this behavior: class Issue22742Test < ActionDispatch::IntegrationTest test 'issue #22742' do integration_session # initialize first session a = open_session b = open_session refute_same(a.integration_session, b.integration_session) end end Instead of creating a new `ActionDispatch::Integration::Session` instance, the same instance is shared across all newly opened test sessions. This is due to the way how new test sessions are created in `ActionDispatch::IntegrationTest#open_session`. The already existing `ActionDispatch::IntegrationTest` instance is duplicated with `Object#dup`, This approach was introduced in commit 15c31c7639b. `Object#dup` copies the instance variables, but not the objects they reference. Therefore this issue only occurred when the current test instance had been tapped in such a way that the instance variable `@integration_session` was initialized before creating the new test session. Close #22742 [Tawan Sierek + Sina Sadeghian]
* | | | Add `:skip_sprockets` to `Rails::PluginBuilder::PASSTHROUGH_OPTIONS`Tsukuru Tanimichi2016-11-143-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `rails plugin new` with `--full` and `--skip-sprockets` options generates a dummy application that throws `NoMethodError`. ``` % rails plugin new my_engine -S --full --skip-gemspec % cd my_engine % bin/rails test rails aborted! NoMethodError: undefined method `assets' for #<Rails::Application::Configuration:0x007f83aa1e6100> ```
* | | | Merge pull request #26905 from bogdanvlviv/docsAndrew White2016-11-131-2/+2
|\ \ \ \ | | | | | | | | | | Add missing `+` around a some literals.
| * | | | Add missing `+` around a some literals.bogdanvlviv2016-10-271-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Mainly around `nil` [ci skip]
* | | | | Add test for #25248Sean Griffin2016-11-121-0/+10
| | | | |
* | | | | Merge pull request #25248 from bluesh55:features/skip-coffeeSean Griffin2016-11-121-1/+6
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | Add --skip-coffee generating option
| * | | | | Add --skip-coffee generating optionseunghwan oh2016-06-021-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Usage `rails new awesome-project --skip-coffee`
* | | | | | remove unused requireyuuji.yaginuma2016-11-051-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | YAML and ERB were removed at 971d510
* | | | | | Use tr instead of gsubAkira Matsuda2016-11-021-1/+1
| | | | | |
* | | | | | remove warning from railtieyuuji.yaginuma2016-11-021-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This removes the following warnings. ```ruby rails/railties/lib/rails/railtie.rb:186: warning: instance variable @rake_tasks not initialized rails/railties/lib/rails/railtie.rb:186: warning: instance variable @rake_tasks not initialized rails/railties/lib/rails/railtie.rb:186: warning: instance variable @load_console not initialized rails/railties/lib/rails/railtie.rb:186: warning: instance variable @rake_tasks not initialized ```
* | | | | | Make `register_block_for` privateArthur Neves2016-11-011-11/+11
| | | | | |
* | | | | | Don't put db:migrate and db:setup in binfiles if activerecord is excludedBouke van der Bijl2016-11-013-0/+10
| | | | | |
* | | | | | Merge PR #26052Arthur Neves2016-11-011-12/+16
|\ \ \ \ \ \
| * | | | | | Added register_block method to register rake_tasks, generators, console & ↵Rafael Fidelis2016-11-011-12/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | runner blocks fixing @generators var initialization pre initializing variables values Changing from var init to symbol to instance var get/set
* | | | | | | Add more rubocop rules about whitespacesRafael Mendonça França2016-10-2935-88/+88
| | | | | | |
* | | | | | | Revert "Merge pull request #23698 from ↵Rafael Mendonça França2016-10-281-1/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | meinac/add_missing_types_into_ar_model_generator_usage" This reverts commit aaf561d26cf9a879ff40190b625155015c6225da, reversing changes made to 83776676e54b387fc52081ff31cfd7710bae9e03. Reason: It is not a good idea to connect to the database on generators
* | | | | | | Merge pull request #23698 from ↵Arthur Nogueira Neves2016-10-281-11/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | meinac/add_missing_types_into_ar_model_generator_usage Dynamically show available sql types [ci skip]
| * | | | | | | Dynamically show available sql types [ci skip]Mehmet Emin İNAÇ2016-02-161-11/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Dynamically list available sql data types based on current database adapter.
* | | | | | | | Hide commands from API site.Kasper Timm Hansen2016-10-2813-17/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | They're just barren on the site and confure more than guide, instead rely on the built in --help to guide users.
* | | | | | | | Explicitly show --no-helper and --no-assets options in help messageAkira Matsuda2016-10-281-0/+2
| |_|_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I'm sorry for causing #24168. I wasn't aware of --no-helper and --no-assets. So I'm adding them to the help message. I'm still not sure how to show `--no-test-framework` though.
* | | | | | | remove assets config from `new_framework_defaults` if `--skip-sprockets` is trueyuuji.yaginuma2016-10-252-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | If `sprockets` is not loaded, `Rails.application.config.assets` is not defined.
* | | | | | | Use `on_load` to trigger commandline processing codeAaron Patterson2016-10-212-5/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We need to use on_load so that plugins will get the same functionality
* | | | | | | Prevent the test framework from being loaded in production modeAaron Patterson2016-10-213-6/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The test framework should not be autoloaded in production mode. Before this commit, the testing railtie would extend AS::TestCase. This caused AS::TestCase to be preloaded regardless of the environment in which we were running. This commit just moves the code that adds line filtering support in to the test command where we actually execute the test runner. That allows us to maintain the line runner feature but only load the minimal amount of code we need.
* | | | | | | don't create db directory when skip active_recordJosé Gomes Júnior2016-10-212-0/+2
| |_|_|/ / / |/| | | | |
* | | | | | Remove deprecated code in ssl middlewareRafael Mendonça França2016-10-101-2/+2
| | | | | |
* | | | | | Remove deprecated support to :text in renderRafael Mendonça França2016-10-1010-69/+69
| | | | | |
* | | | | | Allow the use of listen's 3.1.x branch.Esteban Santana Santana2016-10-032-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the initial evented monitor feature was written, the latest version of listen was the 3.0.x series. Since then the listen project has moved on to the 3.1.x series. This patch allows the use of the new versions.
* | | | | | remove `mongrel` once againyuuji.yaginuma2016-09-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | `mongrel` was removed in #26408. But have back accidentally in #26414.
* | | | | | use `active_support/testing/autorun` in `bin/test` scriptyuuji.yaginuma2016-09-272-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 29f0fbd5db643b885665e4a14c7de3bf6c0d9c96 has changed that always call `Minitest.autorun` in `active_support/testing/autorun`. Therefore, when used directly `Minitest.run`, tests are performed twice.
* | | | | | Merge pull request #26414 from rails/rails-commandsKasper Timm Hansen2016-09-2638-766/+1005
|\ \ \ \ \ \ | | | | | | | | | | | | | | Initial Rails Commands Infrastructure
| * | | | | | Apply test command changes.Kasper Timm Hansen2016-09-261-1/+3
| | | | | | |
| * | | | | | Fix server command tests.Kasper Timm Hansen2016-09-251-1/+2
| | | | | | |
| * | | | | | Fix dbconsole tests.Kasper Timm Hansen2016-09-252-28/+59
| | | | | | |
| * | | | | | Apply Rafaels review fixes.Kasper Timm Hansen2016-09-253-3/+4
| | | | | | |
| * | | | | | Fix console tests.Kasper Timm Hansen2016-09-253-7/+33
| | | | | | |
| * | | | | | Remove the old command files.Kasper Timm Hansen2016-09-2514-880/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Wash out your old! These adhoc scripts are replaced by the new commands.
| * | | | | | Per Dr. Eileen's orders :)Kasper Timm Hansen2016-09-253-5/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Prescribed some review fixes for myself!
| * | | | | | Simplify auxiliary command files directory finding.Kasper Timm Hansen2016-09-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Still vulnerable to different file structures. We likely want something more robust when we tackle in app commands.
| * | | | | | Run engine commands through command infrastructure.Kasper Timm Hansen2016-09-256-14/+54
| | | | | | |
| * | | | | | Initial command structure.Kasper Timm Hansen2016-09-2525-160/+1176
| | | | | | |
* | | | | | | Merge pull request #26579 from y-yagi/remove_unnecessary_rails_env_settingKasper Timm Hansen2016-09-252-4/+0
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | remove unnecessary `RAILS_ENV` setting
| * | | | | | remove unnecessary `RAILS_ENV` settingyuuji.yaginuma2016-09-222-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `RAILS_ENV` is always set in the initialization process of test runner. https://github.com/rails/rails/blob/9fa07095a35be2d8cb5adcc992b988e73a6d9719/railties/lib/rails/test_unit/minitest_plugin.rb#L74 Therefore, it is not necessary to set in `test_helper`.
* | | | | | | Use autorun when running via Rake.Kasper Timm Hansen2016-09-251-3/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Makes sure we get support for `Minitest.after_run` hooks and don't accidentally run tests twice. Requires overriding minitest `run` to respect the TESTOPTS variable.
* | | | | | | Revise setting of run_with_rails_extension.Kasper Timm Hansen2016-09-252-6/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Rails test runner supports three ways to run tests: directly, via rake, or ruby. When Running with Ruby ala `ruby -Itest test/models/post_test.rb` our test file would be evaluated first, requiring `test_helper` and then `active_support/testing/autorun` that would then require the test file (which it hadn't been before) thus reevaluating it. This caused exceptions if using Active Support's declarative syntax. Fix this by shifting around when we set the how we're run to closer mimick the require order. If we're running with `bin/rails test` the test command file is run first and we then set `run_with_rails_extension`, later we hit `active_support/testing/autorun` and do nothing — because we've been run elsewhere. If we at this point haven't set `run_with_rails_extension` we've been running with `ruby` this whole time and thus we set that. We should always trigger `Minitest.autorun` as it doesn't hurt to call it twice. Consolidate the two methods into a single one that better brings out the intent of why they're there.
* | | | | | | Require `active_support/testing/autorun`.Kasper Timm Hansen2016-09-251-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revise the require in the test command to use `active_support/testing/autorun` and spare us the minitest spec syntax as detailed in 5da4d51. Also move the require to the top of the file for consistency with the rest of Rails' requires across the project.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 14:37:23 +0000