aboutsummaryrefslogtreecommitdiffstats
path: root/railties
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | remove unnecessary `RAILS_ENV` settingyuuji.yaginuma2016-09-222-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `RAILS_ENV` is always set in the initialization process of test runner. https://github.com/rails/rails/blob/9fa07095a35be2d8cb5adcc992b988e73a6d9719/railties/lib/rails/test_unit/minitest_plugin.rb#L74 Therefore, it is not necessary to set in `test_helper`.
* | | | | | | Use autorun when running via Rake.Kasper Timm Hansen2016-09-251-3/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Makes sure we get support for `Minitest.after_run` hooks and don't accidentally run tests twice. Requires overriding minitest `run` to respect the TESTOPTS variable.
* | | | | | | Revise setting of run_with_rails_extension.Kasper Timm Hansen2016-09-252-6/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Rails test runner supports three ways to run tests: directly, via rake, or ruby. When Running with Ruby ala `ruby -Itest test/models/post_test.rb` our test file would be evaluated first, requiring `test_helper` and then `active_support/testing/autorun` that would then require the test file (which it hadn't been before) thus reevaluating it. This caused exceptions if using Active Support's declarative syntax. Fix this by shifting around when we set the how we're run to closer mimick the require order. If we're running with `bin/rails test` the test command file is run first and we then set `run_with_rails_extension`, later we hit `active_support/testing/autorun` and do nothing — because we've been run elsewhere. If we at this point haven't set `run_with_rails_extension` we've been running with `ruby` this whole time and thus we set that. We should always trigger `Minitest.autorun` as it doesn't hurt to call it twice. Consolidate the two methods into a single one that better brings out the intent of why they're there.
* | | | | | | Require `active_support/testing/autorun`.Kasper Timm Hansen2016-09-251-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revise the require in the test command to use `active_support/testing/autorun` and spare us the minitest spec syntax as detailed in 5da4d51. Also move the require to the top of the file for consistency with the rest of Rails' requires across the project.
* | | | | | | Merge pull request #26610 from mechanicles/as-to-active-supportJon Moss2016-09-241-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | AS => Active Support [ci skip]
| * | | | | | | AS => Active Support [ci skip]Santosh Wadghule2016-09-251-1/+1
| |/ / / / / /
* | | | | | | Merge pull request #26515 from grosser/grosser/after_runArthur Nogueira Neves2016-09-233-4/+40
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | support minitest after_run
| * | | | | | switch to autorun to support after_run and patch lessMichael Grosser2016-09-231-3/+1
| | | | | | |
| * | | | | | support minitest after_run for parity to regular minitestMichael Grosser2016-09-163-1/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | see https://github.com/seattlerb/minitest/blob/f9605387e4af7d657921a83aaf0ae364f6d26a57/lib/minitest.rb#L51-L65
| * | | | | | improve test coverageMichael Grosser2016-09-162-4/+18
| | | | | | |
* | | | | | | Merge pull request #26543 from y-yagi/use_rails_command_in_restart_testKasper Timm Hansen2016-09-191-7/+7
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | use rails command in restart task test
| * | | | | | | use rails command in restart task testyuuji.yaginuma2016-09-191-7/+7
| | | | | | | |
* | | | | | | | [ci skip] Fixed commas according to Oxford comma in rdoc and guidesAndrey Molchanov2016-09-172-2/+2
|/ / / / / / /
* / / / / / / improve error message when include assertions failMichael Grosser2016-09-1613-50/+50
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | assert [1, 3].includes?(2) fails with unhelpful "Asserting failed" message assert_includes [1, 3], 2 fails with "Expected [1, 3] to include 2" which makes it easier to debug and more obvious what went wrong
* | | | | | Merge pull request #26469 from y-yagi/remove_useless_optionRafael França2016-09-141-5/+0
|\ \ \ \ \ \ | | | | | | | | | | | | | | remove useless `gemfile` option
| * | | | | | remove useless `gemfile` optionyuuji.yaginuma2016-09-121-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rails application for test creates with `--skip-gemfile` option. https://github.com/rails/rails/blob/master/railties/test/isolation/abstract_unit.rb#L333 Therefore, regardless of the option, Gemfile is not created.
* | | | | | | Merge pull request #26487 from prathamesh-sonpatki/move-preload-section-upRichard Schneeman2016-09-141-7/+8
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Move comment about disconnecting pool close to comment about preload
| * | | | | | | Move comment about disconnecting pool close to comment about preloadPrathamesh Sonpatki2016-09-141-7/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - These two comments are connected to each other so kept them back to back.
* | | | | | | | fix broken generators testyuuji.yaginuma2016-09-142-2/+2
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | Follow up to 92703a9ea5d8b96f30e0b706b801c9185ef14f0e
* | | | | | | Do not point to the 5-0-stable branchRafael Mendonça França2016-09-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Master based applications should be pointing to master
* | | | | | | Merge pull request #26314 from frodsan/puma-ar-disconnectRichard Schneeman2016-09-131-0/+8
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Disconnects all connections in the pool before forking.
| * | | | | | | Disconnects all connections in the pool before forking.Francesco Rodriguez2016-08-291-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See discussion in https://github.com/puma/puma/issues/1001
* | | | | | | | [ci skip] Update Levenshtein code with better attribution.Kasper Timm Hansen2016-09-121-1/+3
| |/ / / / / / |/| | | | | | | | | | | | | | | | | | | | Lacks some proper creds to the homies who went the... distance ;)
* | | | | | | use correct Gemfile in `bin/setup` testyuuji.yaginuma2016-09-111-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, `bin/setup` test uses Gemfile of Rails. But this Gemfile is not a file to be used in Rails application. Add a Gemfile to Rails application that is created for test, it has been modified to use the Gemfile.
* | | | | | | Remove the word "mongrel" from documentsRyunosuke Sato2016-09-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently mongrel is not maintained. And it couldn't be built with any Ruby versions that supported by Rails. It is reasonable to remove the word "mongrel" in order to avoid confusion from newcomer.
* | | | | | | Fix Remaining Case-In-Assignment Statement FormattingAlex Kitchens2016-09-061-7/+8
| |_|_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Recently, the Rails team made an effort to keep the source code consistent, using Ruboco (bb1ecdcc677bf6e68e0252505509c089619b5b90 and below). Some of the case statements were missed. This changes the case statements' formatting and is consistent with changes in 810dff7c9fa9b2a38eb1560ce0378d760529ee6b and db63406cb007ab3756d2a96d2e0b5d4e777f8231.
* | | | | | Allow download of email attachments in the Mailer Preview template.jpd8002016-09-021-1/+4
| | | | | |
* | | | | | fixes remaining RuboCop issues [Vipul A M, Xavier Noria]Xavier Noria2016-09-013-11/+11
| | | | | |
* | | | | | Fix styleschneems2016-08-301-26/+26
| | | | | |
* | | | | | Address comment via @dhh, better option namingschneems2016-08-301-4/+4
| | | | | |
* | | | | | Set unknown_asset_fallback false only new appsschneems2016-08-291-1/+1
| | | | | |
* | | | | | Move default to different initializerschneems2016-08-292-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Is this usage correct? cc/ @prathamesh-sonpatki
* | | | | | Thanks rubocopschneems2016-08-291-1/+1
| | | | | |
* | | | | | Fix initializerschneems2016-08-291-1/+1
| | | | | |
* | | | | | Default assets.unknown_asset_fallback to falseschneems2016-08-291-0/+4
| | | | | |
* | | | | | Favor `public_folder: true` over `public_*`schneems2016-08-291-25/+44
| | | | | | | | | | | | | | | | | | | | | | | | Adding all those `public_*` methods is a bit heavy handed, we can change the API to instead use `public_folder: true`. Change was pretty easy since it was already implemented that way.
* | | | | | Fix formattingschneems2016-08-291-3/+3
| | | | | |
* | | | | | Add `public_*` helpers to all the `_tag` methods.schneems2016-08-291-9/+15
| | | | | |
* | | | | | Test `public_` methods.schneems2016-08-291-0/+72
|/ / / / /
* | | | | Merge pull request #26224 from jonatack/consistent-asset-precompile-examplesEileen M. Uchitelle2016-08-191-2/+3
|\ \ \ \ \ | | | | | | | | | | | | Consistent examples and template for assets#precompile
| * | | | | Consistent examples and template for assets#precompileJon Atack2016-08-191-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Listening to a few developers today discussing their troubles in understanding how to use the asset pipeline, it turns out that the precompile examples in the guides and assets.rb template have over time become a bit inconsistent. This PR makes the examples consistent in code style, spacing, and asset names, removes the old 'swfObject.js' example, and in a couple of places wraps lines at 80 characters including in the assets.rb template. Re-add spaces inside array parentheses.
* | | | | | run `before_configuration` callbacks as soon as application constant ↵yuuji.yaginuma2016-08-193-2/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | inherits from Rails::Application Until Rails 4.1, `before_configuration` run as soon as the application constant inherits from `Rails::Application`. However, in d25fe31c40928712b5e08fe0afb567c3bc88eddf, it has been modified to run at instantiation process. This modify to `before_configuration` is run at same timing as to Rails 4.1. Fixes #19880
* | | | | | refactor `CommandsTasks`yuuji.yaginuma2016-08-174-164/+132
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Extract a common method of `Rails::CommandsTasks` and `Rails::Engine::CommandsTasks` to the module.
* | | | | | Merge pull request #26157 from ↵Rafael França2016-08-162-0/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | y-yagi/remove_test_mailers_when_skipping_action-mailer remove "test/mailers" directory when skipping action-mailer
| * | | | | | remove "test/mailers" directory when skipping action-maileryuuji.yaginuma2016-08-142-0/+2
| |/ / / / / | | | | | | | | | | | | | | | | | | Related to #26146
* | | | | | Merge pull request #26130 from yui-knk/drop_tableRafael França2016-08-161-1/+3
|\ \ \ \ \ \ | | | | | | | | | | | | | | Drop a temporary table before end of a test case
| * | | | | | Drop a temporary table before end of a test caseyui-knk2016-08-141-1/+3
| | | | | | |
* | | | | | | Add three new rubocop rulesRafael Mendonça França2016-08-1637-108/+108
| |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
* | | | | | Ensure app/mailers is removed when skipping action-mailerBrian Cardarella2016-08-122-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | Closes #26145
* | | | | | Make cache max-age durations self-explanatoryNathan Long2016-08-122-2/+2
|/ / / / /
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-16 12:46:31 +0000