| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
|
|\ \
| | |
| | |
| | |
| | | |
y-yagi/allow_to_receive_arbitrary_arguments_in_aggregated_results
Allow to receive arbitrary arguments in `aggregated_results`
|
| |/
| |
| |
| |
| | |
Argument was added to `aggregated_results` in minitest 5.10.2.
Ref: https://github.com/seattlerb/minitest/commit/c6ba2afd90473b76d289562edd24f7d7ca8484f9
|
|\ \
| |/
|/| |
Allow capybara minor releases
|
| |
| |
| |
| |
| |
| | |
Capybara 2.14.0 was released. Loosen the tight constraint in the
generated Gemfile, so that Rails applications can take advantage of the
new version
|
|/ |
|
|
|
|
|
| |
Since `package.json` is created in root directory, it is appropriate to
create it in `create_root_files`.
|
|\
| |
| | |
CLI arg `--port` has precedence over env `PORT`
|
| | |
|
|\ \
| | |
| | | |
Friendly maintain schema error in test runner
|
| |/ |
|
|/
|
|
|
| |
The `package.json` is created only if `skip_yarn` is not specified.
https://github.com/rails/rails/blob/a4c1282854795d1f0d7696ce1ccbabf94b3d9098/railties/lib/rails/generators/rails/app/app_generator.rb#L202..L204
|
|
|
|
|
|
| |
* Remove trailing spaces.
* Add backticks around method and command.
* Fix indentation.
|
|
|
|
| |
Fix #28905
|
|\
| |
| | |
Added a shared section to config/database.yml that will be loaded for all envs
|
| |
| |
| |
| | |
environments
|
|\ \
| | |
| | | |
Do not try to encoding the parameters when the controller is not defined
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When you have a route that points to an nonexistent controller we raise
an exception.
This exception was being caught by the DebugExceptions middleware in
development, but when trying to render the error page, we are reading
the request format[[1][]]. To determine the request format we are reading
the format parameters[[2][]], and to be able to read the parameters we need
to encode them[[3][]]. This was raising another exception that to encode the
parameter we try to load the controller to determine if we need to
encode the parameters are binary[[4][]]. This new exception inside the
DebugExceptions middleware makes Rails to render a generic error page.
To avoid this new exception now we only encode the parameters when the
controller can be loaded.
Fixes #28892
[1]: https://github.com/rails/rails/blob/f52cdaac6336f99d13622ff9bda556a3124a4121/actionpack/lib/action_dispatch/middleware/debug_exceptions.rb#L80
[2]: https://github.com/rails/rails/blob/f52cdaac6336f99d13622ff9bda556a3124a4121/actionpack/lib/action_dispatch/http/mime_negotiation.rb#L63
[3]: https://github.com/rails/rails/blob/f52cdaac6336f99d13622ff9bda556a3124a4121/actionpack/lib/action_dispatch/http/parameters.rb#L58
[4]: https://github.com/rails/rails/blob/f52cdaac6336f99d13622ff9bda556a3124a4121/actionpack/lib/action_dispatch/http/parameters.rb#L88
|
|\ \
| |/
|/| |
Pass request params to ActionMailer::Preview
|
| | |
|
|\ \
| | |
| | | |
Ensure bin/yarn matches the one generated by webpacker
|
| | |
| | |
| | |
| | |
| | |
| | | |
Import from https://github.com/rails/webpacker/pull/277.
Fixes https://github.com/rails/webpacker/issues/278
|
|\ \ \
| | | |
| | | | |
`respond_to_missing?` should be private
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Follow up of 03d3f036.
Some of `respond_to?` were replaced to `respond_to_missing?` in 03d3f036.
But the visibility is still public. It should be private.
|
| |/ /
|/| |
| | |
| | | |
\Z was a mistake of \z. Replace \Z to \z to prevent newly \Z added.
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| | |
specified
Without this check, even if config is not specified, `ActionView::Helpers::FormHelper.form_with_generates_remote_forms`
always be set to nil and remote form not be generated.
Follow up to 128b804c6ce40fcbde744f294f8cb98654f6efec
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This configuration is not present in ActionView::Base so we can't let
the action_view.set_configs initializer set it.
Also add tests to make sure this config works.
Fixes #28824
|
| |
| |
| |
| | |
The css selectors on the generated error pages are too broad (for example `text-align: center` on `body` and thus bleed out to the following pages (say, by pressing the back button) when using Turbolinks. This commit namespaces all the selectors.
|
|\ \
| | |
| | | |
Don't generate system test files if `skip_system_test` option is specified
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
Raise error on the movement of migrations
when the current migration does not exist.
|
| | | |
|
|\ \ \
| | | |
| | | | |
Smooth form with upgrading
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Allows users to not have remote forms by default, since there's
more JS harness, e.g. bundling rails-ujs, otherwise.
Also don't skip creating defaults file anymore. Sprockets isn't the only new config.
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Currently, `read_encrypted_secrets` is set with initializer.
Therefore if refer to `secrets` in config, `read_encrypted_secrets` is false,
so can not get the value of `secrets.yml.enc`.
In order to be able to refer to secrets in config, modified to refer to
`config.read_encrypted_secrets` when calling `secrets`.
Fixes #28618.
|
| | |
| | |
| | |
| | |
| | | |
If it is not added to `TEST_TYPES`, it is not regarded as a test
when counting the total count.
|
|/ / |
|
| | |
|
| | |
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Use appropriate type to `header` option
|
| | |
| | |
| | |
| | |
| | | |
The `header` option checks only whether it is specified or not.
https://github.com/rails/rails/blob/e8c33349bfabca28996ac74d344d69c7aaffec50/railties/lib/rails/commands/dbconsole/dbconsole_command.rb#L52
|
|\ \ \
| | | |
| | | | |
Update backtrace cleaner to use `Regexp#match?`
|
| | | | |
|
|\ \ \ \
| |_|/ /
|/| | | |
Clear active connections after initialization
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Any connections that were checked out during initialization should be
checked back in before the first request is processed, for two reasons:
- Returning the connection to the pool allows it to be health checked
before it's used again. If the connection dies before the first
request arrives, the health check will replace it with a new one.
- If the thread that initialized Rails is not the same thread that will
be performing work, checking in the connection will allow it to be
reused instead of being stuck to the initialization thread forever.
|
|\ \ \ \
| | | | |
| | | | | |
Raise when using a bad symlink
|