aboutsummaryrefslogtreecommitdiffstats
path: root/railties
Commit message (Collapse)AuthorAgeFilesLines
...
| * | Fix test to try `spec/` directory as opposed to `app/spec` which I hadJohn Meehan2016-07-051-2/+2
| | | | | | | | | | | | | | | | | | accidently set it to. Made the change and test still passes.
| * | removed extra blank lineJohn Meehan2016-07-051-1/+0
| | |
| * | Allow rake notes to work with other directories.John Meehan2016-07-052-0/+19
| |/ | | | | | | | | | | | | Additional directories can be added using SourceAnnotationExtractor::Annotation.register_directories("spec", "other_dir") Result: rake notes will now extract notes from these directories.
* | Merge pull request #25257 from ta1kt0me/inspect_initializersRichard Schneeman2016-07-053-1/+10
|\ \ | | | | | | Display railtie class name in `rails initializers`
| * | Initializer provides its context class nameta1kt0me2016-06-123-3/+10
| | |
| * | Delegate public method for raitile nameta1kt0me2016-06-112-1/+3
| | |
| * | Display railtie class name in `rails initializers`ta1kt0me2016-06-021-1/+1
| | |
* | | Point to the correct documentation [ci skip]Benjamin Quorning2016-07-051-1/+1
| | | | | | | | | | | | | | | | | | | | | The options used in this file are *not* directly described in the Rails 5.0 release notes (http://edgeguides.rubyonrails.org/5_0_release_notes.html), but instead in section 2 of the Guide for Upgrading Ruby on Rails document (http://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html).
* | | Robots.txt removed disallow all instructionsSam Sweeney2016-07-051-4/+0
| |/ |/|
* | Merge pull request #25646 from y-yagi/refer_to_rails_command_instead_of_rakeVipul A M2016-07-021-3/+3
|\ \ | | | | | | refer to rails command instead of rake in doc of `SourceAnnotationExtractor`
| * | refer to rails command instead of rake in doc of `SourceAnnotationExtractor` ↵yuuji.yaginuma2016-07-021-3/+3
| | | | | | | | | | | | [ci skip]
* | | Merge pull request #25222 from vipulnsward/25219-fix-logsMatthew Draper2016-07-023-9/+29
|\ \ \ | |/ / |/| | Clean backtrace in IRB
| * | - Added test for verifying that we treat line number indications from irb as ↵Vipul A M2016-07-011-8/+16
| | | | | | | | | | | | | | | | | | user/lib code - Cleaned up backtrace cleaner test code and removed instaces variables
| * | Fixes #25219Vipul A M2016-07-012-1/+13
| | | | | | | | | | | | Add handling of cleaning up backtrace from IRB console in case of errors
* | | fix task name to removeyuuji.yaginuma2016-07-021-1/+1
| | | | | | | | | | | | Follow up to #25431
* | | Do not run `bundle install` when generating a new plugin.Rafael Mendonça França2016-07-016-103/+112
|/ / | | | | | | | | | | Since bundler 1.12.0, the gemspec is validated so the `bundle install` command will fail just after the gem is created causing confusion to the users. This change was a bug fix to correctly validate gemspecs.
* | Merge pull request #25431 from ↵Rafael França2016-06-302-1/+10
|\ \ | | | | | | | | | | | | prathamesh-sonpatki/add-note-about-upgrade-guide-at-the-end-of-update Display link to Rails upgrade guide at the end of `rails app:update` task.
| * | Display link to Rails upgrade guide at the end of `rails app:update` task.Prathamesh Sonpatki2016-06-302-1/+10
| | | | | | | | | | | | | | | - This will nudge people in the direction of going through upgrade guides.
* | | Use sass-rails in our test suiteRafael Mendonça França2016-06-301-1/+1
| | |
* | | Merge pull request #25607 from sstephenson/turbolinks-5-finalRafael Mendonça França2016-06-301-1/+1
|\ \ \ | | | | | | | | | | | | Update to Turbolinks 5.0.0 final
| * | | Update to Turbolinks 5.0.0 finalSam Stephenson2016-06-301-1/+1
| |/ /
* / / Point to released coffee-railsRafael Mendonça França2016-06-301-1/+1
|/ /
* | Update changelog for #25351Kevin McPhillips2016-06-221-0/+5
| |
* | Initialize the configuration with a valueRafael Mendonça França2016-06-224-10/+2
| | | | | | | | | | | | | | This will fix the failures fixed by 41488adbb89a09fa96188486f8414842ff28c848 and keep this new option that is semi-private outside of the generated configurations
* | Fix failing railties testseileencodes2016-06-223-0/+9
| | | | | | | | | | Railties tests didn't know about the new config option added in 80b416f so it needed to be added to the railties generators for configs.
* | Add option to enable dependency loading in productionRafael Mendonça França2016-06-221-1/+1
| | | | | | | | | | | | | | | | This will make easier to applications that rely on having const_missing hooks in production upgrade to Rails 5. This option is going to be remove in the future and the default behavior will be to disable the dependency loading.
* | Fix rails/info routes for apps with globbing routeNicholas Firth-McCoy2016-06-203-1/+27
| | | | | | | | | | | | | | | | The /rails/info routes were inaccessible in apps with a catch-all globbing route, as they were being appended after the globbing route and would never be matched. See also ccc3ddb7762bae0df7e2f8d643b19b6a4769d5be.
* | No need to have conditional based on api options in assetsPrathamesh Sonpatki2016-06-201-2/+0
| | | | | | | | | | | | - As assets are removed for API only apps anyways, so we don't need any conditional upfront. - assets are removed for API apps here - https://github.com/rails/rails/blob/94ef224aa61ace3fa643eab161ff9056b7d90a62/railties/lib/rails/generators/rails/app/app_generator.rb#L266-L273.
* | Fix failing railties testsPrathamesh Sonpatki2016-06-181-2/+2
| | | | | | | | | | | | | | | | | | | | - Railties tests related to fetching asset URL started failing after the release of sprockets 3.6.1 on Travis. - This was due to the change in https://github.com/rails/sprockets/pull/311/files which changed the logic in `concat_javascript_sources` to add `;` at the end of file if the source did not end with semicolon. - Bumped up sprockets minor version and fixed the failing tests.
* | Move quiet option to development.rbRafael Mendonça França2016-06-162-3/+3
| | | | | | | | | | This option is used in a initializer hook that runs before the config/initializers files so it will not work if it is set there.
* | Merge pull request #25390 from gsamokovarov/abstact-unit-presence-requireRafael França2016-06-131-0/+1
|\ \ | | | | | | Require "active_support/core_ext/object/blank" for railties abstract unit
| * | Require "active_support/core_ext/object/blank" for railties abstract unitGenadi Samokovarov2016-06-131-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | In #25380 I moved an `active_support/core_ext/object/blank` in the `activesupport/lib/active_support/testing/assertions.rb`, however it caused a chain reaction, resulting in failing railties tests. Moving the require to `railties/test/isolation/abstract_unit.rb` and `activesupport/test/abstract_unit.rb`.
* | | Merge pull request #25319 from morgoth/generate-application-record-firstRafael França2016-06-134-18/+18
|\ \ \ | |/ / |/| | Generate application_record.rb file before model file
| * | Generate application_record.rb file before model fileWojciech Wnętrzak2016-06-084-18/+18
| | | | | | | | | | | | | | | | | | Previously model file was generated first, which resulted in inheriting from `ActiveRecord::Base`, but since application_record.rb is generated as well, it should already be used.
* | | Merge pull request #25004 from ↵Eileen M. Uchitelle2016-06-125-0/+44
|\ \ \ | | | | | | | | | | | | | | | | y-yagi/generate_mailer_layout_files_if_it_does_not_already_exist generate mailer layout files if it does not already exist
| * | | generate mailer layout files if it does not already existyuuji.yaginuma2016-05-155-0/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, if `ApplicationMailer` does not exist, it is generated when run the mailer generator, but layouts files does not generate. However, because it uses the layouts in `ApplicationMailer`, layouts are required. Follow up to #24161
* | | | Add config.assets.quiet = true as default valueKevin McPhillips2016-06-101-0/+3
| | | |
* | | | Prevent `{ internal: true }` from being stored in the routerJon Moss2016-06-071-0/+6
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Forgotten followup to #23669 :grimacing: If you went to an internal route (e.g. `/rails/info/routes`), you would previously see the following in your logger: ```bash Processing by Rails::InfoController#routes as HTML Parameters: {"internal"=>true} Rendering /Users/jon/code/rails/rails/railties/lib/rails/templates/rails/info/routes.html.erb within layouts/application Rendered collection of /Users/jon/code/rails/rails/actionpack/lib/action_dispatch/middleware/templates/routes/_route.html.erb [2 times] (10.5ms) Rendered /Users/jon/code/rails/rails/actionpack/lib/action_dispatch/middleware/templates/routes/_table.html.erb (2.5ms) Rendered /Users/jon/code/rails/rails/railties/lib/rails/templates/rails/info/routes.html.erb within layouts/application (23.5ms) Completed 200 OK in 50ms (Views: 35.1ms | ActiveRecord: 0.0ms) ``` Now, with this change, you would see: ```bash Processing by Rails::InfoController#routes as HTML Rendering /Users/jon/code/rails/rails/railties/lib/rails/templates/rails/info/routes.html.erb within layouts/application Rendered collection of /Users/jon/code/rails/rails/actionpack/lib/action_dispatch/middleware/templates/routes/_route.html.erb [2 times] (1.6ms) Rendered /Users/jon/code/rails/rails/actionpack/lib/action_dispatch/middleware/templates/routes/_table.html.erb (10.2ms) Rendered /Users/jon/code/rails/rails/railties/lib/rails/templates/rails/info/routes.html.erb within layouts/application (17.4ms) Completed 200 OK in 44ms (Views: 28.0ms | ActiveRecord: 0.0ms) ```
* | | Merge pull request #25317 from prathamesh-sonpatki/fix-api-controller-testsKasper Timm Hansen2016-06-072-7/+7
|\ \ \ | | | | | | | | Fix API controller tests by assigning them the encoding type
| * | | Fix API controller tests by assigning them the encoding typePrathamesh Sonpatki2016-06-072-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | - Fixes #25183. - The `as: :json` feature was added in https://github.com/rails/rails/pull/21671 and recommended to use for JSON endpoints so let's use it by default for API controller tests.
* | | | Merge pull request #25247 from y-yagi/reference_actual_classKasper Timm Hansen2016-06-071-1/+1
|\ \ \ \ | | | | | | | | | | reference actual class to use middleware
| * | | | reference actual class to use middlewareyuuji.yaginuma2016-06-021-1/+1
| | |_|/ | |/| | | | | | | | | | Using strings for middleware class names is deprecated in 83b767cef90abfc4c2ee9f4b451b0215501fae9a.
* | | | Flag `to_time` + simplify version names.Kasper Timm Hansen2016-06-071-5/+6
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | Since Ruby 2.4 isn't out yet, the fact that it will make `to_time` preserve the time zone should be toggled with a update flag. Second, remove the flipping on what version had what defaults. It's called new framework defaults, so it's from the future looking. Thus keep the line that mentions past versions.
* | | Use the `update` flag to provide more friendlier messages to people upgrading.Prathamesh Sonpatki2016-06-071-12/+9
| | |
* | | Remove FORCE option as it was only needed for testsPrathamesh Sonpatki2016-06-072-2/+4
| | | | | | | | | | | | - Adjusted tests instead.
* | | Update the documentation of new_framework_defaults file with more details ↵Prathamesh Sonpatki2016-06-041-13/+16
| | | | | | | | | | | | | | | | | | about old apps and how you can upgrade to new defaults. [Kasper Timm Hansen, Prathamesh Sonpatki]
* | | Fix minor regression about old apps not getting per_form_csrf and ↵Prathamesh Sonpatki2016-06-044-25/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | request_forgery_protection configs - Earlier per_form_csrf_tokens and request_forgery_protection config files were generated for old apps upgraded to Rails 5. - But when we collapsed all initializers into one file, the entire file does not get created for old apps. - This commit fixes it and also changes values for all new defaults for old apps so that they will not break. - Also added a test for `rails app:update`.
* | | More cleanup of new framework defaultsPrathamesh Sonpatki2016-06-041-18/+12
| | | | | | | | | | | | | | | | | | | | | - Move real new default options to the top of the file. - After that club together all the options which were added to keep backward compatibility. So all of them will get only one header. - Based on https://github.com/rails/rails/pull/25231#issuecomment-222945173.
* | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2016-06-031-1/+1
|\ \ \ | | | | | | | | | | | | | | | | Conflicts: guides/source/action_cable_overview.md
| * | | `behaviour` --> `behavior`Jon Moss2016-05-271-1/+1
| | |/ | |/| | | | | | | http://edgeguides.rubyonrails.org/api_documentation_guidelines.html#english
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-18 06:26:19 +0000