| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit ae68fc3864e99ab43c18fd12577744e1583f6b64, reversing
changes made to 0262a18c7b0ab6f60fee842b3007388f9ffeb0fa.
See here: https://github.com/rails/rails/pull/8499#issuecomment-11356417
|
| |
| |
| |
| |
| | |
Remove all the old url helper methods when clear! is called on the
route set because it's possible that some routes have been removed.
|
| |
| |
| |
| |
| | |
Related to the HTML route inspector changes:
ae68fc3864e99ab43c18fd12577744e1583f6b64
|
|\ \
| | |
| | | |
Output routes in :html format
|
| | |
| | |
| | |
| | |
| | |
| | | |
By formatting routes for different media (txt/html) we can apply optimizations based on the format. We can include meta-data in the HTML to allow a rich experience while rendering and viewing the routes. This PR shows route helpers as they are used with the `_path` extension, it also has a javascript toggle on the top to switch to `_url`. This way the developer can see the exact named route helper they can use instead of having to modify a base.
This is one example of an optimization that could be applied. Eventually we can link out to guides for the different columns to better explain what helper, HTTP Verb, Path, and Controller#action indicate. We could even add a route search box that could allow developers to input a given route and see all of the routes that match it. These are stand alone features and should be delivered separately.
|
|\ \ \
| | | |
| | | | |
Don't include debugger gem if jruby is used since it doesn't work on jruby. [ci skip]
|
| |/ / |
|
|/ / |
|
| |
| |
| |
| |
| |
| |
| |
| | |
The old, static welcome page instructed developers to delete the
public/index.html file and set a root route. The new, dynamic welcome
page should tell developers (a) why they're seeing it when it doesn't
correspond to anything in the viewable app source and (b) that it can
be superseded with a root route.
|
|\ \
| | |
| | | |
Use Rails to Render Default Index Page
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is an alternative implementation to #7771 thanks to the advice of @spastorino
Rails is a dynamic framework that serves a static index.html by default. One of my first questions ever on IRC was solved by simply deleting my public/index.html file. This file is a source of confusion when starting as it over-rides any set "root" in the routes yet it itself is not listed in the routes. By making the page dynamic by default we can eliminate this confusion.
This PR moves the static index page to an internal controller/route/view similar to `rails/info`. When someone starts a rails server, if no root is defined, this route will take over and the "dynamic" index page from rails/welcome_controller will be rendered. These routes are only added in development. If a developer defines a root in their routes, it automatically takes precedence over this route and will be rendered, with no deleting of files required.
In addition to removing this source of confusion for new devs, we can now use Rails view helpers to build and render this page. While not the primary intent, the added value of "dogfooding" should not be under-estimated.
The prior PR #7771 had push-back since it introduced developer facing files. This PR solves all of the same problems, but does not have any new developer facing files (it actually removes one).
cc/ @wsouto, @dickeyxxx, @tyre, @ryanb, @josevalim, @maxim, @subdigital, @steveklabnik
ATP Railties and Actionpack.
|
| | |
| | |
| | |
| | | |
attributes
|
|\ \ \ |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
database
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
fixtures
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
generator
|
| | | |
| | | |
| | | |
| | | | |
This is a test for 978c568a7bffe354180aaefa471092182fed1015
|
|\ \ \ \
| |_|/ /
|/| | | |
Use `File.expand_path` instead of `File.join`
|
| | | |
| | | |
| | | | |
cc/ @carlosantoniodasilva
|
| |/ /
|/| |
| | |
| | |
| | |
| | | |
Obviated by rubygems/rubygems@486ed83cc8e706069213c5d406122f4cfcca9e7f
This reverts commit bb8923dee093b615615cdfb83b34d1b0bb254f25.
|
| | |
| | |
| | |
| | | |
All our generated code follow this rule
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
As of 2a68f68aead9fd65ecac8062ca8efc15f5bab418:
- Unit tests are now in test/models, instead of test/units
- Functional tests are now in test/controllers, instead of
test/functional
- Helper tests are now in test/helpers, instead of test/units/helpers
- Mailer tests are now in test/mailers, instead of test/functional
Update the rake task for code statistics (`rake stats`) so that it
recognizes files in the above locations as tests, and accurately
calculates statistics such as "Test LOC" and "Code to Test Ratio."
Safely handle Rails apps that still have tests in the old locations.
|
| | |
| | |
| | |
| | |
| | |
| | | |
RG2 packager expects each spec.files path to be a file and bombs when it tries to tarball a dir.
May revert if rubygems/rubygems#413 is accepted.
|
| |/
|/|
| |
| |
| | |
Otherwise it was matching "end" lines from blocks within the method body,
making tests such as the migration ones fail.
|
| | |
|
|\ \
| | |
| | | |
Fix #assert_instance_method to also assert indented methods
|
| | | |
|
|\ \ \
| | | |
| | | | |
Use attr_accessor for Rails.{application,cache,logger}
|
| | | | |
|
| | | | |
|
| |/ /
|/| |
| | |
| | |
| | |
| | | |
As [Security Guide](http://edgeguides.rubyonrails.org/security.html#whitelists-versus-blacklists)
says, it's better to use `before_filter only: []` instead of `except: []`
so we don't forget to turn the filter off for newly added actions.
|
| | |
| | |
| | |
| | | |
callbacks
|
| | |
| | |
| | |
| | | |
This reverts commit c59734f756b79c39486c45273d2cc5d42cd0c864.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Before:
Finished tests in 56.245787s, 0.2133 tests/s, 0.0000 assertions/s.
12 tests, 0 assertions, 0 failures, 0 errors, 0 skips
After:
Finished tests in 42.401416s, 0.2830 tests/s, 0.0000 assertions/s.
12 tests, 0 assertions, 0 failures, 0 errors, 0 skips
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit inverts the precedence in ActionDispatch::Static so that
dynamic content will be served before static content. This is so that
precompiled assets do not inadvertently get included when running in
development mode - it should have no effect in production where static
files are usually handled by the web server.
Closes #6421
|
| |/
|/|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This cleanup aims to fix a build failure:
https://travis-ci.org/rails/rails/jobs/3515951/#L482
Since travis always have both ENV vars set to "test", a test is failing
where it's expected to output the default env "development", but "test"
is the result due to RACK_ENV being set when we expect it to not be.
By cleaning this duplication we ensure that changing any of these env
variables will pick the right expected value.
|
| | |
|
| |
| |
| |
| | |
[ci skip]
|
| | |
|
|\ \ |
|
| | | |
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Sometimes, on Mac OS X, programmers accidentally press Option+Space
rather than just Space and don’t see the difference. The problem is
that Option+Space writes a non-breaking space (0XA0) rather than a
normal space (0x20).
This commit removes all the non-breaking spaces inadvertently
introduced in the comments of the code.
|
| | |
|
| |
| |
| |
| |
| | |
Turbolinks should be located at the bottom of application.js
to detect assets change properly.
|
| | |
|