aboutsummaryrefslogtreecommitdiffstats
path: root/railties
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Merge pull request #12778 from etehtsea/rake-default-fix"Yves Senn2014-05-282-5/+1
| | | | | | | | | | | | | This reverts commit ec0a2b57f67c9153cb5f7bbe2a3f66d13fe64bdd, reversing changes made to a8bd7b16260c217290ef8fe3a166fcceac442c62. This reverts commit 555ec36522011862c03b483c53be32410594a51e This reverts commit 555ec36522011862c03b483c53be32410594a51e By default, Rails uses the `default` Rake task to run all tests. This commit changed the environment of the default task to `development`. This clears the development database and has other negative consequences.
* Merge pull request #15269 from arunagw/aa-fixes-8930Rafael Mendonça França2014-05-272-0/+41
|\ | | | | rake railties:install:migrations respects the order of railties
| * rake railties:install:migrations respects the order of railtiesArun Agrawal2014-05-272-0/+41
| | | | | | | | This PR fixes #8930 and some stuff from #8985
* | Deprecate all *_filter callbacks in favor of *_action callbacksRafael Mendonça França2014-05-272-4/+4
| | | | | | | | | | This is the continuation of the work started at 9d62e04838f01f5589fa50b0baa480d60c815e2c
* | Merge pull request #15327 from alexbel/replace_double_quotes_with_single_quotesYves Senn2014-05-273-11/+32
|\ \ | | | | | | | | | Replace double quotes with single quotes while adding an entry into Gemfile
| * | Replace double quotes with single quotes while adding an entry into Gemfilealexbel2014-05-263-11/+25
|/ /
* | Merge pull request #15333 from ShunsukeAida/update_ruby_versionRafael Mendonça França2014-05-261-1/+1
|\ \ | | | | | | update the recommended ruby version.
| * | update the recommended ruby versionShunsukeAida2014-05-271-1/+1
| | |
* | | Merge pull request #15294 from schneems/schneems/generator-output-in-error2Rafael Mendonça França2014-05-262-14/+20
|\ \ \ | |/ / |/| | print generators on failed generate
| * | print generators on failed generateschneems2014-05-262-14/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Let's say we just ran: ``` $ rails g migrate add_click_to_issue_assignment ``` We will get an error that looks like: ``` Could not find generator migrate. ``` This patch adds all existing migrations to the output to make it easier for a developer to find a valid migration. ``` Could not find generator "migrate". Please select a valid generator: Rails: assets controller generator helper integration_test mailer migration model resource scaffold scaffold_controller task ``` It would be nice to do some spelling detection and suggest alternatives, but for now this should help.
* | | simple solution that brings rake stats task to every kind of rails projectAndriy Tyurnikov2014-05-261-18/+22
| | |
* | | Merge pull request #15305 from tgxworld/remove_unnecessary_requireGuillermo Iguaran2014-05-242-2/+2
|\ \ \ | | | | | | | | Remove unnecessary require of Minitest.
| * | | Remove unnecessary require of Minitest.Guo Xiang Tan2014-05-242-2/+2
| | |/ | |/| | | | | | | Minitest has already been required when calling Minitest.autorun.
* | | integration tests do not need to load fixtures by handXavier Noria2014-05-251-3/+0
| | | | | | | | | | | | | | | I don't know when this changed, checked back up to 3.2 and integration tests instantiate fixtures just fine.
* | | Merge pull request #15299 from andriytyurnikov/engine_friendly_rake_statsRafael Mendonça França2014-05-242-19/+24
|\ \ \ | | | | | | | | rake stats for engines
| * | | rake stats for enginesAndriy Tyurnikov2014-05-242-19/+24
| |/ /
* | | Merge pull request #15298 from ShunsukeAida/fix_capitalizationRafael Mendonça França2014-05-241-1/+1
|\ \ \ | | | | | | | | fixed capitalization [ci skip]
| * | | fixed capitalizationShunsukeAida2014-05-251-1/+1
| | |/ | |/|
* | | Add FIXME note about the thor bugRafael Mendonça França2014-05-241-0/+2
| | |
* | | Merge pull request #9083 from bronson/patch-1Rafael Mendonça França2014-05-241-1/+4
|\ \ \ | |/ / |/| | | | | avoid using alias in generators
| * | avoid using alias in generatorsScott Bronson2013-01-251-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ruby's alias produces public methods, causing a spurious Thor task to be created.  For example, this is the reason MigrationGenerator currently has two tasks:     > ActiveRecord::Generators::MigrationGenerator.all_tasks.keys     => ["singular_name", "create_migration_file"] singular_name was meant to be an attribute, not a task.  Because it's public, it gets called as a task every time the generator is invoked. The fix is to ensure all generator methods have the correct visibility.
* | | Revert "Merge pull request #15293 from ↵Yves Senn2014-05-241-16/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | schneems/schneems/generator-output-in-error" This reverts commit 7466d6a9f989a1a8f90899b79b34f1152e440b7c, reversing changes made to b850c4c540e8f0c15742f67c532f521a4a123655. This was an accidental merge. A new PR will follow. /cc @schneems
* | | Merge pull request #15293 from schneems/schneems/generator-output-in-errorRichard Schneeman2014-05-241-12/+16
|\ \ \ | | | | | | | | print generators on failed generate
| * | | print generators on failed generateschneems2014-05-241-12/+16
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Let's say we just ran: ``` $ rails g migrate add_click_to_issue_assignment ``` We will get an error that looks like: ``` Could not find generator migrate. ``` This patch adds all existing migrations to the output to make it easier for a developer to find a valid migration. ``` Could not find generator "migrate". Please select a valid generator: Rails: assets controller generator helper integration_test mailer migration model resource scaffold scaffold_controller task ``` It would be nice to do some spelling detection and suggest alternatives, but for now this should help.
* / | Future port c8ddb61Zachary Scott2014-05-231-2/+1
|/ /
* | Default config.assets.digests to true in developmentDan Kang2014-05-174-14/+20
| |
* | New applications should be created with json serializerRafael Mendonça França2014-05-172-0/+41
| | | | | | | | | | | | | | | | | | | | | | The fix introduced at 75ba7425f6d235f254c00a45a58f42e88f80301a were missing this case. To fix the original issue mentioned at that commit the correct is to remove update_config_files from the command list since we should not run both config_files command when creating a new application. Tests were added to make sure everything is working fine.
* | Fix app generator test hanging.Christian Wesselhoeft2014-05-172-6/+2
| |
* | foo :bomb:Rafael Mendonça França2014-05-161-2/+5
| |
* | Generate the cookies_serializer configuration with :marshal when upgradingRafael Mendonça França2014-05-162-1/+12
| | | | | | | | | | | | | | | | | | | | | | We were generating this configuration with :json what may break applications upgrating from Rails 4.0-. Now we always generate with a safer value and people is free to choose hybrid if they want. We don't generate with hybrid by default because there are some cases that can fail. These cases are explained on the upgrading guide.
* | Ok. Enough models for today :rage:Rafael Mendonça França2014-05-121-3/+6
| |
* | This is also a modelRafael Mendonça França2014-05-121-1/+1
| |
* | This model is a model so it should behaves like oneRafael Mendonça França2014-05-121-7/+3
| |
* | Replace :base with :in [ci skip]Marcio Junior2014-05-111-2/+2
| |
* | Change Gemfile’s double quotes in plugin generatorJosemar Luedke2014-05-102-7/+7
| | | | | | | | | | Since the generated application’s Gemfile is using single quotation marks, it seems fair to use it on plugin’s Gemfile as well.
* | Merge pull request #15015 from pothibo/database-configurationRafael Mendonça França2014-05-073-1/+22
|\ \ | | | | | | Use Rails::Paths::Path#existent in database_configuration
| * | Use Rails::Paths::Path#existent in database_configurationPier-Olivier Thibault2014-05-073-1/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Database configuration was trying to load the first path that config.paths['config/database'] was returning even if the path didn't exist in the filesystem. Because Rails::Paths::Path has the possibility to return more than 1 path (as an array), database_configuration should filter down the paths to the existing one and then load the first one. This would make it possible to move the database.yml file and add the new path to paths['config/database'] and still load the configurations.
* | | Return a non zero code when db has never been setup on statusPaul B2014-05-071-1/+1
|/ /
* | rename `str` to `string` to fix overshadowing of variableVipul A M2014-05-071-1/+1
| |
* | Fix rails dbconsole for jdbcmysql adapter.Gabriel Gilder and Jim Kingdon2014-05-051-1/+1
| |
* | skip-git should not hit git commands plugin generatorsArun Agrawal2014-05-023-14/+38
| |
* | Works correctly if git not installedRoman Shmatov2014-05-022-8/+30
| |
* | Automaticly add username and email if configured in git-scm, as bundle gemAbd ar-Rahman Hamidi2014-05-023-3/+19
| |
* | Avoid unnecessary conditional blockGiovanni Cappellotto2014-05-011-5/+0
| | | | | | | | | | GeneratedAttribute#column_name checks already for reference? on the attribute returning the right name to use as symbol for label and field.
* | Generators, remove leftover variable assignment. refs #14877Yves Senn2014-04-271-1/+0
| | | | | | | | | | The last uses of this variable was removed with the `--builder` option. 2da5ea1c9feb4a7b491bd00bd6ffd931b9203da8
* | Merge branch 'master' into adequaterecordAaron Patterson2014-04-251-2/+2
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (28 commits) move AR length validation tests into separate test-case. No need for trailing slash on migration path. reset `@arel` when modifying a Relation in place. PostgreSQL Timestamps always map to `:datetime`. [ci skip] Improve formatting and yml Fix a typo in the doc of forty_two AR FinderMethod Improve readability of contributing to rails guide. [ci skip] Precompile the image we're referencing, too. `ActiveRecord::Base.no_touching` no longer triggers callbacks or start empty transactions. Fixed an issue with migrating legacy json cookies. Correct comment [ci skip] Perfer to define methods instead of calling test Fix syntax error Add CHANGELOG entry for #14757 [ci skip] Fix run-on sentences and improve grammar [skip ci] Add test for using ActionView::Helpers::FormHelper.label with block and html select! renamed to avoid name collision Array#select! Rearrange deck chairs on the titanic. Organize connection handling test cases. Change favicon_link_tag helper mimetype from image/vnd.microsoft.icon to image/x-icon. ActionController::Renderers documentation fix ...
| * | Precompile the image we're referencing, too.Matthew Draper2014-04-241-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | You can't compile a file that references a non-compiled asset's path. .. unless you turn off asset runtime errors. Outside of a test case like this, `config.assets.precompile` would normally retain its default entry, which precompiles all images (and other non-JS/CSS files) that are in `app/assets`.
* | | Revert "Edge Rails applications doesn't need to use arel master"Aaron Patterson2014-04-231-1/+2
|/ / | | | | | | This reverts commit 7f62f30f58fe5f2955e3292ab1f01aa2c9a8f0ee.
* | Make console and generators blocks works at Application instance levelRafael Mendonça França2014-04-144-0/+114
| | | | | | | | | | | | | | Like rake tasks and runner blocks these blocks should also being shared between applications since they are stored at the classes. Fixes #14748
* | :scissors:Rafael Mendonça França2014-04-141-4/+4
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-03 00:21:50 +0000