| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Previous commit accidentally broke mixing line filters with string -n filter.
Fix by checking if it is a string and returning it.
We also need to ensure the -n filter carry forward into any other composite filters.
Fix by letting the named filter be extractable, so we'll keep this for the next runnable's
run.
|
|
|
|
|
| |
Dummy apple icon files has been added after the 5.0.0.beta2 release.
ref: #23455
|
|
|
|
|
|
|
|
| |
on sprockets environment
- Remove jquery-rails if --skip-sprockets is true
Fixes #23431
|
|
|
|
|
|
|
|
| |
Redis now included in Gemfile but commented out. This change was made in
91864439c7aebb6ca710831aac6781903a433904 and is causing the test
failure.
See https://travis-ci.org/rails/rails/jobs/106994913#L1025
|
|\
| |
| | |
Pass api only option to rails rails:update task to update only based on api Apps
|
| |
| |
| |
| | |
Fixes #23470
|
| |
| |
| |
| | |
All grown up and shit!
|
| |
| |
| |
| | |
So no need to have it on by default in the Gemfile.
|
| |
| |
| |
| | |
So it can properly show stats for an app with 1,000,000+ LOC
|
| |
| |
| |
| |
| |
| | |
This reverts commit 293bd95c3e77275193130bc14c986348aae8b0e2.
This broke the header :<
|
|\ \
| | |
| | | |
Active Record supports MySQL >= 5.0
|
| | |
| | |
| | |
| | |
| | | |
Currently some features uses `information_schema` (e.g. foreign key
support). `information_schema` introduced since MySQL 5.0.
|
|\ \ \
| |/ /
|/| | |
Fix line filters running tests from multiple runnables.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Because of the expanding whitelist for test filters, this test ended up
running the tests on lines 4 and 9 in the post test even though the path
wasn't right.
Happened incidentally because the same line numbers were used in both
account and post test.
Add the .rb line so the file is required correctly and the filters are
applied.
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
`derive_regexp` was written with the assumption that we were run from a
blank slate — that if the filter didn't match we might as well return it
because it was nil.
This isn't the case because minitest calls `run` on every runnable. Which
is any subclass of Minitest::Runnable, such as ActiveSupport::TestCase,
ActionDispatch::IntegrationTest as well as any inheriting from those.
Thus after the first `run` we'd have put in a composite filter in
`options[:filter]` making the next `run` create a linked list when it
failed to match the regexp and put the composite filter as the head.
Every runnable would accumulate more and more of the same filters,
which effectively acted like an expanding whitelist and we ran tests
from other runnables.
Clog the accumulation by returning nil if there's no filter to derive
a regexp from.
Note: we pass a seed in the tests because Minitest shuffles the runnables
to ensure the whitelist is expanded enough that the failure is triggered.
|
|/
|
|
|
|
|
|
| |
Previously Safari would try to load these files when you visit
localhost:3000. That created two exceptions in the log. It also caused
the exception notifier to send them out.
In response to #23427
|
|\
| |
| | |
update supported version of PostgreSQL in docs [ci skip]
|
| |
| |
| |
| | |
Follow up to #23434
|
|/
|
|
|
| |
For other task has become to use the rails command at doc and test,
I think that routes task also it is better to use the rails command.
|
|\
| |
| | |
move `test_generator_if_skip_action_cable_is_given_for_an_api_app` to the appropriate file
|
| |
| |
| |
| |
| |
| | |
appropriate file
Test of Rails API should be in `api_app_generator_test.rb`.
|
|/
|
|
|
|
| |
Generated engines should call `protect_from_forgery`. If this method
isn't called, then the Engine could be susceptible to XSS attacks.
Thanks @tomekr for reporting this to us!
|
| |
|
|
|
|
|
|
| |
And improve changelongs.
[ci skip]
|
| |
|
|
|
|
|
|
| |
Solves personal insanity, since I was down in these files.
(Please don't submit PRs like this.)
|
|\
| |
| | |
Add options for rake routes task
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Add two options: `-c` and `-g`.
`-g` option returns the urls name, verb and path fields that match the pattern.
`-c` option returns the urls for specific controller.
Fixes #18902, and Fixes #20420
[Anton Davydov & Vipul A M]
|
|\ \
| | |
| | | |
Address remaining known issues in Interlock
|
| | |
| | |
| | |
| | |
| | |
| | | |
We mostly care about `reload_classes_only_on_change=true`, because
that's the default... and there, we definitely need to wait for the lock
when necessary.
|
|\ \ \
| |_|/
|/| |
| | |
| | | |
yahonda/shorten_internal_metadata_table_name_less_than_30_byte
Shorten ActiveRecord::InternalMetadata.table_name to ar_internal_metadata
|
| | |
| | |
| | |
| | | |
to support Oracle database which only supports 30 byte identifier length
|
|\ \ \
| | | |
| | | | |
Add Default Puma Config
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When the `puma` command is run without any configuration options it will detect presence of a `config/puma.rb` file and use that. Currently there is discrepancy between `puma` command and `rails server` but Evan said it would be reasonable to add in reading in config from the default location. I am working on that right now as a feature in puma/puma.
Why do we need this? By default Puma uses 16 threads, and by default ActiveRecord only has 5 threads. Due to the architecture of AR it is guaranteed that if you're running with fewer DB connections than your server has threads you will hit `ActiveRecord::ConnectionTimeoutError ` eventually if your app gets modest amounts of traffic. Since we are providing a default webserver, we should provide reasonable configuration for that webserver.
This PR does a few things, first it sets the default Puma thread count to 5 to mach ActiveRecord's default. It sets the default environment to `"development"` and the default port to 300 so that booting the server with `$ puma` will give you the same default port as `rails server`. It is worth mentioning that by reading in from `PORT` environment variable this config can work with containerized deployments, such as on Heroku.
We are not using worker processes by default, that way JRuby and windows devs can use this configuration without modification. I went ahead and included a default `on_worker_boot`. It won't be used unless a worker count is specified, that means this config will not use it. Even though it's not being used now It will make someone who wants to try modifying their config to run extra workers easier.
cc/ @pixeltrix
|
|\ \ \ \
| |_|_|/
|/| | | |
Change default ACa adapter for development & test
|
| | | | |
|
|\ \ \ \
| |_|_|/
|/| | | |
Redis sans EventMachine
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This new adapter does get a little more intimate with the redis-rb gem's
implementation than I would like, but it's the least bad of the
approaches I've come up with.
|
|\ \ \ \
| |_|/ /
|/| | | |
make rake proxy work in rails engines
|
| | | | |
|
|/ / / |
|
|/ /
| |
| |
| |
| |
| |
| | |
If the specified `skip_action_cable` option, so as not to output the
`action_cable_meta_tag` in template, gsub is unnecessary.
ref: https://github.com/rails/rails/blob/master/railties/lib/rails/generators/rails/app/templates/app/views/layouts/application.html.erb.tt#L6..L8
|
|\ \
| | |
| | | |
Add an after_bundle callback in Rails plugin templates
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \
| |/ /
|/| | |
Remove empty lines in Rails development logger
|
| | |
| | |
| | |
| | |
| | |
| | | |
This is causing bugs like #23215 to occur, due to the extra spaces being
inserted. Also, this is fixed upstream in the upcoming release of
Sprockets 4.
|
|\ \ \
| | | |
| | | | |
Introduce new welcome page for new projects
|