aboutsummaryrefslogtreecommitdiffstats
path: root/railties
Commit message (Collapse)AuthorAgeFilesLines
* Ditch `Commands` namespace for base command.Kasper Timm Hansen2015-12-064-83/+78
| | | | | | | Reading `Rails::Commands::Command` feels excessive. Especially if users can subclass command to write their own commands — which I'd like to aim for. Switch to `Rails::Command` before we get too far into things.
* Invert command and commands tasks reference.Kasper Timm Hansen2015-12-063-10/+14
| | | | | | | We should first attempt to run commands through Rails command, and then fall back to trying the commands tasks. Because eventually the commands tasks should be their own commands.
* Remove "run with rake" suggestion.Kasper Timm Hansen2015-12-061-22/+0
| | | | | | | | | When attempting to run a `rake` task with `bin/rails`, Rails would see check that a Rake task existed and ask users if they meant to run it with rake. We don't need that anymore, as the goal is to have `rails` be a valid way to run rake tasks.
* Add class level `run` to Rails command.Kasper Timm Hansen2015-12-062-22/+15
| | | | | | | | | | | | The class level version is responsible for changing a task name to command name, then finding a command and run it if there is one. The instance level `run` then makes sure arguments have been parsed into `@options` and runs the command by sending it. `Rails::Commands::Command.run` returns true to make it work within `Rails::CommandsTask`, but won't in the future when it handles all option parsing.
* Replace `-> {}` with a proc.Kasper Timm Hansen2015-12-051-1/+1
| | | | | | | | When `parse_options_for` was called for a command that hadn't set up any option parsing with `options_for`, the `call` method would be sent to `-> {}`, which didn't like to be passed two arguments. Switch to `proc {}` which can accept several arguments.
* Remove `_instance` suffix from command.Kasper Timm Hansen2015-12-051-2/+2
| | | | | I want to streamline the wording around `command`, and not start pondering about instances.
* Default `argv` to an empty array.Kasper Timm Hansen2015-12-051-1/+1
| | | | | | | | | | | | | The `ARGV` constant in Ruby is not a string, it's an array as demonstrated by running: ``` $ ruby -e "p ARGV" => [] $ $ ruby -e "p ARGV" test/file.rb --version=2 => ["test/file.rb", "--version=2"] ```
* Spruce up `command_for`.Kasper Timm Hansen2015-12-051-4/+1
| | | | | | * Ditch the instance methods local variable. * Prefer Ruby's default nil return, and remove else branch.
* `exists?` isn't for users.Kasper Timm Hansen2015-12-051-1/+1
| | | | | | | | Checking that a command exists before running it is an implementation detail of the Rails command and Rake task world right now. Eventually I'd like to get rid of `exists?`, when I've worked out another way to fall back to run the old tasks.
* Move `command_name_for` to private section.Kasper Timm Hansen2015-12-051-4/+4
| | | | | Users shouldn't have to lookup the command name for a task. Put it in the private section, so it doesn't show up in any generated documentation.
* Add Rails command infrastructure and encapsulate development cachingChuck Callebs2015-12-049-51/+144
|
* Disable FileEventedUpdateChecker for nowRafael Mendonça França2015-12-041-5/+1
| | | | | Railsties tests are broken with this new update checker so we will use the old one until we have the tests fixed.
* Mac OS X use /private as directory to temp fileRafael Mendonça França2015-12-041-1/+1
| | | | Related with e62ddac05b7d827ae870898d7cd9eaf76e0730aa
* Remove test_files check from plugin checksRafael Mendonça França2015-12-041-4/+0
| | | | Related with 668c006cf33a63ac3f8a8f064c772a339341e70c.
* Remove warningsRafael Mendonça França2015-12-041-4/+4
|
* Merge pull request #22469 from merhard/fix_custom_file_loader_testRafael França2015-12-021-0/+2
|\ | | | | Fix failing test using custom file watcher
| * Fix failing test using custom file watcherMatthew Erhard2015-12-021-0/+2
| | | | | | | | | | | | | | LoadingTest#test_does_not_reload_constants_on_development_if_custom_file_watcher_always_returns_false in railties/test/application/loading_test.rb is failing with: `NoMethodError: undefined method 'execute' for #<#<Class:0x00000002465a30>:0x00000001f79698>` The test creates an anonymous class to be used as a custom file watcher using `config.file_watcher=`. Per the Rails guides for Configuring, the class set to `config.file_watcher` “Must conform to ActiveSupport::FileUpdateChecker API”. Per the docs for ActiveSupport::FileUpdateChecker, the API depends on four methods: #initialize, #updated?, #execute, and #execute_if_updated. The custom file watcher in the failing test only implements the first two methods. This pull request adds #execute and #execute_if_updated to the custom file_watcher, conforming it to the ActiveSupport::FileUpdateChecker API, and passing the test.
* | Revert "don't start a new process for every test file"Matthew Erhard2015-12-021-21/+8
|/ | | | | This reverts commit 5a0e0e72995472e315738dcea5b5a12d6e3d3489. This commit causes railties tests on TravisCI to always return a 0 status (all tests passing), even when tests are failing. Reverting for now until a new solution can be found.
* allow use of minitest-rails gem with test runnerChris Kottom2015-11-302-1/+7
|
* add `bin/test` script to rails pluginyuuji.yaginuma2015-11-287-7/+153
|
* let the generated app Gemfile depend on listen 3.0.5Xavier Noria2015-11-261-1/+1
| | | | See https://github.com/rails/rails/commit/14b20ce9b38314943dcaf73b8dab7508b70ba487.
* Merge pull request #22263 from mastahyeti/csrf-origin-checkRafael França2015-11-261-0/+4
|\ | | | | | | | | Add option to verify Origin header in CSRF checks [Jeremy Daer + Rafael Mendonça França]
| * Add option to verify Origin header in CSRF checksBen Toews2015-11-251-0/+4
| |
* | Merge pull request #22401 from cllns/remove-br-from-scaffoldKasper Timm Hansen2015-11-252-3/+7
|\ \ | | | | | | Remove <br> from scaffold form, in favor of using CSS
| * | Remove <br> from scaffold, in favor of using CSSSean Collins2015-11-252-3/+7
| | |
* | | Merge pull request #22290 from y-yagi/donot_show_test_unit_jobEileen M. Uchitelle2015-11-251-0/+1
|\ \ \ | |/ / |/| | do not show Active Job test generator
| * | do not show Active Job test generatoryuuji.yaginuma2015-11-141-0/+1
| | | | | | | | | | | | | | | Like the other generator, for also Active Job, I think that there is no need to display for test generator.
* | | Merge pull request #22370 from yui-knk/remove_blank_lineAndrew White2015-11-241-1/+0
|\ \ \ | | | | | | | | Remove a blank line from a template for plugin `routes.rb`
| * | | Remove a blank line from a template for plugin `routes.rb`yui-knk2015-11-221-1/+0
| | | |
* | | | Merge pull request #22287 from dharamgollapudi/patch-2Rafael França2015-11-241-2/+1
|\ \ \ \ | | | | | | | | | | Move the desc one level up
| * | | | Move the desc one level up Dharam Gollapudi2015-11-131-2/+1
| | |/ / | |/| | | | | | Make the task visible (from rake -T) by moving the desc one level up
* | | | Merge pull request #22272 from y-yagi/remove_test_files_in_plugin_gemspecEileen M. Uchitelle2015-11-231-3/+0
|\ \ \ \ | |_|/ / |/| | | don't package test files in plugin gemspec
| * | | don't package test files in plugin gemspecyuuji.yaginuma2015-11-121-3/+0
| | |/ | |/| | | | | | | | | | | | | | | | | | | In rails engine, there is a dummy application under test, the size of the test file is increased. However, there is no need test files for most users, I think it good to have so as not included by default.
* | | Make the `static_index` config part of the `config.public_server` configYuki Nishijima2015-11-164-7/+12
| |/ |/| | | | | Also call it `public_server.index_name` so it'll make more sense.
* | Prefer Minitest's location for test failures.Kasper Timm Hansen2015-11-122-3/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When running tests, the Rails test runner would report the start of the test method as the test failure. For this test: ```ruby 1 require 'test_helper 2 3 class BunnyTest < ActiveSupport::TestCase 4 test "something failing" do 5 assert false, 'This failed' 6 end 7 end ``` The runner outputs 5 instead of 4: ``` ............................................F This failed bin/rails test test/models/bunny_test.rb:5 ........ ```
* | Don't match specific line numbers in reporter tests.Kasper Timm Hansen2015-11-121-4/+4
| | | | | | | | The overall syntax of the file path is more important, not the exact line it was on.
* | registers these changes in the CHANGELOGsXavier Noria2015-11-111-0/+5
| |
* | encapsulates the logic to choose the file monitor in app configXavier Noria2015-11-101-1/+9
| |
* | upgrade listen to 3.0.4Xavier Noria2015-11-081-1/+1
| | | | | | | | 3.0.3 has a bug in OS X.
* | move the listen gem in the Gemfile to the development groupXavier Noria2015-11-081-3/+4
| |
* | implements an evented file update checker [Puneet Agarwal]Xavier Noria2015-11-082-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | This is the implementation of the file update checker written by Puneet Agarwal for GSoC 2015 (except for the tiny version of the listen gem, which was 3.0.2 in the original patch). Puneet's branch became too out of sync with upstream. This is the final work in one single clean commit. Credit goes in the first line using a convention understood by the contrib app.
* | fix application_controller require_dependency path generated by api scaffold ↵yuuji.yaginuma2015-11-082-1/+25
|/ | | | | | | | | generator In the app generator, regardless of the namespace, it is adapted to read the same `application_controller.rb`, modified to api generator also be the same behavior. ref 686966a1861e6761021d45f6795de753e8a62216, 06ac63b4c602e4b26cb3bfbf0dfd2bed8b00e786
* [ci skip] Remove final mentions of `static_cache_control` in docs.Kasper Timm Hansen2015-11-051-1/+3
| | | | | | It was deprecated in https://github.com/rails/rails/pull/19135. We're now favoring `public_file_server.headers`.
* Fix `static_cache_control` deprecation warningJon Atack2015-11-051-3/+6
| | | | | | | | | | | | | | | | | | | | | | 1. Fix the message by wrapping the value in missing quotes and adding the missing backtick at the end. Finally, :lipstick: by adding a space inside the curly braces. Before: `config.public_file_server.headers = {'Cache-Control' => public, max-age=31536000} Now: `config.public_file_server.headers = { 'Cache-Control' => 'public, max-age=31536000' }` 2. Display `static_cache_control` instead of static_cache_control. This follows what the 2 neighboring methods are doing. 3. Use strip_heredoc to improve the code formatting and readability like the 2 neighboring methods and wrap to 80 characters.
* Replace `serve_static_files` in tests with `public_file_server.enabled`.Kasper Timm Hansen2015-11-044-5/+5
| | | | Forgot to do it in 748b2f9, when deprecating `serve_static_files`.
* Merge pull request #22173 from kaspth/enable-public-file-serverKasper Timm Hansen2015-11-046-12/+84
|\ | | | | Add enabled flag to the public file server settings.
| * Move `static_cache_contorl` deprecation changelog entry to Railties.Kasper Timm Hansen2015-11-041-0/+22
| | | | | | | | | | | | | | The configuration for `config.static_cache_control`, and its replacement `config.public_file_server.headers` are implemented in Railties. People would configure this in environment files, which is Railties domain too.
| * Add enabled flag to the public file server.Kasper Timm Hansen2015-11-036-12/+62
| | | | | | | | | | | | | | | | As discussed in https://github.com/rails/rails/pull/19135#issuecomment-153385986. Replaces `serve_static_files` to unify the static options under the `public_file_server` wing. Deprecates `serve_static_files` accessors, but make them use the newer config internally.
* | don't start a new process for every test fileAaron Patterson2015-11-031-8/+21
|/ | | | | | | we can just reuse the parent process. We should figure out what files are commonly required among the test files and try to require them in the parent so that the require time cost is amortized across the processes.
* added missing instructions for `rack-cors`Gaurav Sharma2015-11-031-2/+4
| | | | | `config.middleware.insert_before` changes require to restart the server Also added missing `.` at the EOL.
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-30 19:27:21 +0000