| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| | |
Small refactoring changes to generators.
Conflicts:
railties/lib/rails/generators/rails/controller/controller_generator.rb
|
| |
| |
| |
| |
| | |
Made a method name clearer (added a bang to the end to show that it
mutates arguments) and extracted indentation into its own method.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Right now when you start a server via `rails s`, the logger gets extended so that it logs to the file system and also to stdout. This extension behavior is not "intelligent" and if the default logger is already set to output to stdout, then the contents will be received twice.
To capture logs in accordance with http://www.12factor.net/logs some platforms require the logs to be sent to standard out. If a logger is set to stdout, and the server is started using `rails server` instead of another method (i.e. `thin start` etc.) then the app will produce double logs.
This PR fixes the issue by only extending the logger to standard out in the development environment. So that in production you don't get double logs like this:
```
ActionView::Template::Error (wrong number of arguments (5 for 4)):
1: <% lang_index = 0 %>
2: <div class="row">
3: <ul class="nav nav-tabs nav-stacked span2" data-tabs="tabs" id="repo-tabs">
4: <% repos.group_by(&:language).each do |lang, repos| %>
5: <% unless lang == nil %>
6: <li><a href="#<%= "#{lang.parameterize}#{lang.hash}" %>" data-toggle="tab"><%= lang %></a></li>
7: <% end -%>
app/views/shared/_repos.html.erb:4:in `_app_views_shared__repos_html_erb___1685450633638247395_70300668607000'
app/views/pages/index.html.erb:13:in `_app_views_pages_index_html_erb__2084723628308867770_70300687584880'
ActionView::Template::Error (wrong number of arguments (5 for 4)):
1: <% lang_index = 0 %>
2: <div class="row">
3: <ul class="nav nav-tabs nav-stacked span2" data-tabs="tabs" id="repo-tabs">
4: <% repos.group_by(&:language).each do |lang, repos| %>
5: <% unless lang == nil %>
6: <li><a href="#<%= "#{lang.parameterize}#{lang.hash}" %>" data-toggle="tab"><%= lang %></a></li>
7: <% end -%>
app/views/shared/_repos.html.erb:4:in `_app_views_shared__repos_html_erb___1685450633638247395_70300668607000'
app/views/pages/index.html.erb:13:in `_app_views_pages_index_html_erb__2084723628308867770_70300687584880'
```
ATP Railties. Opened against master in favor of #10999
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Before this commit options for `rails new` and `rails plugin new` had to
be passed in a strict order, trying to execute a following command:
rails new -J path/to/app
resulted in an error.
This commit fixes the situation and allows to pass path to app anywhere
after `new`
|
|\ \
| | |
| | | |
Fix typos: the indefinite articles(a -> an).
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
This reverts commit ba0407337e93c4ef55cef3472143f62e8a984a64.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Previously, our default HTML would validate properly, but would generate
a warning: it doesn't declare a character encoding.
According to [the spec][encoding-spec], if you don't specify an
encoding, a 7 step algorithm happens, with a toooon of sub-steps. Or, we
could just actually specify it.
Since everything else in Rails assumes UTF-8, we should make sure pages
are served with that encoding too. This meta tag is the simplest way to
accomplish this.
More resources:
* http://blog.whatwg.org/the-road-to-html-5-character-encoding
* http://www.w3.org/International/tutorials/tutorial-char-enc/
* http://validator.w3.org/
[encoding-spec]: http://www.whatwg.org/specs/web-apps/current-work/multipage/parsing.html#determining-the-character-encoding
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* we no more have to manipulate the each caller strings by ourselves using caller_locations
* caller_locations runs slightly faster, and creates less objects than good old caller
Benchmark (loading an Engine 1000 times):
caller: 262.89 ms
caller_locations: 186.068 ms
|
|\ \ \
| | | |
| | | | |
Revert fixes
|
| | | | |
|
| |/ /
| | |
| | |
| | |
| | |
| | | |
1. As we have vendor in AV only
2. No more vendor in AC
3. No vendor folder in AR
|
|/ / |
|
|\ \
| | |
| | | |
Remove unused delegate
|
| | |
| | |
| | |
| | | |
Related with commit 4a2a504
|
|\ \ \
| |/ /
|/| | |
Update Rails::Railtie::Configuration and ActionDispatch::Response#respond_to? to accept include_private argument
|
| | |
| | |
| | |
| | | |
ActionDispatch::Response#respond_to? to accept include_private argument
|
| | |
| | |
| | |
| | | |
[John J. Wang & Prathamesh Sonpatki]
|
| |/
|/| |
|
| |
| |
| |
| |
| |
| |
| | |
The defaults hash isn't used unless the +class_options+ hash has a
particular key, so we don't need to compute it unless this is true.
Also moving some code for extracting a module into its own method.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When creating a new application using the default rails generator
(`rails new my_app`), it will apply some permissions bypassing the
current process umask. The `bin' directory and any files inside it will
always be set a mode of 0755.
This change removes the current umask bits from the mode applied by
the generator on the `bin' directory and its content.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
It's needed for tests
|
| | |
|
| | |
|
| | |
|
| | |
|
|\ \
| |/
|/|
| |
| |
| |
| |
| | |
Conflicts:
actionview/README.rdoc
activerecord/lib/active_record/migration.rb
guides/source/development_dependencies_install.md
guides/source/getting_started.md
|
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 70d6e16fbad75b89dd1798ed697e7732b8606fa3, reversing
changes made to ea4db3bc078fb3093ecdddffdf4f2f4ff3e1e8f9.
Seems to be a code merge done by mistake.
|
| |
| |
| |
| | |
This reverts commit 157dc275da0ad38635337b7c1d96de656d91de8e.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
Similar to #11497.
|
| |
| |
| |
| | |
This makes the rack_logger_test.rb runnable by itself (outside of the `rake test` suite).
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The pattern is event.component
Closes #11769
Conflicts:
railties/CHANGELOG.md
|
| |
| |
| |
| | |
[ci skip]
|
|\ \
| | |
| | | |
Rails.logger should have level specified by config.log_level.
|
| | |
| | |
| | | |
Fix bug when log level of Rails.logger (which was set via config.logger) does not match the config.log_level.
|
| | |
| | |
| | |
| | |
| | | |
This fixes railties tests in JRuby but break it in MRI
This reverts commit fea99276c7024f183bf72a16ad9f36af4bae1d42.
|
| | |
| | |
| | |
| | | |
With this change jruby should pass all of the railties tests.
|