aboutsummaryrefslogtreecommitdiffstats
path: root/railties
Commit message (Collapse)AuthorAgeFilesLines
* Railties tests are order_independent! Hopefully.Akira Matsuda2014-08-131-4/+0
|
* Fix Railties tests that were order dependentAkira Matsuda2014-08-131-0/+10
|
* Nobody sucks so nobody should call this awful method nameRafael Mendonça França2014-08-121-1/+1
|
* users_dont_suck_but_only_we_suck_and_only_our_tests_are_order_dependent!Akira Matsuda2014-08-121-0/+4
| | | | | Calling ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent! in AS::TestCase makes everyone's tests order dependent, which should never be done by the framework.
* Revert "Merge pull request #16434 from strzalek/cookies-digest-config-option"Santiago Pastorino2014-08-082-8/+1
| | | | | | | This reverts commit 705977620539e2be6548027042f33175ebdc2505, reversing changes made to dde91e9bf5ab246f0f684b40288b272f4ba9a699. IT BROKE THE BUILD!!!
* Merge pull request #16434 from strzalek/cookies-digest-config-optionSantiago Pastorino2014-08-082-1/+8
|\ | | | | Add digest config option for SignedCookiesJar
| * Return preconfigured AS::MessageVerifierŁukasz Strzałkowski2014-08-082-1/+7
| |
| * Add config option for cookies digestŁukasz Strzałkowski2014-08-081-0/+1
| | | | | | | | | | | | You can now configure custom digest for cookies in the same way as `serializer`: config.action_dispatch.cookies_digest = \SHA256'
* | save a hash allocation per request.Aaron Patterson2014-08-081-1/+1
| |
* | add a test for prepending SCRIPT_NAME to generated urlsAaron Patterson2014-08-081-0/+88
| |
* | Fixes test for Gemfile entry changesArun Agrawal2014-08-083-8/+13
|/ | | | Broken by fbe38c9e9d4fe9f82518e8ffc1d757459b0c5f1c
* Pull spring gem entry into the Gemfile template instead of gemfile_entries ↵David Heinemeier Hansson2014-08-072-10/+12
| | | | so it can be grouped with the other development tools
* Merge branch 'master' of github.com:rails/railsDavid Heinemeier Hansson2014-08-079-16/+178
|\
| * need to call superAaron Patterson2014-08-071-0/+1
| |
| * add a new constructor that runs load hooksAaron Patterson2014-08-072-5/+9
| |
| * defer running after_config hooks until after the object is allocatedAaron Patterson2014-08-071-7/+22
| |
| * lazily instantiate application subclassesAaron Patterson2014-08-063-4/+18
| | | | | | | | this means we can meaningfully override methods in the subclass
| * Merge pull request #16359 from skanev/after-bundle-in-rails-templatesYves Senn2014-08-064-0/+39
| |\ | | | | | | | | | | | | | | | | | | Add an after_bundle callback in Rails templates Conflicts: railties/CHANGELOG.md
| | * Add an after_bundle callback in Rails templatesStefan Kanev2014-08-034-0/+39
| | | | | | | | | | | | | | | | | | The template runs before the generation of binstubs – this does not allow to write one, that makes an initial commit to version control. It is solvable by adding an after_bundle callback.
| * | Revert "Revert "Merge pull request #15394 from ↵Yves Senn2014-08-061-1/+90
| | | | | | | | | | | | | | | | | | morgoth/fix-automatic-maintaining-test-schema-for-sql-format"" This reverts commit 5c87b5c5248154cf8aa76cce9a24a88769de022d.
* | | Stop using padding in the generated Gemfile -- it looks shitDavid Heinemeier Hansson2014-08-072-6/+1
|/ /
* | We don't need parenthesis for thisGuillermo Iguaran2014-08-051-1/+1
| |
* | Fix digest ETAG test.Arthur Neves2014-08-051-1/+1
| | | | | | | | | | | | After https://github.com/rack/rack/commit/12528d4567d8e6c1c7e9422fee6cd8b43c4389bf ETag will include a `W/` before the digest.
* | Bring back the helpers testsJosé Valim2014-08-053-0/+50
| | | | | | | | | | Also keep the hook as other tools may rely on it, we just don't do anything by default on Rails.
* | Fix typo [ci skip]Jon Atack2014-08-041-1/+1
| |
* | Explain why we use asset digests, not what a setter doesDavid Heinemeier Hansson2014-08-032-2/+4
| |
* | Add suggestion as to how you can app the the assets load pathDavid Heinemeier Hansson2014-08-031-0/+3
| |
* | Pull in the custom configuration concept from dhh/custom_configurationDavid Heinemeier Hansson2014-08-034-1/+82
| |
* | A few more tests asserting the presence of helper test stubsDavid Heinemeier Hansson2014-08-036-17/+0
| |
* | Stubs are no longer generated for helpers, so dont test for itDavid Heinemeier Hansson2014-08-031-4/+0
| |
* | Change the production log level default from :info to :debug. All production ↵David Heinemeier Hansson2014-08-031-2/+2
| | | | | | | | apps I have ever worked with has done this. Let us reflect that default. You often want those SQL quieries to be able to debug issues in production
* | Generating stubs for helper tests is overly specific. Most helpers should ↵David Heinemeier Hansson2014-08-034-75/+0
|/ | | | simply be tested as part of the view thats using them. If you need something beyond that, you can add a test yourself for them
* Avoid defining the test if it does not need to when not on JRubyCarlos Antonio da Silva2014-07-301-2/+2
|
* Use default argument when testing generators without the need for extra argsCarlos Antonio da Silva2014-07-302-7/+7
|
* Simplify path setupCarlos Antonio da Silva2014-07-301-1/+1
|
* Simplify plugin tests a bit, leave the regexp work for minitestCarlos Antonio da Silva2014-07-301-6/+6
|
* Invert unless..else conditions on JRuby checksCarlos Antonio da Silva2014-07-302-12/+12
|
* Remove some more globals from testsCarlos Antonio da Silva2014-07-301-26/+26
| | | | | We are using blocks here so we have access to the environment around them, no need for globals.
* Fix / improve some assertionsCarlos Antonio da Silva2014-07-301-6/+4
|
* Remove some globals from configuration testsCarlos Antonio da Silva2014-07-301-20/+20
|
* Deprecate `*_path` methods in mailers@schneems and @sgrif2014-07-303-3/+55
| | | | | | | | | | | Email does not support relative links since there is no implicit host. Therefore all links inside of emails must be fully qualified URLs. All path helpers are now deprecated. When removed, the error will give early indication to developers to use `*_url` methods instead. Currently if a developer uses a `*_path` helper, their tests and `mail_view` will not catch the mistake. The only way to see the error is by sending emails in production. Preventing sending out emails with non-working path's is the desired end goal of this PR. Currently path helpers are mixed-in to controllers (the ActionMailer::Base acts as a controller). All `*_url` and `*_path` helpers are made available through the same module. This PR separates this behavior into two modules so we can extend the `*_path` methods to add a Deprecation to them. Once deprecated we can use this same area to raise a NoMethodError and add an informative message directing the developer to use `*_url` instead. The module with warnings is only mixed in when a controller returns false from the newly added `supports_relative_path?`. Paired @sgrif & @schneems
* Revert "Merge pull request #15305 from tgxworld/remove_unnecessary_require"Santiago Pastorino2014-07-302-2/+2
| | | | | | | This reverts commit f632f79b8dcd144408c66a544984b2ba9cf52f87, reversing changes made to 98c7fe87690ca4de6c46e8f69806e82e3f8af42d. Closes #16343
* Merge pull request #16328 from noinkling/template_password_confirmation_fixYves Senn2014-07-292-1/+6
|\ | | | | | | Give password_confirmation div the "field" class in the scaffold generator "_form" partial
| * Give password_confirmation div the "field" class in erb form templatenoinkling2014-07-291-1/+1
|/
* Additional clarification on password:digest in scaffold and model generator ↵noinkling2014-07-252-4/+16
| | | | help [ci skip]
* Add password:digest information to scaffold generator help text [ci skip]noinkling2014-07-251-1/+5
|
* Remove mocha usageRafael Mendonça França2014-07-231-2/+5
|
* Fix syntax errorRafael Mendonça França2014-07-231-1/+2
|
* Dev and edge application and plugins need to include i18n masterRafael Mendonça França2014-07-231-1/+2
|
* Merge pull request #16267 from robin850/rbx-yamlRafael Mendonça França2014-07-232-0/+22
|\ | | | | Set Psych as the YAML engine for Rubinius