| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | |
|
| |\ \ |
|
| |\ \ \ |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
With Active Storage supporting Azure, we should show people how to set it up.
Incorporates the minor changes originally in https://github.com/rails/activestorage/pull/88 as well
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
y-yagi/use_assert_nil_if_value_is_nil_in_assert_field_default_value_
Use `assert_nil` if `value` is nil in `assert_field_default_value`
|
| | |_|/ /
| |/| | |
| | | | |
| | | | |
| | | | | |
It is deprecate to specify nil for expect argument of `assert_equal`.
Ref: https://github.com/seattlerb/minitest/commit/922bc9151a622cb3ef0b9f170aa09c3bb72c7eb8
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove extra empty line
|
| | |/ / /
| |/| | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Improve bundler binstub error message
|
| | | | | | |
|
| | |_|_|/
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Rails displays an error message if you have a bundler-generated binstub
at `./bin/rails` instead of a Rails-generated binstub.
This error message is misleading because it makes it seem as though
Rails 5 introduced recent changes in how binstubs are used, when these
changes were actually introduced way back in Rails 4.
The suggested upgrade steps are appropriate for an app that was created
in Rails 3, but they likely aren't the correct fix for someone who sees
this error message today on a modern app. I believe the `--binstubs`
option on bundler is a more likely culprit and troubleshooting path.
|
|\ \ \ \ \
| |_|_|/ /
|/| | | | |
Handling add/remove to/from migration edge cases
|
| | | | |
| | | | |
| | | | |
| | | | | |
Making sure the table name is parsed correctly when an add/remove column migration have 'from'/'to' in the table name.
|
|\ \ \ \ \
| | |_|_|/
| |/| | | |
|
| |\ \ \ \
| | | | | |
| | | | | | |
Use duktape gem as default JS engine on Windows-MINGW
|
| | |/ / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The fallback javascript engine on Windows is Windows Script Host (JScript).
However this engine isn't able to process the default assets, because it supports
ES3 only but the coffeescript compiler requires ES5.
Fixes #30014
|
| |\ \ \ \
| | | | | |
| | | | | | |
Remove unnecessary `doc` directory deletion
|
| | | |_|/
| | |/| |
| | | | |
| | | | | |
Since 553b695, `doc` directory is not created in application.
|
| |\ \ \ \
| | | | | |
| | | | | | |
[ci skip] Fix rails_command comments
|
| | | |_|/
| | |/| | |
|
| | |/ /
| |/| | |
|
| | |/
| |/| |
|
| |/
| |
| |
| |
| |
| |
| |
| |
| | |
This fixes the following warning:
```
/tmp/d20170727-7039-kmdtb1/app/app/models/user.rb:5: warning: method redefined; discarding old model_name
rails/activemodel/lib/active_model/naming.rb:222: warning: previous definition of model_name was here
```
|
| |\ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Solves #29923
This regression was caused due to a wrong regex to filter out
paths, introduced in commit 796a1cf0e
The regex was /^\w+\// which did not accept paths with a leading
slash and hence all absolute paths were filtered out.
This change introduces a change in regex which allows for a leading
slash and acts on the matched term accordingly.
While cascading through the case block, the paths are checked for
line number specification, existence of a directory at that path
and if none of those match, then it is considered to be a path to the
file. The regex matchers specified are filtered out via the call
to `Array#compact` since they do not match any of these conditions.
|
| |\ \
| | |/
| |/|
| | |
| | | |
y-yagi/extract_assert_output_and_available_pty_to_module
Extract `assert_output` and `available_pty?` into `ConsoleHelpers` module
|
| | |
| | |
| | |
| | |
| | | |
We define almost the same method with multiple tests. Therefore, it extract
into module.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The output of `.databases` in SQLite will truncate to a certain size.
This causes the test to fail when run locally from a mac, or anything
which has a tempdir with more than a few characters. This pragma has
the same output, but presented as a normal query, meaning no truncation
will occur.
|
| |\ \
| | |/
| |/| |
Stop creating ApplicationRecord on model generation
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When generating models, we created ApplicationRecord in the default
location if no file existed there. That was annoying for people who
moved it to somewhere else in the autoload path. At this point, the
vast majority of apps should have either run the upgrade script or
generated a model since upgrading. For those that haven't the error
message after generating a new model should be helpful:
NameError: uninitialized constant ApplicationRecord
To ease friction in that case, this also adds a generator for
ApplicationRecord.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This fixes the following warning:
```
railties/test/application/rake/dbs_test.rb:265: warning: ambiguous first argument; put parentheses or a space even after `/' operator
```
|
| |\ \
| | |/
| |/|
| | |
| | | |
deivid-rodriguez/follow_up_to_multiple_location_engine_mounting
Fix regression introduced by fixing mounting the same engine in multiple locations
|
| | | |
|
| |\ \
| | | |
| | | | |
Do not show URL in boot info when using Puma
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Puma has its own configuration file(e.g. `config/puma.rb`).
Can define a port and a URL to bind in the configuration file. Therefore,
on Rails side, can not grasp which URI to bind finally.
Because of that, it may show a URL different from the actually bound
URL, so I think that it is better not to show it.
Fixes #29880
|
| |\ \ \
| | | | |
| | | | | |
Move generator namespacing to Base
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Generators need to be aware of namespace to work properly in engines.
Methods to help with this lived in Rails::Generators::NamedBase. Moving
them to Rails::Generators::Base (which NamedBase inherits from) allows a
follow-up in which a namespace aware unnamed generator can be created.
|
| | | | | |
|
| | |_|/
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
I've used many development related performance tools, but the single most consistently helpful tool is `rack-mini-profiler`.
The tool provides a lightweight UI element for each page, that shows the server response time. When clicked it expands to show more detail:
![](https://www.dropbox.com/s/0aciw4mk8c059n0/Screenshot%202017-07-24%2010.24.24.png?dl=1)
This can be used to detect expensive queries, N+1 issues and general performance related problems.
|
| | |/
| |/|
| | |
| | |
| | |
| | | |
This was missed when the frozen string literal pragma was added to this
file because the string is only modified when running in the context of
a full Rails app, which wasn't covered by the test suite.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Without setting root config, `config.paths["config/secrets"]`
located in https://github.com/rails/rails/blob/84eb498f84ebc5d1be0b0db6f7bca9da3d679ca6/railties/lib/rails/application.rb#L390
always returned empty list.
|
| |/ |
|