| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Currently, ActiveModel is only loaded by ActiveRecord. If you skip ActiveRecord, ActiveModel will not be required (or even autoloaded) and including `ActiveModel::Model` into a plain Ruby class will raise `NameError`.
To reproduce this:
- create a new app with `rails new my_app -O`
- create a Ruby class that includes `ActiveModel::Model` in `app/models`
- load up a Rails console and try to do anything with the class :-)
Since ActionPack relies so heavily on the ActiveModel API, this should probably be considered a dependency of the app. Another possibility would be to make it a dependency of ActionController.
|
|\ \ \ |
|
| | | | |
|
| | | | |
|
| |_|/
|/| | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When bundling a gem created with
rails plugin new
Bundler outputs the following warning when building the gem:
WARNING: licenses is empty
modified: railties/lib/rails/generators/rails/plugin_new/templates/%name%.gemspec
|
|\ \ \
| | | |
| | | | |
Squishy minitest5
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
+ Namespace changes, overhaul of runners.
+ Internal ivar name changes
- Removed a logger globally applied to tests that spew everywhere?!?
+ Override Minitest#__run to sort tests by name.
+ Reworked testing isolation to work with the new cleaner architecture.
- Removed a bunch of tests that just test minitest straight up. I think these changes were all merged to minitest 4 a long time ago.
- Minor report output differences.
|
|\ \ \ \
| | | | |
| | | | | |
exit with non-zero to signal failure
|
| | | | | |
|
| | | | | |
|
| |_|_|/
|/| | |
| | | |
| | | |
| | | |
| | | | |
If you generate a fresh app without ActiverRecord, this template
exhibited a lone trailing line break. My watchful pre-commit hook
told me about it so I've fixed it here.
|
|/ / /
| | |
| | |
| | | |
stub command description
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Prior to this change, for the following command:
$ rails new
we received "Options should be given after the application name" as an error message.
This is outdated and should be "Application name should be provided in arguments".
|
|\ \ \
| |_|/
|/| | |
Remove jruby-openssl from default Gemfile
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Conflicts:
activesupport/lib/active_support/callbacks.rb
|
| | | | |
|
| |/ /
|/| | |
|
| | | |
|
| | | |
|
| |/
|/| |
|
| |
| |
| |
| | |
See the comment in the rescue clause towards the top of the patch for the rationale.
|
| |
| |
| |
| | |
- http://help.github.com/ignore-files redirects to https://help.github.com/articles/ignoring-files
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- f1805a697831 Redefined 'test_scaffold_generator_no_assets' twice.
- Only the last instance of these three definitions of the same method
was getting called when the tests were actually running.
- This commit changes names of this method so that all three
definitions will be called
- scaffold.css is not generated by --assets=false switch.
- Test was expecting the presence of the file with --assets=false
- This issue was not discovered in f1805a697831b because it was
redefining the same method twice
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
Scaffold generator with --assets=false option
outputs an error
See #9525
|
|\ \
| | |
| | | |
generate 'app/assets/images' directory when creating new rails app. Fixes #10434
|
| | | |
|
|\ \ \
| | | |
| | | | |
Relaxed jbuilder dependency in Gemfile template
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
https://github.com/rails/rails/commit/558d402472b49c4c99bf6753d341d7aef2e25dd4
|
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
A regression was introduced in 5b3bb6, generating route from within an
engine to an another engine resulted in prefixing a path with the
SCRIPT_NAME value.
The regression was caused by the fact that SCRIPT_NAME should be
appended only if it's the SCRIPT_NAME for the application, not if it's
SCRIPT_NAME from the current engine.
closes #10409
|
| | | |
|
| | | |
|
| |/
|/| |
|
|\ \ |
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
syntax. This helps removing the class level abstraction of an
application.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
arunagw/minor-code-deuplication-removed-app-generator
Minor code duplication removed
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Railtie itself abstract. This stops the weird behavior of forcing
subclasses of Railtie to include the Configurable module.
|
| | | | |
|
|/ / / |
|
| | |
| | |
| | |
| | | |
can select frameworks separately when running rake test.
|
| | | |
|