aboutsummaryrefslogtreecommitdiffstats
path: root/railties
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Merge pull request #19411 from dmathieu/rack_env_changelog"Jeremy Kemper2015-03-201-7/+0
| | | | | | | Preserving RACK_ENV behavior. This reverts commit b19990c82c6a9beff0cd058dc2ff67894a2f9ea7, reversing changes made to ac291b76ea770b5795c767f2f74a8d0b33744809.
* Remove `#build_original_fullpath` methodeileencodes2015-03-202-32/+0
| | | | | | | | | | | Removing `#build_original_fullpath` because it is no longer used by the Rails' source code or called in the `#call` method becasue the previous commit now uses `fullpath` from Rack. The method was nodoc'ed so it's safe to remove. NOTE: I did this as a separate commit so if this does cause a problem with engines etc reverting is easy.
* Use fullpath from Rack request rather than building iteileencodes2015-03-201-11/+5
| | | | | | | | | | | | | | | | | | | | In Rack, `#fullpath` checks if there is a query string and builds the query correctly: ``` def path script_name + path_info end def fullpath query_string.empty? ? path : "#{path}?#{query_string}" end ``` We can utilize this instead of manually building the fullpath because they are the same result. This also reduces allocations in `#call` because we don't need `build_original_fullpath` to create the paths and query strings. We don't need to build `fullpath` twice.
* Updated MySQL documentation link to MySQL latest version 5.6 everywhere [ci ↵amitkumarsuroliya2015-03-192-2/+2
| | | | skip]
* add changelog entry for removing the fallback to rack_envDamien Mathieu2015-03-191-0/+7
| | | | [ci skip]
* Merge pull request #19404 from dmathieu/remove_rack_envAaron Patterson2015-03-1911-79/+24
|\ | | | | Don't fallback to RACK_ENV when RAILS_ENV is not present
| * don't fallback to RACK_ENV when RAILS_ENV is not presentDamien Mathieu2015-03-1911-79/+24
| |
* | Use absolute path on find_method location for the runnerArthur Neves2015-03-192-5/+6
| |
* | Fix test rake when passing multiple argumentsArthur Neves2015-03-191-2/+2
| | | | | | | | bundle exec db:migrate rake was not working, with the new runner, before this commit
* | method_source needs to be a hard dependency on railtiesArthur Neves2015-03-193-11/+1
| |
* | Merge pull request #19216 from senny/bin_test_runnerYves Senn2015-03-1912-65/+408
|\ \ | | | | | | `bin/rails test` runner (rerun snippets, run tests by line, option documentation)
| * | run `test_test.rb` using the `bin/rails test`.Yves Senn2015-03-181-17/+1
| | |
| * | Use Rails::TestRunner on rake testArthur Neves2015-03-181-16/+17
| | |
| * | Fix reporter test and verbose modeArthur Neves2015-03-182-10/+8
| | |
| * | move `ENV["BACKTRACE"]` support into the TestRunner.Yves Senn2015-03-183-3/+12
| | |
| * | `-p`, `--pattern` to run tests using a pattern.Yves Senn2015-03-182-2/+5
| | |
| * | use `bin/rails t` runner in `test_runner_test.rb`.Yves Senn2015-03-183-30/+23
| | |
| * | Fix relative dir call on test runnerArthur Neves2015-03-182-15/+24
| | |
| * | Add tests for runner#test_files methodArthur Neves2015-03-182-7/+21
| | |
| * | Run multiple files on runnerArthur Neves2015-03-182-6/+21
| | |
| * | `-e` / `--environment` for the test runner.Yves Senn2015-03-183-2/+22
| | |
| * | move argument parsing into the `Runner`.Yves Senn2015-03-182-3/+6
| | |
| * | get rid of NAMED_PATTERNS in favor of running a whole directoryYves Senn2015-03-182-7/+12
| | |
| * | document running a test by line number.Yves Senn2015-03-181-0/+7
| | |
| * | pluralize rerun snippet heading.Yves Senn2015-03-181-1/+1
| | |
| * | add tests for our minitest reporter.Yves Senn2015-03-181-0/+76
| | |
| * | Show the right file when test raisesArthur Neves2015-03-182-4/+4
| | |
| * | Move minitest pluginArthur Neves2015-03-183-21/+20
| | | | | | | | | | | | | | | | | | | | | Minitest Rails plugin should be loaded on test_help, so we report errors even when not running from the runner. Also fix the backtrace
| * | Move some logic to runnerArthur Neves2015-03-182-13/+11
| | |
| * | Dont display Failed test if suite passedArthur Neves2015-03-181-0/+1
| | |
| * | Better file:line parsing and filter method by file tooArthur Neves2015-03-182-11/+45
| | |
| * | no need to escape the method in a regex wrap, minitest does that for usArthur Neves2015-03-181-1/+1
| | |
| * | If a nem given, use that name to filter the testArthur Neves2015-03-181-5/+1
| | |
| * | Add test run by line, and report error by lineArthur Neves2015-03-183-3/+62
| | |
| * | spike of a `OptionParser` backed test runner.Yves Senn2015-03-185-2/+121
| |/
* / Add a new-line to the end of route method generated code.Arthur Neves2015-03-184-3/+36
|/ | | | | | | | Fix regression on route method that was added by bac812a7ef2660a2fe2ab00822e5e66228379822. The regression was that when calling the `route` method, we were not appending a \n anymore. [fixes #19316]
* Fix deprecation warning in rails_info_controller testsSemyon Pupkov2015-03-171-8/+8
| | | | Use keyword arguments in request methods
* add mailer suffix to comments for email previewsyuuji.yaginuma2015-03-152-7/+7
|
* Merge pull request #19323 from naoty/rake_initializerRafael Mendonça França2015-03-133-0/+14
|\ | | | | Add `rake initializer`
| * Add `rake initializer`Naoto Kaneko2015-03-143-0/+14
| | | | | | | | | | This task prints out initializers for an application. It is useful to develop a rubygem which involves the initialization process.
* | Update sprockets links to point to rails orgJoshua Peek2015-03-133-3/+3
|/
* Use `def setup` instead of `setup do`eileencodes2015-03-121-2/+4
| | | | | `setup do` creates unnecessary allocations of proc objects in callbacks. This prevents that from happening and results in faster code.
* Revert "Merge pull request #15476 from JacobEvelyn/master"Jeremy Kemper2015-03-111-7/+0
| | | | | | | | | | | | | | | | This introduces undesirable `Rails.logger` formatters (such as the syslog formatter) onto a `Logger.new(STDERR)` for the console. The production logger may be going elsewhere than standard io, so we can't presume to reuse its formatter. With syslog, this causes missing newlines in the console, so irb prompts start at the end of the last log message. We can work to expose the console formatter in another way to address the original issue. This reverts commit 026ce5ddf11c4cda0aae7f33a9266e54117db318, reversing changes made to 6f0a69c5899ebdc892e2aa23e68e2604fa70fb73.
* Target Ruby 2.2.1 in gemspecsPeter Suschlik2015-03-091-1/+1
| | | | This is a follow-up to #19257
* Merge pull request #19221 from matthewd/random-testsMatthew Draper2015-03-061-5/+0
|\ | | | | Run all our tests in random order
| * Revert "Leave all our tests as order_dependent! for now"Matthew Draper2015-03-061-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2f52f969885b2834198de0045748436a4651a94e. Conflicts: actionmailer/test/abstract_unit.rb actionview/test/abstract_unit.rb activemodel/test/cases/helper.rb activerecord/test/cases/helper.rb activesupport/test/abstract_unit.rb railties/test/abstract_unit.rb
* | pass a config to the route setAaron Patterson2015-03-052-1/+14
|/ | | | | This way we can get the relative_url_root from the application without setting another global value
* Revert work arounds for upstream Ruby 2.2.0 kwargs bugGenadi Samokovarov2015-03-051-3/+3
| | | | | | | | | | | | | | | | | | | The bug caused a segfault and you can find more info about it at: https://bugs.ruby-lang.org/issues/10685. We did a couple of work arounds, but 2.2.1 rolled out and those aren't needed anymore. Here are the reverted commits: - Revert "Work around for upstream Ruby bug #10685", commit 707a433870e9e06af688f85a4aedc64a90791a64. - Revert "Fix segmentation fault in ActionPack tests", commit 22e0a22d5f98e162290d9820891d8191e720ad3b. I'm also bumping the Ruby version check to 2.2.1 to prevent future segfaults.
* Some documentation edits [ci skip]Robin Dupret2015-03-051-3/+3
| | | | | | * Fix a few typos * Wrap some lines around 80 chars * Rephrase some statements
* ask the routes objects for its Rack env keyAaron Patterson2015-03-021-1/+1
| | | | | | this centralizes the logic for determining the script name key and drops object allocations when calling `engine_script_name` (which is called on each `url_for`).