Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Nobody sucks so nobody should call this awful method name | Rafael Mendonça França | 2014-08-12 | 1 | -1/+1 |
| | |||||
* | users_dont_suck_but_only_we_suck_and_only_our_tests_are_order_dependent! | Akira Matsuda | 2014-08-12 | 1 | -0/+4 |
| | | | | | Calling ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent! in AS::TestCase makes everyone's tests order dependent, which should never be done by the framework. | ||||
* | Revert "Merge pull request #16434 from strzalek/cookies-digest-config-option" | Santiago Pastorino | 2014-08-08 | 2 | -8/+1 |
| | | | | | | | This reverts commit 705977620539e2be6548027042f33175ebdc2505, reversing changes made to dde91e9bf5ab246f0f684b40288b272f4ba9a699. IT BROKE THE BUILD!!! | ||||
* | Merge pull request #16434 from strzalek/cookies-digest-config-option | Santiago Pastorino | 2014-08-08 | 2 | -1/+8 |
|\ | | | | | Add digest config option for SignedCookiesJar | ||||
| * | Return preconfigured AS::MessageVerifier | Łukasz Strzałkowski | 2014-08-08 | 2 | -1/+7 |
| | | |||||
| * | Add config option for cookies digest | Łukasz Strzałkowski | 2014-08-08 | 1 | -0/+1 |
| | | | | | | | | | | | | You can now configure custom digest for cookies in the same way as `serializer`: config.action_dispatch.cookies_digest = \SHA256' | ||||
* | | save a hash allocation per request. | Aaron Patterson | 2014-08-08 | 1 | -1/+1 |
| | | |||||
* | | add a test for prepending SCRIPT_NAME to generated urls | Aaron Patterson | 2014-08-08 | 1 | -0/+88 |
| | | |||||
* | | Fixes test for Gemfile entry changes | Arun Agrawal | 2014-08-08 | 3 | -8/+13 |
|/ | | | | Broken by fbe38c9e9d4fe9f82518e8ffc1d757459b0c5f1c | ||||
* | Pull spring gem entry into the Gemfile template instead of gemfile_entries ↵ | David Heinemeier Hansson | 2014-08-07 | 2 | -10/+12 |
| | | | | so it can be grouped with the other development tools | ||||
* | Merge branch 'master' of github.com:rails/rails | David Heinemeier Hansson | 2014-08-07 | 9 | -16/+178 |
|\ | |||||
| * | need to call super | Aaron Patterson | 2014-08-07 | 1 | -0/+1 |
| | | |||||
| * | add a new constructor that runs load hooks | Aaron Patterson | 2014-08-07 | 2 | -5/+9 |
| | | |||||
| * | defer running after_config hooks until after the object is allocated | Aaron Patterson | 2014-08-07 | 1 | -7/+22 |
| | | |||||
| * | lazily instantiate application subclasses | Aaron Patterson | 2014-08-06 | 3 | -4/+18 |
| | | | | | | | | this means we can meaningfully override methods in the subclass | ||||
| * | Merge pull request #16359 from skanev/after-bundle-in-rails-templates | Yves Senn | 2014-08-06 | 4 | -0/+39 |
| |\ | | | | | | | | | | | | | | | | | | | Add an after_bundle callback in Rails templates Conflicts: railties/CHANGELOG.md | ||||
| | * | Add an after_bundle callback in Rails templates | Stefan Kanev | 2014-08-03 | 4 | -0/+39 |
| | | | | | | | | | | | | | | | | | | The template runs before the generation of binstubs – this does not allow to write one, that makes an initial commit to version control. It is solvable by adding an after_bundle callback. | ||||
| * | | Revert "Revert "Merge pull request #15394 from ↵ | Yves Senn | 2014-08-06 | 1 | -1/+90 |
| | | | | | | | | | | | | | | | | | | morgoth/fix-automatic-maintaining-test-schema-for-sql-format"" This reverts commit 5c87b5c5248154cf8aa76cce9a24a88769de022d. | ||||
* | | | Stop using padding in the generated Gemfile -- it looks shit | David Heinemeier Hansson | 2014-08-07 | 2 | -6/+1 |
|/ / | |||||
* | | We don't need parenthesis for this | Guillermo Iguaran | 2014-08-05 | 1 | -1/+1 |
| | | |||||
* | | Fix digest ETAG test. | Arthur Neves | 2014-08-05 | 1 | -1/+1 |
| | | | | | | | | | | | | After https://github.com/rack/rack/commit/12528d4567d8e6c1c7e9422fee6cd8b43c4389bf ETag will include a `W/` before the digest. | ||||
* | | Bring back the helpers tests | José Valim | 2014-08-05 | 3 | -0/+50 |
| | | | | | | | | | | Also keep the hook as other tools may rely on it, we just don't do anything by default on Rails. | ||||
* | | Fix typo [ci skip] | Jon Atack | 2014-08-04 | 1 | -1/+1 |
| | | |||||
* | | Explain why we use asset digests, not what a setter does | David Heinemeier Hansson | 2014-08-03 | 2 | -2/+4 |
| | | |||||
* | | Add suggestion as to how you can app the the assets load path | David Heinemeier Hansson | 2014-08-03 | 1 | -0/+3 |
| | | |||||
* | | Pull in the custom configuration concept from dhh/custom_configuration | David Heinemeier Hansson | 2014-08-03 | 4 | -1/+82 |
| | | |||||
* | | A few more tests asserting the presence of helper test stubs | David Heinemeier Hansson | 2014-08-03 | 6 | -17/+0 |
| | | |||||
* | | Stubs are no longer generated for helpers, so dont test for it | David Heinemeier Hansson | 2014-08-03 | 1 | -4/+0 |
| | | |||||
* | | Change the production log level default from :info to :debug. All production ↵ | David Heinemeier Hansson | 2014-08-03 | 1 | -2/+2 |
| | | | | | | | | apps I have ever worked with has done this. Let us reflect that default. You often want those SQL quieries to be able to debug issues in production | ||||
* | | Generating stubs for helper tests is overly specific. Most helpers should ↵ | David Heinemeier Hansson | 2014-08-03 | 4 | -75/+0 |
|/ | | | | simply be tested as part of the view thats using them. If you need something beyond that, you can add a test yourself for them | ||||
* | Avoid defining the test if it does not need to when not on JRuby | Carlos Antonio da Silva | 2014-07-30 | 1 | -2/+2 |
| | |||||
* | Use default argument when testing generators without the need for extra args | Carlos Antonio da Silva | 2014-07-30 | 2 | -7/+7 |
| | |||||
* | Simplify path setup | Carlos Antonio da Silva | 2014-07-30 | 1 | -1/+1 |
| | |||||
* | Simplify plugin tests a bit, leave the regexp work for minitest | Carlos Antonio da Silva | 2014-07-30 | 1 | -6/+6 |
| | |||||
* | Invert unless..else conditions on JRuby checks | Carlos Antonio da Silva | 2014-07-30 | 2 | -12/+12 |
| | |||||
* | Remove some more globals from tests | Carlos Antonio da Silva | 2014-07-30 | 1 | -26/+26 |
| | | | | | We are using blocks here so we have access to the environment around them, no need for globals. | ||||
* | Fix / improve some assertions | Carlos Antonio da Silva | 2014-07-30 | 1 | -6/+4 |
| | |||||
* | Remove some globals from configuration tests | Carlos Antonio da Silva | 2014-07-30 | 1 | -20/+20 |
| | |||||
* | Deprecate `*_path` methods in mailers | @schneems and @sgrif | 2014-07-30 | 3 | -3/+55 |
| | | | | | | | | | | | Email does not support relative links since there is no implicit host. Therefore all links inside of emails must be fully qualified URLs. All path helpers are now deprecated. When removed, the error will give early indication to developers to use `*_url` methods instead. Currently if a developer uses a `*_path` helper, their tests and `mail_view` will not catch the mistake. The only way to see the error is by sending emails in production. Preventing sending out emails with non-working path's is the desired end goal of this PR. Currently path helpers are mixed-in to controllers (the ActionMailer::Base acts as a controller). All `*_url` and `*_path` helpers are made available through the same module. This PR separates this behavior into two modules so we can extend the `*_path` methods to add a Deprecation to them. Once deprecated we can use this same area to raise a NoMethodError and add an informative message directing the developer to use `*_url` instead. The module with warnings is only mixed in when a controller returns false from the newly added `supports_relative_path?`. Paired @sgrif & @schneems | ||||
* | Revert "Merge pull request #15305 from tgxworld/remove_unnecessary_require" | Santiago Pastorino | 2014-07-30 | 2 | -2/+2 |
| | | | | | | | This reverts commit f632f79b8dcd144408c66a544984b2ba9cf52f87, reversing changes made to 98c7fe87690ca4de6c46e8f69806e82e3f8af42d. Closes #16343 | ||||
* | Merge pull request #16328 from noinkling/template_password_confirmation_fix | Yves Senn | 2014-07-29 | 2 | -1/+6 |
|\ | | | | | | | Give password_confirmation div the "field" class in the scaffold generator "_form" partial | ||||
| * | Give password_confirmation div the "field" class in erb form template | noinkling | 2014-07-29 | 1 | -1/+1 |
|/ | |||||
* | Additional clarification on password:digest in scaffold and model generator ↵ | noinkling | 2014-07-25 | 2 | -4/+16 |
| | | | | help [ci skip] | ||||
* | Add password:digest information to scaffold generator help text [ci skip] | noinkling | 2014-07-25 | 1 | -1/+5 |
| | |||||
* | Remove mocha usage | Rafael Mendonça França | 2014-07-23 | 1 | -2/+5 |
| | |||||
* | Fix syntax error | Rafael Mendonça França | 2014-07-23 | 1 | -1/+2 |
| | |||||
* | Dev and edge application and plugins need to include i18n master | Rafael Mendonça França | 2014-07-23 | 1 | -1/+2 |
| | |||||
* | Merge pull request #16267 from robin850/rbx-yaml | Rafael Mendonça França | 2014-07-23 | 2 | -0/+22 |
|\ | | | | | Set Psych as the YAML engine for Rubinius | ||||
| * | Set Psych as the YAML engine for Rubinius | Robin Dupret | 2014-07-23 | 2 | -0/+22 |
| | | | | | | | | | | | | | | | | | | | | Since the rubysl-yaml gem doesn't ship with Psych by default because of its dependency on libyaml, on Rubinius, the default engine is Syck. However, if we want to be able to run the application safely on different rubies, we need to make people using Rubinius rely on Psych. See http://git.io/uuLVag for further information. | ||||
* | | Do not set enforce_available_locales to i18n 0.7 | Rafael Mendonça França | 2014-07-23 | 1 | -18/+2 |
|/ | | | | | | Now the default is always true. Users still can set it using config.i18n.enforce_available_locales. |