| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
This reverts commit 304f4d4c25ccabdbf97d37dd7a92a54d0b63a9c9.
As it turns out everything should behave as it did and we don't
need to move this configuration option.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When we removed script/rails and introduced bin/rails, we accidentally
introduced a regression. If you install Rails 4 as a gem, then try to do
something in a Rails 3 application:
$ rails g
This will throw the 'please type rails new foo' message rather than the
proper generator documentation message. This is because older apps don't
have bin/rails.
Therefore, we now *prefer* bin/rails, but still search for script/rails,
and exec the one we find.
|
|
|
| |
Better comment for database_configuration method
|
|
|
| |
Changed comment that referenced the property #database_configuration_file, now it's paths["config/database"]
|
| |
|
|\
| |
| | |
move config.assets.precompile into config/application.rb
|
| | |
|
| | |
|
| | |
|
| | |
|
|/
|
|
|
|
|
| |
make connection_url_to_hash a class method
This als prevents loading database.yml if it doesn't exist
but DATABASE_URL does
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Most application developers shouldn't be adding paths to
`config.autoload_paths` as it won't be eagerly loaded so
remove it from the generated config/application.rb file.
If a developer does want to autoload from paths outside of the app
directory then they should add the path to `config.eager_load_paths`
as these paths are also autoloaded as well.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Whilst autoloading is known to be not threadsafe, leaving it in place
is a softer solution than failing hard when an application is deployed.
Many older applications will have paths added to `autoload_paths` and
ideally these should be eagerly loaded to be threadsafe. However one
of these paths is quite often lib which could lead to unintended
consequences due to the 'junk drawer' nature of this directory.
Developers should refrain from adding paths to `autoload_paths` or
`eager_load_paths` and use custom folders inside app for code that
needs to be eagerly loaded and use `require` or `require_dependency`
to explicitly load code from other locations.
|
|
|
|
|
|
|
|
|
|
|
| |
Because of the possibility of lib being unintentionally eager loaded
it's been agreed that we'll leave autoload paths and eager load paths
separate for Rails 4.0.
This reverts commit 0757b3388ffe4f44b60de950d40e18ef05055931.
Conflicts:
railties/CHANGELOG.md
|
| |
|
|
|
|
| |
Thanks @sikachu. :sweat_smile:
|
|
|
|
|
|
| |
Print a message in both `rake routes` and at GET "/rails/info/routes"
that lets you know you have no routes defined, as well as linking to the
Rails Guide on the topic.
|
|
|
|
| |
see: https://github.com/blog/1406-namespaced-gists
|
|
|
|
|
|
| |
User should know that he can overwrite the previous migration. This
comes in handy especially when generating models which were previously
created then removed.
|
|
|
|
| |
Add test:all and test:all:db rake tests to speed up full test runs.
|
| |
|
| |
|
|
|
|
| |
Use 'some' instead of 'a/an'.
|
|
|
|
|
|
|
|
|
|
| |
Speed up depends on the number of test phases (N) you have for your
app, but it is roughly a 1/N improvement. In my app, it goes from
15.51s to 5.56s.
Inspired by http://ngauthier.com/2012/02/quick-tests-with-bash.html
Reviewed by @tenderlove
|
|\
| |
| | |
Add --rc description on the command line
|
| | |
|
|/ |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
so that the tester's local .railsrc file does not affect the test results
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| | |
Fixes improper database name when creating a new rails app with a '.'
Conflicts:
railties/CHANGELOG.md
|
| |
| |
| |
| |
| |
| | |
application. EG: `rails new something.awesome.com`
Conflicts:
railties/CHANGELOG.md
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Since the default in Rails 4.0 is to run in 'threadsafe' mode we need
to eager load all of the paths in `autoload_paths` so we alias
`eager_load_paths` to it. This may have unintended consequences if
you have added 'lib' to `autoload_paths` such as loading unneeded
code or code intended only for development and/or test environments.
If this applies to your application you should thoroughly check what
is being eager loaded.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 43e14f8ff203c21646f733d35bdde4e68da70a3b, reversing
changes made to bb17a0f085aba40a1952612f6c98b2a5804a1152.
Conflicts:
railties/lib/rails/generators/rails/app/templates/config/application.rb
railties/lib/rails/generators/rails/app/templates/config/initializers/locale.rb
Reason: setting the Time.zone in an after_initialize block can become a
problem for people upgrading, since it's not going to be available when
config/initializers run, and people might be relying on it.
An example that I noticed was with the Chronic gem, for date/time parsing.
It requires us to configure the time class to be Time.zone, and doing
that in an initializer no longer worked with these changes, so reverting
is the safer path for now.
|
| |
| |
| |
| |
| |
| | |
configuration"
This reverts commit 39374aa925a7d670b039c0c0c9aa9f4aef19466b.
|
| |
| |
| |
| | |
`require 'rubygems'` is already required in Ruby 1.9 or later.
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Adding Back Rails::Engine::Railties#engines
Conflicts:
railties/CHANGELOG.md
|
| | |
| | |
| | |
| | |
| | | |
Removing it breaks functionality with gems such as Thinking Sphinx.
This restores it with a deprecation warning. Closes #8551
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Historically serving assets from a mountable engine could be achieved by
running ActionDispatch::Static as a part of engine middleware stack or
to copy assets prefixed with an engine name. After introduction of
assets pipeline this is not needed as all of the assets are served or
compiled into main application's assets.
This commit removes the obsolete line making asset_path always generate
paths relative to the root or config.relative_url_root if it's set.
(closes #8119)
|
| | |
| | |
| | |
| | |
| | |
| | | |
https://github.com/rails/rails/commit/cc1c3c5be061e7572018f734e5239750ab449e3f
Now instead of raise, we log by default in development and test
|
| | | |
|
| | | |
|