aboutsummaryrefslogtreecommitdiffstats
path: root/railties
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | | Make app building threadsafeeileencodes2015-09-291-4/+8
| | | | | | | |
* | | | | | | | Stop modifying global variableseileencodes2015-09-293-8/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allocating a new middleware proxy in each application configuration and then merging the app specific config with the global config when the app is built.
* | | | | | | | Add fail fast to test runner.Kasper Timm Hansen2015-09-295-0/+84
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Passing `--fail-fast` to the test runner will now abort the test run on the first failure. The run continues on any unexpected errors.
* | | | | | | | Add inline failure reporting to test runner.Kasper Timm Hansen2015-09-285-6/+113
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Any failures or errors will be reported inline during the run by default. Skipped tests will be reported if run in verbose mode. Any result is output with failure messages and a rerun snippet for that test. Rerun snippets won't be output after a run, unless `--defer-output` is passed.
* | | | | | | Merge pull request #21789 from y-yagi/fix_warning_in_minitest_pluginKasper Timm Hansen2015-09-281-1/+2
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | check if @rake_patterns is defined
| * | | | | | | check if @rake_patterns is definedyuuji.yaginuma2015-09-281-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This removes the following warning. ``` railties/lib/rails/test_unit/minitest_plugin.rb:45: warning: instance variable @rake_patterns not initialize ```
* | | | | | | | Fix test that was failing because of typoeileencodes2015-09-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Here `app` needed to be `get` because we're getting a route. This fixes the typo so the test passes.
* | | | | | | | Add missing routing tests for info controllerAditya Kapoor2015-09-271-0/+12
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Vaguely related to #21605 where I proposed to remove index route since it was redirecting to the 'routes' action, but this was kept so I thought it made sense to add some tests regarding this.
* | | | | | | Fix typo in configuration test descritive > descriptive [ci skip]amitkumarsuroliya2015-09-261-1/+1
| | | | | | |
* | | | | | | make sure flash middleware is requiredAaron Patterson2015-09-251-0/+1
| | | | | | |
* | | | | | | Removed Mocha from app generators testsRonak Jangir2015-09-231-87/+106
| | | | | | |
* | | | | | | stop using deprecated method in mailers controlleryuuji.yaginuma2015-09-232-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Accessing mime types via constants is deprecated.
* | | | | | | Remove unneeded generator variable.Kasper Timm Hansen2015-09-221-1/+0
| | | | | | |
* | | | | | | Removed mocha from Railites PluginGeneratorTestRonak Jangir2015-09-222-15/+35
| | | | | | |
* | | | | | | fix application_controller require_dependency path generated by the scaffold ↵yuuji.yaginuma2015-09-202-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | generator This is follow up to #6643. In #6643, the controller generator only had been fixed, in this commit to fix the scaffold generator.
* | | | | | | mostly remove the ParamsParser middlewareAaron Patterson2015-09-182-3/+0
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | This can still be added to the middleware stack, but is really not necessary. I'll follow up with a commit that deprecates the constant
* | | | | | File encoding is defaulted to utf-8 in Ruby >= 2.1Akira Matsuda2015-09-181-1/+0
| | | | | |
* | | | | | Fix displaying mailer previews on non local requests.Wojciech Wnętrzak2015-09-173-2/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When config `action_mailer.show_previews` is set, previews are displayed regardless of local request check.
* | | | | | Bundler tzinfo-data in windows, even first generated new app are MacEric Guo2015-09-151-2/+0
| | | | | |
* | | | | | Merge pull request #21568 from amitsuroliya/mysql_version_updateRafael Mendonça França2015-09-132-2/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Updated MySQL documentation link to MySQL latest version 5.7 everywhe…
| * | | | | | Updated MySQL documentation link to MySQL latest version 5.7 everywhere [ci ↵amitkumarsuroliya2015-09-102-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | skip] Bumps from `5.6` to `5.7`
* | | | | | | dev and edge have some common, so factor it out.Eric Guo2015-09-131-10/+7
|/ / / / / /
* | | | | | Replace AR with ActiveRecord to make it more readable [ci skip]arvind2015-09-081-1/+1
| | | | | |
* | | | | | Merge pull request #21519 from y-yagi/test_runner_raise_errorKasper Timm Hansen2015-09-084-7/+21
|\ \ \ \ \ \ | | | | | | | | | | | | | | raise LoadError when a non-existent file or directory is specified to the test runner
| * | | | | | modify to pass the correct argument to the test runner from rakeyuuji.yaginuma2015-09-082-6/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | test runner sets file to be tested in plugin_rails_options, but in plugin_rails_options, processing has been made to the argument of the actual command rather than the argument of Minitest.run. For example, if you run `./bin rake db:migrate test`, the options[:patterns], `db:migrate test` was incorrectly set.
| * | | | | | raise LoadError when a non-existent file or directory is specified to the ↵yuuji.yaginuma2015-09-072-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | test runner Currently, if a file or directory that does not exist was specified in the test runner, that argument is ignored. This commit has been modified to cause an error if there is no file or directory.
* | | | | | | Fix strange messages for `rails g foo`FUJI Goro (gfx)2015-09-071-1/+1
|/ / / / / /
* | | | | | Include MIT-LICENSE in railties gemBrandon Keepers2015-09-011-1/+1
| | | | | |
* | | | | | make `ENV` a required argumentyuuji.yaginuma2015-08-291-1/+1
| | | | | |
* | | | | | Disable warnings in railties testsRafael Mendonça França2015-08-271-1/+1
| | | | | |
* | | | | | Merge pull request #21392 from y-yagi/rm_require_support_filesYves Senn2015-08-271-3/+0
|\ \ \ \ \ \ | | | | | | | | | | | | | | remove require of files under support that do not use
| * | | | | | remove require of files under support that do not useyuuji.yaginuma2015-08-271-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I do not know why files under the support has been require. However, under the support even rails application does not use. In addition, since the default under the support file nor is generated, it requires I think not necessary
* | | | | | | Removed duplicate requiring minitest/mock as it is already required in ↵Ronak Jangir2015-08-261-1/+0
|/ / / / / / | | | | | | | | | | | | | | | | | | method_call_assertions
* | | | | | remove unused require ‘set’NehaGautam2015-08-251-1/+0
| | | | | |
* | | | | | override `controller_class` on the requestAaron Patterson2015-08-241-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Just like the other places. We need to refactor this because the code is almost identical to that in the action pack tests
* | | | | | Merge pull request #21267 from davidcornu/rails-server-port-env-varRafael Mendonça França2015-08-243-1/+12
|\ \ \ \ \ \ | | | | | | | | | | | | | | Use the PORT environment variable for rails server
| * | | | | | Use the PORT environment variable for rails serverDavid Cornu2015-08-183-1/+12
| | | | | | |
* | | | | | | smooth move aaron.... :bomb:Aaron Patterson2015-08-201-2/+2
| | | | | | |
* | | | | | | point at rack masterAaron Patterson2015-08-201-0/+2
| | | | | | |
* | | | | | | fix path of annotations.rake [ci skip]yuuji.yaginuma2015-08-201-1/+1
| | | | | | |
* | | | | | | Merge pull request #21279 from ronakjangir47/test_cleanupKasper Timm Hansen2015-08-203-43/+20
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Cleaned up generators tests using internal assertion helper
| * | | | | | | Cleaned up generators tests using internal assertion helperRonak Jangir2015-08-203-43/+20
| |/ / / / / /
* / / / / / / Migrate to Sprockets 4.Andrei Istratii2015-08-197-18/+59
|/ / / / / /
* | | | | | Fixed syslog example in production config templateprintercu2015-08-171-1/+2
| | | | | |
* | | | | | Updated tests for the generated version number changeDaniel Morris2015-08-161-3/+3
| | | | | |
* | | | | | Plugins are generated with the version 0.1.0Daniel Morris2015-08-162-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The semantic versioning specification uses MAJOR.MINOR.PATCH – it would make more sense to set the version to 0.1.0 for initial development since a patch release cannot be created before a minor feature release.
* | | | | | Add a changelog entry for #21124 [ci skip]Robin Dupret2015-08-161-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | [Kir Shatrov & Robin Dupret]
* | | | | | Tiny documentation fixes [ci skip]Robin Dupret2015-08-161-4/+2
| |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | * Add missing `def` and remove useless `do` keywords. * Move `:nodoc:` in front of the methods' definition so that methods under these ones are correctly visible on the API.
* | | | | Merge pull request #21021 from sgrif/sg-no-routes-commentSean Griffin2015-08-121-54/+1
|\ \ \ \ \ | | | | | | | | | | | | Replace the giant comment in routes.rb with a link to the guides
| * | | | | Replace the giant comment in routes.rb with a link to the guidesSean Griffin2015-07-241-54/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This comment not only serves no purpose, but in my experience is actively detrimental to new developers getting started with Rails. Expereinced developers just end up deleting this comment, and are annoyed that they had to take this step. I also spend a lot of time mentoring brand new developers, and a consistent theme I've seen is that this comment just ends up intimidating them, and making them think it's dangerous to edit this file. One of my students just said this (due to the number of comments which even new developers don't actually read, they just see it as a sign that this thing is "dangerous"). > I don't edit any file that Rails generates for me, until my instructor > says that it's OK to do so. Realistically, this comment adds 0 value. We have very good documentation, which we can just link to instead. If someone is truly new enough to benefit from this info, they presumably just ran `gem install rails`, and have an internet connection that they can use to read the routing guide. The choice of language here was very specific. I chose "the DSL available" over "what is possible", because a consistent theme I've noticed among my students is that they aren't aware that this is actually a Ruby file, and can write any Ruby code here that they want. This file is not the only offender, but is by far the biggest point of pain that I've seen, and felt it was a good spot to open this discussion.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-05 19:51:28 +0000