| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Use RESTful instead of restful
|
| | |
|
| |
| |
| |
| | |
Follow up of #30650
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
According to #30067:
> This PR will deprecate secrets.yml* and instead adopt
> config/credentials.yml.enc to signify what these secrets are specifically
> for: Keeping API keys, database passwords, and any other integration
> credentials in one place.
[ci skip] since only comments are being edited.
|
|/ |
|
|
|
|
|
|
| |
* If we want to transform image on ActiveStorage, we should bundle
`mini_magick`.
* I've added comment block to default `Gemfile` to be easier to install this.
|
|\
| |
| | |
Add tests for credentials command
|
| | |
|
|\ \
| | |
| | |
| | |
| | | |
y-yagi/remove_frozen_string_literal_from_templates
Remove frozen_string_literal magic comment from templates
|
| |/
| |
| |
| | |
Follow up of #30348
|
|/
|
|
|
|
|
| |
These routes are only used internally in Active Storage, and it seems
that there is no need for the user to directly use them.
Therefore, I think that routes should not be exposed to users.
|
| |
|
|\
| |
| | |
Do not add master key and credentials when `pretend` option is specified
|
| | |
|
|\ \
| | |
| | | |
Make master key added to gitignore the same value as when creating appplication
|
| |/
| |
| |
| |
| |
| |
| |
| |
| | |
For gitignore generated by `rails new`, key with a leading slash is specified.
https://github.com/rails/rails/blob/69f976b859cae7f9d050152103da018b7f5dda6d/railties/lib/rails/generators/rails/app/templates/gitignore#L11
Therefore, when executing `credentials:edit`, also need leading slack.
In order to avoid such a difference, fixed to use same method for
`rails new` and `credentials:edit`.
|
| |
| |
| |
| |
| |
| |
| | |
Removes most mentions of secrets.secret_key_base and explains
credentials instead.
Also removes some very stale upgrade notices about Rails 3/4.
|
|/ |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* WIP: Add credentials using a generic EncryptedConfiguration class
This is sketch code so far.
* Flesh out EncryptedConfiguration and test it
* Better name
* Add command and generator for credentials
* Use the Pathnames
* Extract EncryptedFile from EncryptedConfiguration and add serializers
* Test EncryptedFile
* Extract serializer validation
* Stress the point about losing comments
* Allow encrypted configuration to be read without parsing for display
* Use credentials by default and base them on the master key
* Derive secret_key_base in test/dev, source it from credentials in other envs
And document the usage.
* Document the new credentials setup
* Stop generating the secrets.yml file now that we have credentials
* Document what we should have instead
Still need to make it happen, tho.
* [ci skip] Keep wording to `key base`; prefer defaults.
Usually we say we change defaults, not "spec" out a release.
Can't use backticks in our sdoc generated documentation either.
* Abstract away OpenSSL; prefer MessageEncryptor.
* Spare needless new when raising.
* Encrypted file test shouldn't depend on subclass.
* [ci skip] Some woordings.
* Ditch serializer future coding.
* I said flip it. Flip it good.
* [ci skip] Move require_master_key to the real production.rb.
* Add require_master_key to abort the boot process.
In case the master key is required in a certain environment
we should inspect that the key is there and abort if it isn't.
* Print missing key message and exit immediately.
Spares us a lengthy backtrace and prevents further execution.
I've verified the behavior in a test app, but couldn't figure the
test out as loading the app just exits immediately with:
```
/Users/kasperhansen/Documents/code/rails/activesupport/lib/active_support/testing/isolation.rb:23:in `load': marshal data too short (ArgumentError)
from /Users/kasperhansen/Documents/code/rails/activesupport/lib/active_support/testing/isolation.rb:23:in `run'
from /Users/kasperhansen/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/minitest-5.10.2/lib/minitest.rb:830:in `run_one_method'
from /Users/kasperhansen/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/minitest-5.10.2/lib/minitest/parallel.rb:32:in `block (2 levels) in start'
```
It's likely we need to capture and prevent the exit somehow.
Kernel.stub(:exit) didn't work. Leaving it for tomorrow.
* Fix require_master_key config test.
Loading the app would trigger the `exit 1` per require_master_key's
semantics, which then aborted the test.
Fork and wait for the child process to finish, then inspect the
exit status.
Also check we aborted because of a missing master key, so something
else didn't just abort the boot.
Much <3 to @tenderlove for the tip.
* Support reading/writing configs via methods.
* Skip needless deep symbolizing.
* Remove save; test config reader elsewhere.
* Move secret_key_base check to when we're reading it.
Otherwise we'll abort too soon since we don't assign the secret_key_base
to secrets anymore.
* Add missing string literal comments; require unneeded yaml require.
* ya ya ya, rubocop.
* Add master_key/credentials after bundle.
Then we can reuse the existing message on `rails new bc4`.
It'll look like:
```
Using web-console 3.5.1 from https://github.com/rails/web-console.git (at master@ce985eb)
Using rails 5.2.0.alpha from source at `/Users/kasperhansen/Documents/code/rails`
Using sass-rails 5.0.6
Bundle complete! 16 Gemfile dependencies, 72 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
Adding config/master.key to store the master encryption key: 97070158c44b4675b876373a6bc9d5a0
Save this in a password manager your team can access.
If you lose the key, no one, including you, can access anything encrypted with it.
create config/master.key
```
And that'll be executed even if `--skip-bundle` was passed.
* Ensure test app has secret_key_base.
* Assign secret_key_base to app or omit.
* Merge noise
* Split options for dynamic delegation into its own method and use deep symbols to make it work
* Update error to point to credentials instead
* Appease Rubocop
* Validate secret_key_base when reading it.
Instead of relying on the validation in key_generator move that into
secret_key_base itself.
* Fix generator and secrets test.
Manually add config.read_encrypted_secrets since it's not there by default
anymore.
Move mentions of config/secrets.yml to config/credentials.yml.enc.
* Remove files I have no idea how they got here.
* [ci skip] swap secrets for credentials.
* [ci skip] And now, changelogs are coming.
|
|
|
|
| |
Since ff30db1, warning is not shown.
|
| |
|
|
|
|
|
|
|
|
| |
Currently, secrets test uses `abstract_unit` and `isolation/abstract_unit`.
This is a bit odd. Therefore, reorganize it so that use only
`isolation/abstract_unit`.
Context: https://github.com/rails/rails/pull/30520#issuecomment-327409586
|
|\
| |
| | |
Run in-app rails commands via fork+load where possible
|
| |
| |
| |
| |
| | |
While this avoids shell argument parsing, we still pass through
everything in our stack.
|
|/
|
|
|
|
|
|
|
|
|
| |
If the user used the `bin/test` to execute the test, this file is
automatically loaded, so require is unnecessary.
https://github.com/rails/rails/blob/acea68de026ba657cb65c4dd0fc1f24ba67e1cf8/railties/lib/rails/plugin/test.rb#L4
However, when using `rake test`, an explicit require is required because
the above file is not loaded.
Fixes #30516
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
This effectively reverts 200cf32e207728df287cac2ec113a7cbe277c1eb,
restoring a variant of 5a0e0e72995472e315738dcea5b5a12d6e3d3489.
|
|
|
|
| |
Since ff30db1, warning is not show.
|
|\
| |
| | |
Support multiple versions arguments for `gem` method of Generators
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Without this, `dbconsole` raises an error as follwing:
```
RuntimeError: can't modify frozen String
railties/lib/rails/commands/dbconsole/dbconsole_command.rb:79:in `start'
```
|
|\ \
| | |
| | |
| | |
| | | |
yhirano55/fix_indentation_in_secrets_yaml_template
Fix indentation in the template for secrets
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Since cb5af0d7, some classes that are under Active Storage are now
part of the API site.
However, these classes aren't nested under a definition of the
`ActiveStorage` module but rather name-spaced under it like
`ActiveStorage::Foo`.
Thus, these classes are present both under the ActiveStorage label
and at the root of the site's sidebar so we have to strip out
duplicates.
[ci skip]
|
| | | |
|
|\ \ \
| | | |
| | | | |
Use REDIS_URL var for Action Cable config template
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
Fix spaces in the comment block [ci skip]
|
| |/ / |
|
|\ \ \
| | | |
| | | | |
Remove frozen_string_literal magic comment from templates
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
Update MIT licenses link [ci skip]
|
| |/ / |
|
|/ / |
|
|\ \
| | |
| | | |
Make `restart` and `dev:cache` tasks work when customizing pid file path
|