aboutsummaryrefslogtreecommitdiffstats
path: root/railties
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Find query_source_location using lazy EnumeratorJohn Hawthorn2019-04-151-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | This way, we only need to filter the backtrace up to the first non-noise stack frame. This also updates noise to be able to deal with being passed a lazy enum. We don't need this anywhere, but it seemed better for this to be consistent.
* | | Merge pull request #35977 from prathamesh-sonpatki/rm-required-in-generatorsRafael França2019-04-151-13/+2
|\ \ \ | | | | | | | | Remove `required: true` from the model generator template
| * | | Remove `required: true` from the model generator templatePrathamesh Sonpatki2019-04-151-13/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `belongs_to` association have `required: true` by default https://github.com/rails/rails/pull/18937 onwards so we don't need it in the generator template. We still need the code for required in the command line generator as it adds `null: false` in the migration.
* | | | Merge pull request #35906 from yoones/notes-tags-registrationRafael França2019-04-153-2/+56
|\ \ \ \ | |/ / / |/| | | Notes tags registration
| * | | Adds `register_tags`Younes SERRAJ2019-04-123-2/+56
| | | |
* | | | Correctly set application path in ↵yuuji.yaginuma2019-04-151-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | `test_app_update_does_not_change_config_target_version` This is the follow up of 10fa3b3792153c2a213f837bcf51bbf6844c1661.
* | | | Make test application the same state as `app:update`yuuji.yaginuma2019-04-151-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In `app:update`, it is decided whether to skip depending on whether `Spring` is defined or not. However, `spring` is not currently specified in Gemfile. As a result, `app:update` determines that `Spring` is not used, and diff appears in the result file. If there is a difference, the console for processing the difference is output and the test stops. To avoid this, do not include `Spring` in app. This is a bit strange approach, so I will revisit this later.
* | | | Merge pull request #35967 from ↵Yuji Yaginuma2019-04-151-49/+60
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | ryohashimoto/do_not_app_update_in_app_generator_test Do not execute `rails app:update` in railties/test/generators/app_generator_test.rb
| * | | | use Rails::Generators::AppGenerator#update_config_files instead of `rails ↵Ryo Hashimoto2019-04-131-49/+60
| | | | | | | | | | | | | | | | | | | | app:update` in app_generator_test.rb
* | | | | Fix broken `AppGeneratorTest#test_spring_no_fork`yuuji.yaginuma2019-04-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | The mock is called three times because the `spring_install?` call has been added in 65344f254cde87950c7f176cb7aa09c002a6f882.
* | | | | generate config.cache_classes = false if SpringXavier Noria2019-04-143-5/+21
| | | | |
* | | | | Remove the Amazon SES ingressGeorge Claghorn2019-04-142-26/+18
| | | | | | | | | | | | | | | It's unusable and not ready to ship in Rails 6.0. We'll rewrite it for 6.1.
* | | | | deprecates autoloading constants during initialization [closes #35745]Xavier Noria2019-04-143-0/+96
|/ / / / | | | | | | | | | | | | See rationale in the warning message included in the patch.
* | | | Do not treat `environment_desc` as commandsyuuji.yaginuma2019-04-131-1/+3
| | | | | | | | | | | | | | | | For avoid to show `environment_desc` in help.
* | | | improves the reloading disabled error messageXavier Noria2019-04-111-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The original message from Zeitwerk is "can't reload, please call loader.enable_reloading before setup (Zeitwerk::Error)", which is not very informative for Rails programmers. Rails should err with a message worded in terms of its interface.
* | | | Address new cop offence in railtiesRyuta Kamizono2019-04-121-1/+1
| | | | | | | | | | | | | | | | | | | | It is necessary to run `rubocop` manually when new cop is added since codeclimate checks any offences only in files touched in PRs.
* | | | Merge pull request #35916 from soartec-lab/delete_not_use_methodRyuta Kamizono2019-04-111-15/+0
|\ \ \ \ | |/ / / |/| | | Delete not user method for plugin_generator
| * | | Delete not user method for plugin_generatorsoartec-lab2019-04-091-15/+0
| | | |
* | | | Merge pull request #35905 from BatedUrGonnaDie/dont-override-job-seed-adapterRafael França2019-04-093-2/+25
|\ \ \ \ | |/ / / |/| | | Only override async adapter when seeding
| * | | Only override async adapter when seedingBatedUrGonnaDie2019-04-093-2/+25
| | | |
* | | | Better spread out the railties testsMatthew Draper2019-04-091-2/+39
| | | |
* | | | cleanup up constant in test suiteXavier Noria2019-04-091-0/+1
| | | |
* | | | depend on Zeitwerk 2.1.0Xavier Noria2019-04-091-9/+61
|/ / /
* / / depend on Zeitwerk 2Xavier Noria2019-04-072-1/+15
|/ /
* | Output junit format test reportFumiaki MATSUSHIMA2019-04-041-0/+2
| |
* | Remove redundant begin blockRyuta Kamizono2019-04-041-10/+9
| | | | | | | | | | We have `Style/RedundantBegin` cop (#34764) but it could not correct in this case.
* | Use `execute_batch2` rather than `execute_batch` to fix performance ↵Ryuta Kamizono2019-04-043-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | regression for fixture loading d8d6bd5 makes fixture loading to bulk statements by using `execute_batch` for sqlite3 adapter. But `execute_batch` is slower and it caused the performance regression for fixture loading. In sqlite3 1.4.0, it have new batch method `execute_batch2`. I've confirmed `execute_batch2` is extremely faster than `execute_batch`. So I think it is worth to upgrade sqlite3 to 1.4.0 to use that method. Before: ``` % ARCONN=sqlite3 bundle exec ruby -w -Itest test/cases/associations/eager_test.rb -n test_eager_loading_too_may_ids Using sqlite3 Run options: -n test_eager_loading_too_may_ids --seed 35790 # Running: . Finished in 202.437406s, 0.0049 runs/s, 0.0049 assertions/s. 1 runs, 1 assertions, 0 failures, 0 errors, 0 skips ARCONN=sqlite3 bundle exec ruby -w -Itest -n test_eager_loading_too_may_ids 142.57s user 60.83s system 98% cpu 3:27.08 total ``` After: ``` % ARCONN=sqlite3 bundle exec ruby -w -Itest test/cases/associations/eager_test.rb -n test_eager_loading_too_may_ids Using sqlite3 Run options: -n test_eager_loading_too_may_ids --seed 16649 # Running: . Finished in 8.471032s, 0.1180 runs/s, 0.1180 assertions/s. 1 runs, 1 assertions, 0 failures, 0 errors, 0 skips ARCONN=sqlite3 bundle exec ruby -w -Itest -n test_eager_loading_too_may_ids 10.71s user 1.36s system 95% cpu 12.672 total ```
* | Add test that the listen gem is included when RUBY_ENGINE is not 'ruby'Benoit Daloze2019-04-031-0/+16
| | | | | | | | | | * The fix is already in master since https://github.com/rails/rails/pull/34243 * See https://github.com/rails/rails/pull/35482 for the fix in Rails 5.2
* | Don't normalize `original_app_name`Ryuta Kamizono2019-04-031-2/+2
| | | | | | | | | | `original_app_name` is used to show error message if giving app name is invalid, it should be shown raw app name.
* | Auto-correct rubocop offencesRyuta Kamizono2019-04-031-2/+2
| |
* | Merge pull request #35805 from excid3/attachments-field-generatorsRafael França2019-04-0212-25/+124
|\ \ | | | | | | Add attachment and attachments field generators
| * | Add attachment and attachments field generatorsChris Oliver2019-03-3012-25/+124
| | |
* | | Merge pull request #35768 from robertomiranda/r/rake-db-prepareEileen M. Uchitelle2019-04-022-0/+36
|\ \ \ | | | | | | | | Add db:prepare rake task.
| * | | Add migration in case of db:drop assertionRoberto Miranda2019-04-021-0/+7
| | | |
| * | | 💇Roberto Miranda2019-04-022-2/+1
| | | |
| * | | Add test cases for rake db:prepareRoberto Miranda2019-04-022-0/+30
| | | |
* | | | Merge pull request #35703 from y-yagi/add_database_option_to_dbconsole_commandYuji Yaginuma2019-04-023-13/+42
|\ \ \ \ | | | | | | | | | | Rename `connection` option to `database` in `dbconsole` command
| * | | | Rename `connection` option to `database` in `dbconsole` commandyuuji.yaginuma2019-04-023-13/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We introduced `connection` option for specifying spec with 1acd9a6464668d4d54ab30d016829f60b70dbbeb. But now we are using the `database` to specify the same value in other commands. * https://github.com/rails/rails/blob/0a0f115031b64b5335fa88543c40df4194dfb428/activerecord/lib/rails/generators/active_record/migration/migration_generator.rb#L11 * https://github.com/rails/rails/blob/0a0f115031b64b5335fa88543c40df4194dfb428/activerecord/lib/rails/generators/active_record/model/model_generator.rb#L17 The options provided to the users should be uniform. Since the term "database" is used in rake task etc, So I want to be able to use it in `dbconsole` command. Also I deprecated the `connection` option because I think that it would be confusing if there are multiple options to specify a same value.
* | | | | [ci skip] Fix typo for recieve -> receiveAbhay Nikam2019-04-021-2/+2
|/ / / /
* | | | Add Changelog entry for #35732.Connor Shea2019-04-011-0/+6
| | | |
* | | | Merge pull request #35820 from sharang-d/url-to-URL-except-actionpackRyuta Kamizono2019-04-026-12/+12
|\ \ \ \ | | | | | | | | | | url -> URL where apt except inside actionpack/
| * | | | url -> URL where apt except inside actionpack/Sharang Dashputre2019-04-016-12/+12
| | | | |
* | | | | Include final newline in generated .ruby-versionOrhan Toy2019-04-012-1/+3
|/ / / /
* | | | Tweaks CHANGELOGs and docs [ci skip]Ryuta Kamizono2019-03-311-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | * add leading `#` before `=>` since hash rocket is valid Ruby code * add backticks * remove trailing spaces * and more
* | | | [ci skip] Fix typo directores -> directoriesAbhay Nikam2019-03-301-1/+1
| | | |
* | | | optimizes eager loading in :zeitwerk modeXavier Noria2019-03-302-22/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | During initialization, the eager load paths of engines are unshifted into AS::Dependencies.autoload_paths. After that, the collection is frozen. (See the initializers in railties/lib/rails/engine.rb.) Hence, there is no eager load path that is not an autoload path too, and so the array difference in the deleted code is always an empty array. Just do nothing.
* | | | fixes eager loading edge case in :zeitwerk modeXavier Noria2019-03-302-2/+33
| |/ / |/| |
* | | Add rich_text field to model generatorsChris Oliver2019-03-285-11/+73
|/ /
* | bumps Zeitwerk and BootsnapXavier Noria2019-03-262-1/+6
| |
* | Reword test names in credentials_test.rbSharang Dashputre2019-03-251-4/+4
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-19 14:11:45 +0000