| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This moves digest calculation cache on to the details key object.
Before, the digest cache was a class level ivar, and one of the keys was
the hash value of the details key object:
https://github.com/rails/rails/blob/13c4cc3b5aea02716b7459c0da641438077f5236/actionview/lib/action_view/digestor.rb#L28
An object's hash value is not unique, so it's possible for this cache
key to produce colliding keys with no resolution. This commit move
cache on to the details key object itself, so we know that the digests
are always unique per details key object.
|
|/ /
| |
| |
| |
| |
| | |
If you want to use `EventedFileUpdateChecker`, need to specify `listen` to plugin's gemspec.
However, the default is not specified `listen` to plugin's gemspec,
`EventedFileUpdateChecker` should be disabled.
|
|\ \
| |/
|/| |
modify to `error` also abort when specify fail fast option
|
| | |
|
| |
| |
| |
| | |
Now that AC::Parameters is no longer a Hash, it shouldn't look like a hash.
|
|/
|
|
| |
`app_templates_dir` is unused since dc53fe9.
|
| |
|
|\
| |
| | |
Correct config option from only_api to api_only in test
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Whenever you are sending emails in integration tests using the `:test`
delivery method you need to make sure that
`ActionMailer::Base.deliveries` is reset after every test. This piece of
boilerplate code is present in all my applications that send
emails. Let's have `ActionDispatch::IntegrationTest` reset the
deliveries automatically.
|
| | |
|
| | |
|
| | |
|
|\ \
| | |
| | | |
generate mailer views in Rails API
|
| | |
| | |
| | |
| | |
| | | |
View files is necessary to send mail, it should be generated even Rails API.
Fixes #23617
|
| | |
| | |
| | |
| | |
| | | |
This is a follow-up to ea70c29 to bring back the assertion error
location information provided by minitest.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit 0db310586ac3e15be95d2ef27ff40cfa24c05c10.
Closes #23686.
Conflicts:
railties/test/application/test_runner_test.rb
It's possible that the `result.location` returned by minitest is outside
the test file itself. For example in the case of mocha. This resulted in
bad rerun snipptets:
```
bin/rails test app/models/deliveries/delivery.rb:103
```
Let's always use the first line of the failed test-case in our rerun
snippet. We can display the line number of the assertion error elsewhere.
|
|\ \ \
| | | |
| | | | |
mark as #:nodoc: [ci skip]
|
| | | |
| | | |
| | | | |
can’t be instantiate directly or may be no need for doc.
|
|\ \ \ \
| |/ / /
|/| | | |
remove `active_support.test_order` from environment file
|
| | | |
| | | |
| | | |
| | | |
| | | | |
The default test order has been changed to `:random` in 5f777e4b5ee2e3e8e6fd0e2a208ec2a4d25a960d.
Therefore, it is no more need to be specified in the environment file.
|
|\ \ \ \
| |/ / /
|/| | | |
Inject Rails related configuration through Railtie
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We were explicitly referencing Rails.root in ActionCable::Server::Configuration.initialize,
thereby coupling ourselves to Rails.
Instead add `app/channels` to Rails' app paths and assign the existent files
to `channel_paths`.
Users can still append to those load paths with `<<` and `push` in `config/application.rb`.
This means we can remove the custom `Dir` lookup in `channel_paths` and the Rails
and root definitions in the tests.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
3f70e8bd2 set a new bar for tests, but they weren't updated.
Update their expectation.
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Fix routes to match verb and URL path with -g option also.
|
| | | | | |
|
| |_|_|/
|/| | |
| | | |
| | | |
| | | |
| | | | |
s/config\/production/config\/environments\/production/
[ci skip]
|
| |_|/
|/| |
| | |
| | |
| | |
| | | |
- Fixed related documentation and usage all around
Fixes #23561
|
|\ \ \
| | | |
| | | | |
Set database poolsize via rails_max_threads
|
| | |/
| |/| |
|
|\ \ \
| |_|/
|/| | |
set association name to generated fixtures if attribute is reference
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It has been changed to require `belongs_to` by default in Rails 5.
Therefore in order to pass the controller test, have association of set to fixtures.
Fixes #23384
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| |/
|/| |
|
|/
|
|
|
|
|
| |
A couple of the READMEs were still referring the old welcome page. This
is a small change that goes over it.
[ci skip]
|
|
|
|
|
|
|
|
|
|
|
| |
Previous commit accidentally broke mixing line filters with string -n filter.
Fix by checking if it is a string and returning it.
We also need to ensure the -n filter carry forward into any other composite filters.
Fix by letting the named filter be extractable, so we'll keep this for the next runnable's
run.
|
|
|
|
|
| |
Dummy apple icon files has been added after the 5.0.0.beta2 release.
ref: #23455
|
|
|
|
|
|
|
|
| |
on sprockets environment
- Remove jquery-rails if --skip-sprockets is true
Fixes #23431
|
|
|
|
|
|
|
|
| |
Redis now included in Gemfile but commented out. This change was made in
91864439c7aebb6ca710831aac6781903a433904 and is causing the test
failure.
See https://travis-ci.org/rails/rails/jobs/106994913#L1025
|
|\
| |
| | |
Pass api only option to rails rails:update task to update only based on api Apps
|
| |
| |
| |
| | |
Fixes #23470
|
| |
| |
| |
| | |
All grown up and shit!
|
| |
| |
| |
| | |
So no need to have it on by default in the Gemfile.
|
| |
| |
| |
| | |
So it can properly show stats for an app with 1,000,000+ LOC
|
| |
| |
| |
| |
| |
| | |
This reverts commit 293bd95c3e77275193130bc14c986348aae8b0e2.
This broke the header :<
|
|\ \
| | |
| | | |
Active Record supports MySQL >= 5.0
|