| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\
| |
| |
| | |
Fix Parameters configuration integration tests
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
These tests relied on `ActionController::Parameters` being configured as
part of the boot process; since that now happens lazily we need to force
`ActionController::Base` to load so that we can test the behaviour.
The new tests added here ensure that `ActionController::Parameters` can
be configured from an initializer, which was broken until recently.
|
|/
|
|
|
|
|
| |
Now that the parameters configurations are only loaded when
ActionController::Base is we need to foce them to load in our tests. In
an application this is not needed since every request already load the
controllers.
|
| |
|
|\ |
|
| |
| |
| |
| | |
It is covered by following assertion.
|
| | |
|
| |
| |
| |
| |
| | |
This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing
changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
|
| |\
| | |
| | |
| | | |
Enforce frozen string in Rubocop
|
| | | |
|
| |\ \
| | | |
| | | | |
Clear screenshots files in `tmp:clear` task
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
If system test fails, it creates screenshot under `tmp/screenshots`.
https://github.com/rails/rails/blob/34fe2a4fc778d18b7fe6bdf3629c1481bee789b9/actionpack/lib/action_dispatch/system_testing/test_helpers/screenshot_helper.rb#L45
But currently, screenshot files is not cleared by `tmp:clear` task.
This patch make clears screenshot files with `tmp:clear` task as well
as other tmp files.
|
| | | | |
|
|/ / / |
|
|\ \ \
| |_|/
|/| | |
Add system tests to generate scaffold
|
| | | |
|
| |/
|/| |
|
|\ \
| | |
| | | |
Remove unnecessary `tap` call on `ActionDispatch::MiddlewareStack.new`
|
| | | |
|
|/ / |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The `capify` command has been removed by Capistrano 3 and became to
`cap install`.
Therefore, the `capify!` method has no meaning in Capistrano 3.
I think that should deprecate.
Ref: https://github.com/capistrano/capistrano/commit/492793916acf32ffe1604daec6fd4892c8935018
|
| |
| |
| |
| | |
- [Rails <= 5.0](https://github.com/rails/rails/blob/5-0-stable/railties/lib/rails/commands/test.rb#L6) used to add the `<app_root>/test` as a string; this behaviour changed in rails 5.1, it's appending a `Pathname` object
|
| | |
|
|\ \
| | |
| | | |
Add note to Railtie docs to use unique filenames
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The fact that the names need to be globally unique was not obvious to me, so I
thought it'd be worth documenting. This not being clear was the cause of both
ctran/annotate_models#468 and instructure/outrigger#1.
[ci skip]
|
|\ \ \
| | | |
| | | | |
Drop IRB out of the web-console Gemfile comment
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We don't provide exactly the same experience as IRB does, so let's not
advertize it like that. We can say that it's an interactive console,
without further references. I have also followed byebug's comment and
changed the calling `console` part. Hopefully, this can hint that the
invocation is not view specific and you can use it like the debugger
statement.
[ci skip]
|
|\ \ \ \
| |/ / /
|/| | | |
Default Message Encryptor Cipher to AES-256-GCM From AES-256-CBC
|
| | | |
| | | |
| | | |
| | | | |
- Introduce a method to select default cipher, and maintain backward compatibility
|
| |_|/
|/| |
| | |
| | |
| | | |
Fix the mistake of not using Ruby's ENV hash from the get go and get
windows support.
|
| | | |
|
|/ / |
|
| | |
|
| | |
|
|\ \
| | |
| | |
| | |
| | | |
orhantoy/feature/fix-scaffold_controller-generator-usage
[ci skip] Fix `scaffold_controller` generator usage
|
| | | |
|
| | |
| | |
| | |
| | | |
We don't get any benefit from it at all.
|
|\ \ \
| |_|/
|/| |
| | |
| | | |
greysteil/better-spacing-in-production-environment
Better spacing in environments/production.rb file
|
| | |
| | |
| | |
| | |
| | | |
Previously there were a couple of places where double-spacing or no spacing
was happening, depending on skipped options.
|
| | | |
|
| | | |
|
| |/
|/|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* Allow a default value to be declared for class_attribute
* Convert to using class_attribute default rather than explicit setter
* Removed instance_accessor option by mistake
* False is a valid default value
* Documentation
|
| |
| |
| |
| |
| |
| | |
secrets key file that is created by rails secrets:setup"
This reverts commit 75500476eb7e953a06cc64e67ecc57b13ef8cc99.
|
|\ \
| | |
| | | |
[ci skip] Add elm option of webpack to generator description
|
| | | |
|
|/ / |
|
|\ \
| | |
| | |
| | |
| | | |
kamipo/default_env_fall_back_to_default_env_when_rails_env_or_rack_env_is_empty_string
`DEFAULT_ENV` falls back to `default_env` when `RAILS_ENV` or `RACK_ENV` is an empty string
|
| | |
| | |
| | |
| | |
| | |
| | | |
an empty string
Follow up of #27399.
|
|\ \ \
| | | |
| | | | |
Correctly set user_supplied_options when there is no whitespace in option specification
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
specification
Current `user_supplied_options` method can not set the value correctly
if there is no space between option and value (e.g., `-p9000`).
This makes it possible to set the value correctly in the case like the above.
Fixes #29138
|