| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
| | |
| | |
| | | |
This also marks Action Cable routes as internal to Rails.
|
| | | |
|
| | |
| | |
| | |
| | | |
Adds changelog headers for beta3 release
|
| | |
| | |
| | |
| | | |
Fixes #23855
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
coffee-rails is stable now so we don't need to point to the master
branch.
|
|\ \ \
| |/ /
|/| | |
Show permitted flag in the output of AC::Parameters#inspect
|
| | |
| | |
| | |
| | | |
- Fixes #23822.
|
|\ \ \
| |/ /
|/| | |
AppGenerator: Replace 'rake' with 'rails_command'
|
| | |
| | |
| | |
| | |
| | | |
Follows the convention from Rails 5 of invoking tasks on the command-line
with `rails …` rather than `rake …`.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Since Rails 5.0 is switching the Rails command line from 'rake …'
to 'rails …', it makes sense to also replace the `rake` method in
the Rails templates API.
Based on feedback from @matthewd and @kaspth, I chose to replace
`rake` with `rails_command`, which is less confusing than
the alternatives `rails` or `command` or `rails_run` and is not
Thor-reserved word like `task`.
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | | |
This is a rebased version of #22825.
Closes #22825.
|
| | |/
| |/|
| | |
| | | |
environment templates
|
| | | |
|
| | | |
|
|/ / |
|
|\ \
| | |
| | | |
Alternative to #23638 log to STDOUT via env var
|
| | |
| | |
| | |
| | |
| | |
| | | |
People who deploy to containers or other places where they might have some sort of a log wrapping service use stdout. With this change new rails apps can be configured to output to STDOUT via setting `RAILS_LOG_TO_STDOUT` to any value. This allows container images or services to set the value for all apps without having to modify configuration for each application. If an app wants to opt out, they can either delete from the env hash, or remove that configuration.
cc/ @rafaelfranca
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
wisetara/wisetara/deprecate-args-ActiveSupport__TestCase#assert_nothing_raised-for-pr
Wisetara/deprecate args active support test case#assert nothing raised for pr
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | |
| | | |
creating all databases mutates the connection pool. This patch restores
the connection pool to the connection spec established before creating
all databases. Fixes #23279
|
|\ \ \
| | | |
| | | | |
Add `internal` attribute to routes
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This is meant to provide a way for Action Cable, Sprockets, and possibly
other Rack applications to mark themselves as internal, and to exclude
themselves from the routing inspector, and thus `rails routes` / `rake
routes`.
I think this is the only way to have mounted Rack apps be marked as
internal, within AD/Journey. Another option would be to create an array
of regexes for internal apps, and then to iterate over that everytime a
request comes through. Also, I only had the first `add_route` method set
`internal`'s default to false, to avoid littering it all over the
codebase.
|
| | | | |
|
| | | | |
|
|/ / / |
|
| | |
| | |
| | |
| | |
| | | |
We should be able to pass options to minitest via TESTOPTS environment
variable
|
| | |
| | |
| | |
| | | |
Get it? ( ͡° ͜ʖ ͡°)
|
|\ \ \
| | | |
| | | | |
use method provided by minitest
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | | |
The process of converting `Test` to `String` is already defined in minitest.
I think it is better to use that for the consistency of output content.
ref: https://github.com/seattlerb/minitest/blob/master/lib/minitest/test.rb#L261..L267
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Having collection caching that wraps templates and automatically tries
to infer if they are cachable proved to be too much of a hassle.
We'd rather have it be something you explicitly turn on.
This removes much of the code and docs to explain the previous automatic
behavior.
This change also removes scoped cache keys and passing cache_options.
|
|\ \
| | |
| | | |
move digest cache on to the DetailsKey object
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This moves digest calculation cache on to the details key object.
Before, the digest cache was a class level ivar, and one of the keys was
the hash value of the details key object:
https://github.com/rails/rails/blob/13c4cc3b5aea02716b7459c0da641438077f5236/actionview/lib/action_view/digestor.rb#L28
An object's hash value is not unique, so it's possible for this cache
key to produce colliding keys with no resolution. This commit move
cache on to the details key object itself, so we know that the digests
are always unique per details key object.
|
|/ /
| |
| |
| |
| |
| | |
If you want to use `EventedFileUpdateChecker`, need to specify `listen` to plugin's gemspec.
However, the default is not specified `listen` to plugin's gemspec,
`EventedFileUpdateChecker` should be disabled.
|
|\ \
| |/
|/| |
modify to `error` also abort when specify fail fast option
|
| | |
|
| |
| |
| |
| | |
Now that AC::Parameters is no longer a Hash, it shouldn't look like a hash.
|
|/
|
|
| |
`app_templates_dir` is unused since dc53fe9.
|
| |
|
|\
| |
| | |
Correct config option from only_api to api_only in test
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Whenever you are sending emails in integration tests using the `:test`
delivery method you need to make sure that
`ActionMailer::Base.deliveries` is reset after every test. This piece of
boilerplate code is present in all my applications that send
emails. Let's have `ActionDispatch::IntegrationTest` reset the
deliveries automatically.
|
| | |
|
| | |
|
| | |
|
|\ \
| | |
| | | |
generate mailer views in Rails API
|
| | |
| | |
| | |
| | |
| | | |
View files is necessary to send mail, it should be generated even Rails API.
Fixes #23617
|
| | |
| | |
| | |
| | |
| | | |
This is a follow-up to ea70c29 to bring back the assertion error
location information provided by minitest.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit 0db310586ac3e15be95d2ef27ff40cfa24c05c10.
Closes #23686.
Conflicts:
railties/test/application/test_runner_test.rb
It's possible that the `result.location` returned by minitest is outside
the test file itself. For example in the case of mocha. This resulted in
bad rerun snipptets:
```
bin/rails test app/models/deliveries/delivery.rb:103
```
Let's always use the first line of the failed test-case in our rerun
snippet. We can display the line number of the assertion error elsewhere.
|