aboutsummaryrefslogtreecommitdiffstats
path: root/railties
Commit message (Collapse)AuthorAgeFilesLines
* Explains a detail re eager loading [ci skip]Xavier Noria2019-02-201-0/+3
|
* let Zeitwerk integration unhook AS::DependenciesXavier Noria2019-02-195-2/+35
|
* Auto correct rubocop offensesYoshiyuki Hirano2019-02-171-0/+2
| | | | | | | | | | | | | | | | | | Offenses: railties/lib/rails/autoloaders.rb:1:1: C: [Corrected] Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. module Rails ^ actionmailer/test/base_test.rb:917:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning. actionmailer/test/base_test.rb:917:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. actionmailer/test/base_test.rb:917:5: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ actionmailer/test/base_test.rb:918:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. events = [] ^^^^ actionmailer/test/base_test.rb:930:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body end. actionmailer/test/base_test.rb:930:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected.
* Implement AS::Dependencies.verbose= compatibility for :zeitwerk modeXavier Noria2019-02-151-0/+36
|
* Replace autoloader accessors with Rails.autoloaders.{main,once}Xavier Noria2019-02-145-41/+65
| | | | | | | | | | | | | | | | Rails.autoloader and Rails.once_autoloader was just tentative API good enough for a first patch. Rails.autoloader is singular and does not convey in its name that there is another autoloader. That might be confusing, for example if you set a logger and miss traces. On the other hand, the name `once_autoloader` is very close to being horrible. Rails.autoloaders.main and Rails.autoloaders.once read better for my taste, and have a nice symmetry. Also, both "main" and "once" are four letters long, short and same length. They are tagged as "rails.main" and "rails.once", respectively. References #35235.
* Merge pull request #35249 from Edouard-chin/ec-config-for-hash-in-arrauRafael Mendonça França2019-02-142-4/+40
|\ | | | | | | Fix the `config_for` to always return a NonSymbolAccessDeprecatedHash:
| * Fix the `config_for` to always return a NonSymbolAccessDeprecatedHash:Edouard CHIN2019-02-143-4/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - If you have hashes inside array, the hashes were getting initialized as regular HWIA wereas we want them to be NonSymbolAccessDeprecatedHash in order to trigger a deprecation warning when keys are accessed with string. This patch fixes that by overwriting the `[]=` to to the same as what HWIA does (with the difference that we don't call `convert_key` to not trigger a deprecation when setting value). I also took the liberty to extract `hash.nested_under_indifferent_access`, into a separate method to allow subclasses to return whatever they want. Inheriting HWIA is not common, but I think it's useful for cases like this one where we want to preprocess reading and writing values in the hash (for deprecation purposes or other reasons).
* | Let Zeitwerk be a dependency of Active SupportXavier Noria2019-02-134-18/+7
|/ | | | | Zeitwerk is a strong dependency, planned to replace AS::Dependencies. A line in the generated Gemfile does not convey this as much.
* styleXavier Noria2019-02-121-3/+3
|
* Zeitwerk integrationXavier Noria2019-02-1213-51/+289
|
* Add missing packages (#35227)Yuji Yaginuma2019-02-121-0/+2
| | | | If generate application without specified options,`actioncable` and `activestorage` loads by default.
* Merge pull request #35198 from paracycle/uk-change-config-for-behaviourGannon McGibbon2019-02-113-9/+149
|\ | | | | Allow deprecated non-symbol access to nested `config_for` hashes
| * Fix assertion excpected/actual orderUfuk Kayserilioglu2019-02-111-6/+6
| | | | | | | | | | | | | | | | The assertion from the previous PR had the expected and the actual values in the wrong order, so when a test failed the error message was confusing. This commit fixes the problem by switching the order.
| * Allow deprecated non-symbol access to nested `config_for` hashesUfuk Kayserilioglu2019-02-113-3/+143
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A change to `Rails::Application.config_for` in https://github.com/rails/rails/pull/33815 and https://github.com/rails/rails/pull/33882 has altered the behaviour of the returned object in a breaking manner. Before that change, nested hashes returned from `config_for` could be accessed using non-symbol keys. After the change, all keys are recursively symbolized so non-symbol access fails to read the expected values. This is a breaking change for any app that might be relying on the nested hashes returned from `config_for` calls, and thus should be deprecated before being removed from the codebase. This commit introduces a temporary `NonSymbolAccessDeprecatedHash` class that recursively wraps any nested hashes inside the `OrderedOptions` object returned from `config_for` and issues a deprecation notice when a non-symbol based access is performed. This way, apps that are still relying on the ability to access these nested hashes using non-symbol keys will be able to observe the deprecation notices and have time to implement changes before non-symbol access is removed for good. A CHANGELOG entry is also added to note that non-symbol access to nested `config_for` hashes is deprecated.
* | Optimized namespaces_to_paths method.alkesh262019-02-111-2/+3
|/
* Merge pull request #35184 from y-yagi/avoid_extra_package_installMatthew Draper2019-02-118-12/+35
|\ | | | | Avoid extra package install
| * Install JavaScript packages before run testyuuji.yaginuma2019-02-118-12/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | Some tests are running yarn install during the test. The directory used for isolation test is not subject to yarn workspace, and it occurs because the required package is not installed. In order to avoid this, I fixed all necessary packages to be installed before run test and use symlink to `node_modules`. This is a bit complicated, as `yarn install` needs to be run in a specific directory before running the test. However, running `yarn install` every time run the test is expensive when testing locally and should be avoided.
* | Revert "Merge pull request #35211 from y-yagi/fix_broken_association_test" ↵Yuji Yaginuma2019-02-111-16/+0
| | | | | | | | | | | | | | | | (#35217) This reverts commit 38f9e41f2c4b64377ffb036c53873dbfb51546cf, reversing changes made to 5e493c3b839f10d639f5cce1f1b9ff9292702821. Reason: The ajv@6.9.1 was released that fixes issue.
* | Avoid ajv@6.9.0 for nowyuuji.yaginuma2019-02-101-0/+16
| | | | | | | | | | Because ajv@6.9.0 does not work with webpack. Ref: https://github.com/epoberezkin/ajv/issues/941
* | Fix rubocop violationsyuuji.yaginuma2019-02-091-9/+7
| |
* | Rename database_operations config to *_contextJohn Hawthorn2019-02-071-4/+5
| |
* | Merge pull request #35036 from rails/av-base-subclassAaron Patterson2019-02-062-5/+6
|\ \ | |/ |/| Move compiled ERB to an AV::Base subclass
| * Deprecate finalizer configuration (it doesn't do anything)Aaron Patterson2019-02-061-0/+21
| | | | | | | | | | | | Revert "Remove finalizer and configuration" This reverts commit 9e7b4a3173788ea43b11e74a4d2f69a5f1565daa.
| * Remove finalizer and configurationAaron Patterson2019-02-062-20/+0
| |
* | Preload all component gemsyuuji.yaginuma2019-02-061-0/+2
| | | | | | | | To avoid running require individually.
* | Restrict frameworks to load in engine testyuuji.yaginuma2019-02-061-4/+22
|/ | | | | For avoid to affect tests. Also, `action_text:install` task execute `yarn add`. This is an expensive and should be avoided if it is not needed.
* Set sqlite3 gem version explicitly in generated GemfileSergey Ponomarev2019-02-052-1/+2
|
* Respect ENV variables when finding DBs etc for the test suiteMatthew Draper2019-02-064-14/+32
| | | | | If they're not set we'll still fall back to localhost, but this makes it possible to run the tests against a remote Postgres / Redis / whatever.
* Merge pull request #35086 from gsamokovarov/cleanup-whitelisting-refsGannon McGibbon2019-02-042-3/+3
|\ | | | | Cleanup the whitelisting references after #33145
| * Cleanup the whitelisting references after #33145Genadi Samokovarov2019-02-032-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | During the development of #33145, I have named a few concepts in the code as `whitelisted`. We decided to stay away from the term and I adjusted most of the code afterwards, but here are the cases I forgot to change. I also found a case in the API guide that we could have cleaned up as well. [ci skip]
* | Merge pull request #35126 from alkesh26/railities-typo-fixEileen M. Uchitelle2019-02-0111-14/+14
|\ \ | | | | | | Railties typo fixes.
| * | Railities typo fixes.alkesh262019-02-0111-14/+14
| | |
* | | Enable `Lint/ErbNewArguments` cop to avoid the deprecated arguments warningRyuta Kamizono2019-02-011-2/+1
|/ / | | | | | | | | | | Related 5754a29a974d31cab2b4392716b9825a3d910a69. And follows Ruby standard library style https://github.com/ruby/ruby/commit/3406c5d.
* | Fix `ERB.new` argument deprecated warningyuuji.yaginuma2019-01-311-1/+5
| | | | | | | | | | | | | | | | This fixes following warning. ``` warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments. ```
* | Merge pull request #34980 from y-yagi/fixes_34979Yuji Yaginuma2019-01-312-2/+10
|\ \ | | | | | | Don't add `RAILS_ENV` in generate action
| * | Don't add `RAILS_ENV` in generate actionyuuji.yaginuma2019-01-192-2/+10
| | | | | | | | | | | | | | | | | | | | | In the case of generator, `RAILS_ENV` is interpreted as an argument as it is. Avoid this because it will result unintended by the user. Fixes #34979.
* | | Merge pull request #35073 from eileencodes/db-selectionEileen M. Uchitelle2019-01-301-0/+20
|\ \ \ | | | | | | | | Part 8: Multi db improvements, Adds basic automatic database switching to Rails
| * | | Adds basic automatic database switching to RailsEileen Uchitelle2019-01-301-0/+20
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The following PR adds behavior to Rails to allow an application to automatically switch it's connection from the primary to the replica. A request will be sent to the replica if: * The request is a read request (`GET` or `HEAD`) * AND It's been 2 seconds since the last write to the database (because we don't want to send a user to a replica if the write hasn't made it to the replica yet) A request will be sent to the primary if: * It's not a GET/HEAD request (ie is a POST, PATCH, etc) * Has been less than 2 seconds since the last write to the database The implementation that decides when to switch reads (the 2 seconds) is "safe" to use in production but not recommended without adequate testing with your infrastructure. At GitHub in addition to the a 5 second delay we have a curcuit breaker that checks the replication delay and will send the query to a replica before the 5 seconds has passed. This is specific to our application and therefore not something Rails should be doing for you. You'll need to test and implement more robust handling of when to switch based on your infrastructure. The auto switcher in Rails is meant to be a basic implementation / API that acts as a guide for how to implement autoswitching. The impementation here is meant to be strict enough that you know how to implement your own resolver and operations classes but flexible enough that we're not telling you how to do it. The middleware is not included automatically and can be installed in your application with the classes you want to use for the resolver and operations passed in. If you don't pass any classes into the middleware the Rails default Resolver and Session classes will be used. The Resolver decides what parameters define when to switch, Operations sets timestamps for the Resolver to read from. For example you may want to use cookies instead of a session so you'd implement a Resolver::Cookies class and pass that into the middleware via configuration options. ``` config.active_record.database_selector = { delay: 2.seconds } config.active_record.database_resolver = MyResolver config.active_record.database_operations = MyResolver::MyCookies ``` Your classes can inherit from the existing classes and reimplment the methods (or implement more methods) that you need to do the switching. You only need to implement methods that you want to change. For example if you wanted to set the session token for the last read from a replica you would reimplement the `read_from_replica` method in your resolver class and implement a method that updates a new timestamp in your operations class.
* | | Rename methods and update docsEileen Uchitelle2019-01-291-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a minor update to the named methods for the following: - s/desired_capabilities/capabilities - s/driver_options/capabilities Since they are all the same thing we should keep the name the same throughout the feature. Updated docs to match / be a little bit clearer Also updated the Gemfile for selenium-webdriver.
* | | Implement a way to add browser capabilities:Edouard CHIN2019-01-291-0/+2
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * There is currently no way to define specific browser capabilities since our SystemTest driver override the `option` key [Ref](https://github.com/rails/rails/blob/a07d0680787ced3c04b362fa7a238c918211ac70/actionpack/lib/action_dispatch/system_testing/driver.rb#L35) This option key is used internally by selenium to add custom capabilities on the browser. Depending on the Browser, some option are allowed to be passed inside a hash, the driver takes care of setting whatever you passed on the driver option. An example [here](https://github.com/rails/rails/blob/a07d0680787ced3c04b362fa7a238c918211ac70/actionpack/lib/action_dispatch/system_testing/driver.rb#L35) where you are allowed to pass args such as `--no-sandbox` etc However this behavior was only meant for backward compatibility and as you can see it's deprecated. The non-deprecated behavior is to create a `<Driver>::Option` object containing all the capabilities we want. This is what we [currently do](https://github.com/rails/rails/blob/a07d0680787ced3c04b362fa7a238c918211ac70/actionpack/lib/action_dispatch/system_testing/browser.rb#L34-L36) when chrome or firefox are in headless mode. This PR allows to pass a block when calling `driven_by`, the block will be pased a `<Driver>::Option` instance. You can modify this object the way you want by adding any capabilities. The option object will be then passed to selenium. ```ruby driven_by :selenium, using: :chrome do |driver_option| driver_option.add_argument('--no-sandbox') driver_option.add_emulation(device: 'iphone 4') end ```
* | Convert path to string before call `length`yuuji.yaginuma2019-01-281-1/+1
| | | | | | | | | | | | | | | | Because eager load paths support to using `Pathname`, and `Pathname` doesn't have `length` method. Ref: https://travis-ci.org/rails/rails/jobs/485088071#L5140-L5143 Follow up aadeed1518b9092ea21adf49c728172368129f0e.
* | Simplify path prefix extractionXavier Noria2019-01-271-2/+3
| |
* | Fix typo: overriden -> overridden [ci skip] (#35060)Vipul A M2019-01-261-1/+1
| |
* | Merge pull request #34789 from christos/fix-editing-new-environment-credentialsKasper Timm Hansen2019-01-253-2/+20
|\ \ | | | | | | Don't load app environment when editing credentials
| * | Don't load app environment when editing credentialsChristos Zisopoulos2018-12-263-2/+20
| | | | | | | | | | | | This avoids missing key exceptions caused by code that tries to read the credentials before they have been added to the encrypted file, for example when editing the credentials for a new environment.
* | | Fix deeply nested namespace command printingGannon McGibbon2019-01-243-3/+18
| | |
* | | Merge pull request #34993 from schuetzm/allow-subdomains-of-localhostRafael França2019-01-232-1/+6
|\ \ \ | | | | | | | | Subdomains of localhost are safe against DNS rebinding
| * | | Subdomains of localhost are safe against DNS rebindingMarc Schütz2019-01-232-1/+6
| | |/ | |/|
* | | Merge pull request #34997 from alkesh26/typo-fix-webserverEileen M. Uchitelle2019-01-222-3/+3
|\ \ \ | | | | | | | | Replaced webserver with web server
| * | | Changed webserver to web server.alkesh262019-01-222-3/+3
| |/ /
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 04:30:16 +0000