| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |/ / / /
| | | | |
| | | | |
| | | | | |
refs: #28011
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
mtsmfm/fix-generator-command-for-nested-rails-engine-take-2
Fix generator command for nested (namespaced) rails engine (take 2)
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Rewrite https://github.com/rails/rails/pull/27550
085546df45 was reverted (b6ffb5efcb) because it change the return of `namespaced_path` from String to Array.
----------------
If we create nested (namespaced) rails engine such like bukkits-admin,
`bin/rails g scaffold User name:string age:integer`
will create
`bukkits-admin/app/controllers/bukkits/users_controller.rb`
but it should create
`bukkits-admin/app/controllers/bukkits/admin/users_controller.rb`.
In #6643, we changed `namespaced_path` as root path
because we supposed application_controller is always in root
but nested rails engine's application_controller will not.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
These files are not using `strip_heredoc`.
Closes #27976
|
| | | | |
| | | | |
| | | | |
| | | | | |
empty lines
|
| | | | | |
|
| |_|/ /
|/| | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
```
go get -u github.com/client9/misspell/cmd/misspell
misspell -w -error -source=text .
```
|
|\ \ \ \
| | | | |
| | | | | |
Collect all file patterns when running multiple rake test tasks
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Replaces the rake_patterns instance variable with simple require, as
`autorun` will run tests from all eagerly required test files.
Fixes #27801
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Ignore yarn error log file
|
| |/ / / / |
|
|/ / / /
| | | |
| | | |
| | | | |
If already have layout files, in many cases use it.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The raw_source method is documented as returning the exact value that
was used to create the body; mutating it breaks that contract.
Additionally, if the value used to create the body is blank, raw_source
returns a frozen string which causes the interceptor to raise an error.
|
|\ \ \ \
| | | | |
| | | | | |
Added warning for reserved YAML keywords.
|
| | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | | |
Update i18n.md
Addressed Feedback
|
|\ \ \ \
| | | | |
| | | | | |
Fully initialize routes before the first request is handled
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`AD::Journey::GTG::Simulator` is lazily built the first time
`Journey::Router#find_routes` is invoked, which happens when
the first request is served.
On large applications with many routes, building the simulator
can take several hundred milliseconds (~700ms for us).
Triggering this initialization during the boot process reduces
the impact of deploys on the application response time.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
correctly check error message
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
`assert_raise` does not check error message. However, in some tests,
it seems like expecting error message checking with `assert_raise`.
Instead of specifying an error message in `assert_raise`, modify to use
another assert to check the error message.
|
|\ \ \ \ \ \
| |_|_|/ / /
|/| | | | | |
add warnings option to test runner
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This removes the following warnings.
```
test/application/bin_setup_test.rb:43: warning: ambiguous first argument; put parentheses or a space even after `/' operator
```
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
remove unreachable code
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
`app_path` is a required argument. Therefore, if `app_path` is not
specified, it becomes an error in thor's option parsing, does not reach
this check.
|
| | | | | | |
|
| |/ / / /
|/| | | |
| | | | |
| | | | |
| | | | | |
When specifying the `pretend` option, expect that no processing will be
done, so do not execute `git init` as well.
|
|/ / / /
| | | |
| | | |
| | | |
| | | | |
Fixes "NameError: uninitialized constant ApplicationTests::ConfigurationTests::CustomTest::Rails"
when run individually
|
|\ \ \ \
| | | | |
| | | | | |
update CREATE TABLE statements generated by `sqlite3` command
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
From SQLite 3.16.0, `IF NOT EXISTS` set to CREATE TABLE statements.
Ref: https://www.sqlite.org/src/info/c7021960f5c070fb
Fixes #27635.
|
|/ / / /
| | | |
| | | |
| | | | |
tool like Capistrano and we dont need the play-by-play
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
Follow up to b1c08d8d9b921fdcf3813b5c20a0c3fab96eccca
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
Initalize git repo when creatin new rails app
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* If `--skip-git` is not specified initalize git repo
when creating new rails app
|
|\ \ \ \ \
| | | | | |
| | | | | | |
match indentations in environment template
|
| | | | | | |
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
allow to pass describe option to rake
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Since `Thor::HELP_MAPPINGS` contains `-D`, so `bin/rails -D` show
rails's help. But, in Rails 5.0.1, `bin/rails -D` show the description
of rake task. I think that it is better to have the same behavior.
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Install Byebug gem as default in Windows (mingw and x64_mingw) platform.
|
| | | | | | | | |
|
| |/ / / / / / |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
We don't want to leak the extra migration path to other railties tests.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
We don't want to leak the extra migration path to other railties tests.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Generate migrations at path set by `config.paths["db/migrate"]`
|