| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
The raw_source method is documented as returning the exact value that
was used to create the body; mutating it breaks that contract.
Additionally, if the value used to create the body is blank, raw_source
returns a frozen string which causes the interceptor to raise an error.
|
|\
| |
| | |
Added warning for reserved YAML keywords.
|
| |
| |
| |
| |
| |
| | |
Update i18n.md
Addressed Feedback
|
|\ \
| | |
| | | |
Fully initialize routes before the first request is handled
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
`AD::Journey::GTG::Simulator` is lazily built the first time
`Journey::Router#find_routes` is invoked, which happens when
the first request is served.
On large applications with many routes, building the simulator
can take several hundred milliseconds (~700ms for us).
Triggering this initialization during the boot process reduces
the impact of deploys on the application response time.
|
|\ \ \
| | | |
| | | | |
correctly check error message
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`assert_raise` does not check error message. However, in some tests,
it seems like expecting error message checking with `assert_raise`.
Instead of specifying an error message in `assert_raise`, modify to use
another assert to check the error message.
|
|\ \ \ \
| |_|_|/
|/| | | |
add warnings option to test runner
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This removes the following warnings.
```
test/application/bin_setup_test.rb:43: warning: ambiguous first argument; put parentheses or a space even after `/' operator
```
|
| | | |
| | | |
| | | |
| | | | |
[ci skip]
|
|\ \ \ \
| |_|/ /
|/| | | |
remove unreachable code
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`app_path` is a required argument. Therefore, if `app_path` is not
specified, it becomes an error in thor's option parsing, does not reach
this check.
|
| | | | |
|
| |/ /
|/| |
| | |
| | |
| | | |
When specifying the `pretend` option, expect that no processing will be
done, so do not execute `git init` as well.
|
|/ /
| |
| |
| |
| | |
Fixes "NameError: uninitialized constant ApplicationTests::ConfigurationTests::CustomTest::Rails"
when run individually
|
|\ \
| | |
| | | |
update CREATE TABLE statements generated by `sqlite3` command
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
From SQLite 3.16.0, `IF NOT EXISTS` set to CREATE TABLE statements.
Ref: https://www.sqlite.org/src/info/c7021960f5c070fb
Fixes #27635.
|
|/ /
| |
| |
| | |
tool like Capistrano and we dont need the play-by-play
|
| | |
|
| |
| |
| |
| | |
Follow up to b1c08d8d9b921fdcf3813b5c20a0c3fab96eccca
|
|\ \
| | |
| | |
| | | |
Initalize git repo when creatin new rails app
|
| | |
| | |
| | |
| | |
| | | |
* If `--skip-git` is not specified initalize git repo
when creating new rails app
|
|\ \ \
| | | |
| | | | |
match indentations in environment template
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
allow to pass describe option to rake
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Since `Thor::HELP_MAPPINGS` contains `-D`, so `bin/rails -D` show
rails's help. But, in Rails 5.0.1, `bin/rails -D` show the description
of rake task. I think that it is better to have the same behavior.
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Install Byebug gem as default in Windows (mingw and x64_mingw) platform.
|
| | | | | | |
|
| |/ / / / |
|
| | | | |
| | | | |
| | | | |
| | | | | |
We don't want to leak the extra migration path to other railties tests.
|
| | | | |
| | | | |
| | | | |
| | | | | |
We don't want to leak the extra migration path to other railties tests.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Generate migrations at path set by `config.paths["db/migrate"]`
|
| |/ / / / |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
that as a dependency for assets:precompile
|
|/ / / /
| | | |
| | | |
| | | | |
we call them only in the tests
|
|\ \ \ \
| | | | |
| | | | | |
Make all rails commands work in engine
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This test was added in 221b4ae.
221b4ae modified to return the same result even if `Rails::Server#default_options`
is called more than once. Therefore, also use `Rails::Server#default_options`
instead of `ServerCommand#default_options` in test.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Currently, all rails commands can be executed in engine,
but `server`, `console`, `dbconsole` and `runner` do not work.
This make all rails commands work in engine.
Related to #22588
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`TestTask` add `lib` directory by default.
Ref: https://github.com/ruby/rake/blob/master/lib/rake/testtask.rb#L39..L41
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
it has some methods that override the accessors and calls the original accessors via `super`
this partially reverts 9360b6be63b7a452535699bcf6ae853df7f5eea7
|
| |_|/ /
|/| | |
| | | |
| | | | |
because Struct.new returns a Class, we just can give it a name and use it directly without inheriting from it
|
| | | |
| | | |
| | | |
| | | | |
(I personally prefer writing one string in one line no matter how long it is, though)
|
|\ \ \ \
| |_|/ /
|/| | | |
remove unused requires
|
| | | |
| | | |
| | | |
| | | | |
Related to 0129ca2eeb6d5b2ea8c6e6be38eeb770fe45f1fa, f7782812f7e727178e4a743aa2874c078b722eef, f9ed83321ac1d1902578a0aacdfe55d3db754219
|
|\ \ \ \
| |_|_|/
|/| | |
| | | |
| | | | |
Conflicts:
railties/lib/rails/generators.rb
|