| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
| | |
| | |
| | | |
Add handling of cleaning up backtrace from IRB console in case of errors
|
| | |
| | |
| | |
| | | |
Follow up to #25431
|
|/ /
| |
| |
| |
| |
| | |
Since bundler 1.12.0, the gemspec is validated so the `bundle install`
command will fail just after the gem is created causing confusion to the
users. This change was a bug fix to correctly validate gemspecs.
|
|\ \
| | |
| | |
| | |
| | | |
prathamesh-sonpatki/add-note-about-upgrade-guide-at-the-end-of-update
Display link to Rails upgrade guide at the end of `rails app:update` task.
|
| | |
| | |
| | |
| | |
| | | |
- This will nudge people in the direction of going through upgrade
guides.
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | | |
Update to Turbolinks 5.0.0 final
|
| |/ / |
|
|/ / |
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
This will fix the failures fixed by
41488adbb89a09fa96188486f8414842ff28c848
and keep this new option that is semi-private
outside of the generated configurations
|
| |
| |
| |
| |
| | |
Railties tests didn't know about the new config option added in 80b416f so
it needed to be added to the railties generators for configs.
|
| |
| |
| |
| |
| |
| |
| |
| | |
This will make easier to applications that rely on having const_missing
hooks in production upgrade to Rails 5.
This option is going to be remove in the future and the default behavior
will be to disable the dependency loading.
|
| |
| |
| |
| |
| |
| |
| |
| | |
The /rails/info routes were inaccessible in apps with a catch-all
globbing route, as they were being appended after the globbing route and
would never be matched.
See also ccc3ddb7762bae0df7e2f8d643b19b6a4769d5be.
|
| |
| |
| |
| |
| |
| | |
- As assets are removed for API only apps anyways, so we don't need any
conditional upfront.
- assets are removed for API apps here - https://github.com/rails/rails/blob/94ef224aa61ace3fa643eab161ff9056b7d90a62/railties/lib/rails/generators/rails/app/app_generator.rb#L266-L273.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Railties tests related to fetching asset URL started failing after the
release of sprockets 3.6.1 on Travis.
- This was due to the change in
https://github.com/rails/sprockets/pull/311/files
which changed the logic in `concat_javascript_sources` to add `;` at
the end of file if the source did not end with semicolon.
- Bumped up sprockets minor version and fixed the failing tests.
|
| |
| |
| |
| |
| | |
This option is used in a initializer hook that runs before the
config/initializers files so it will not work if it is set there.
|
|\ \
| | |
| | | |
Require "active_support/core_ext/object/blank" for railties abstract unit
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In #25380 I moved an `active_support/core_ext/object/blank` in the
`activesupport/lib/active_support/testing/assertions.rb`, however it caused a
chain reaction, resulting in failing railties tests.
Moving the require to `railties/test/isolation/abstract_unit.rb` and
`activesupport/test/abstract_unit.rb`.
|
|\ \ \
| |/ /
|/| | |
Generate application_record.rb file before model file
|
| | |
| | |
| | |
| | |
| | |
| | | |
Previously model file was generated first, which resulted in
inheriting from `ActiveRecord::Base`, but since application_record.rb
is generated as well, it should already be used.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
y-yagi/generate_mailer_layout_files_if_it_does_not_already_exist
generate mailer layout files if it does not already exist
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Currently, if `ApplicationMailer` does not exist, it is generated when
run the mailer generator, but layouts files does not generate.
However, because it uses the layouts in `ApplicationMailer`,
layouts are required.
Follow up to #24161
|
| | | | |
|
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Forgotten followup to #23669 :grimacing:
If you went to an internal route (e.g. `/rails/info/routes`), you would
previously see the following in your logger:
```bash
Processing by Rails::InfoController#routes as HTML
Parameters: {"internal"=>true}
Rendering /Users/jon/code/rails/rails/railties/lib/rails/templates/rails/info/routes.html.erb within layouts/application
Rendered collection of /Users/jon/code/rails/rails/actionpack/lib/action_dispatch/middleware/templates/routes/_route.html.erb [2 times] (10.5ms)
Rendered /Users/jon/code/rails/rails/actionpack/lib/action_dispatch/middleware/templates/routes/_table.html.erb (2.5ms)
Rendered /Users/jon/code/rails/rails/railties/lib/rails/templates/rails/info/routes.html.erb within layouts/application (23.5ms)
Completed 200 OK in 50ms (Views: 35.1ms | ActiveRecord: 0.0ms)
```
Now, with this change, you would see:
```bash
Processing by Rails::InfoController#routes as HTML
Rendering /Users/jon/code/rails/rails/railties/lib/rails/templates/rails/info/routes.html.erb within layouts/application
Rendered collection of /Users/jon/code/rails/rails/actionpack/lib/action_dispatch/middleware/templates/routes/_route.html.erb [2 times] (1.6ms)
Rendered /Users/jon/code/rails/rails/actionpack/lib/action_dispatch/middleware/templates/routes/_table.html.erb (10.2ms)
Rendered /Users/jon/code/rails/rails/railties/lib/rails/templates/rails/info/routes.html.erb within layouts/application (17.4ms)
Completed 200 OK in 44ms (Views: 28.0ms | ActiveRecord: 0.0ms)
```
|
|\ \ \
| | | |
| | | | |
Fix API controller tests by assigning them the encoding type
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- Fixes #25183.
- The `as: :json` feature was added in
https://github.com/rails/rails/pull/21671 and recommended to use for
JSON endpoints so let's use it by default for API controller tests.
|
|\ \ \ \
| | | | |
| | | | | |
reference actual class to use middleware
|
| | |_|/
| |/| |
| | | |
| | | | |
Using strings for middleware class names is deprecated in 83b767cef90abfc4c2ee9f4b451b0215501fae9a.
|
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Since Ruby 2.4 isn't out yet, the fact that it will make `to_time` preserve the
time zone should be toggled with a update flag.
Second, remove the flipping on what version had what defaults. It's called new
framework defaults, so it's from the future looking. Thus keep the line that
mentions past versions.
|
| | | |
|
| | |
| | |
| | |
| | | |
- Adjusted tests instead.
|
| | |
| | |
| | |
| | |
| | |
| | | |
about old apps and how you can upgrade to new defaults.
[Kasper Timm Hansen, Prathamesh Sonpatki]
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
request_forgery_protection configs
- Earlier per_form_csrf_tokens and request_forgery_protection config
files were generated for old apps upgraded to Rails 5.
- But when we collapsed all initializers into one file, the entire file
does not get created for old apps.
- This commit fixes it and also changes values for all new defaults for
old apps so that they will not break.
- Also added a test for `rails app:update`.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- Move real new default options to the top of the file.
- After that club together all the options which were added to keep
backward compatibility. So all of them will get only one header.
- Based on https://github.com/rails/rails/pull/25231#issuecomment-222945173.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Conflicts:
guides/source/action_cable_overview.md
|
| | |/
| |/|
| | |
| | | |
http://edgeguides.rubyonrails.org/api_documentation_guidelines.html#english
|
| |/
|/| |
|
|\ \
| | |
| | | |
Collapse all new default initializers into a single file
|
| | |
| | |
| | |
| | |
| | |
| | | |
- Adjusted tests also for this new behavior.
- Based on the discussion in
https://github.com/rails/rails/pull/25184#issuecomment-222454583.
|
|/ / |
|
| |
| |
| |
| |
| |
| | |
- These initializers are new defaults for Rails 5 and newly generated
apps do not need to change them.
- Fixes #25181
|
| |
| |
| |
| | |
Follow up to e45f388.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When changing the generated integration tests to assert redirects with
an absolute path this redirection check in `assert_redirected_to` against
the absolute response location would now pass:
https://github.com/rails/rails/blob/af245aaf3a1c447752a1b5895adddc66e5f73c00/actionpack/lib/action_dispatch/testing/assertions/response.rb#L55
Thus we'd break early instead of hitting `assert_operator` and have
2 fewer assertions per `assert_redirected_to` as `assert_operator`
is composed of 2 assertions internally:
https://github.com/seattlerb/minitest/blob/4e146b1515b19a5c474e39c174b037510f6dbc6e/lib/minitest/assertions.rb#L254-L258
Deduct 2 assertions for 2 redirects taking the expected count down by 4
in total for the two failing tests.
|
|\ \
| | |
| | | |
Remove public/ files for API apps
|
| | |
| | |
| | |
| | | |
- Fixes #25180
|
| | | |
|
| | |
| | |
| | |
| | | |
second is now irrelevant with the dedicated API mode
|
|/ / |
|
|\ \
| | |
| | | |
Build action_cable.js with Blade
|