| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \
| | | | |
| | | | | |
[close #22917] Don't output to `STDOUT` twice
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
When `rails console` or `rails server` are used along with a logger set to output to `STDOUT` then the contents will show up twice. This happens because the logger is extended with `ActiveSupportLogger.broadcast` with a destination of STDOUT even if it is already outputting to `STDOUT`.
Previously PR #22592 attempted to fix this issue, but it ended up causing NoMethodErrors. A better approach than relying on adding a method and flow control is to inspect the log destination directly. For this `ActiveSupport::Logger.logger_outputs_to?` was introduced
```ruby
logger = Logger.new(STDOUT)
ActiveSupport::Logger.logger_outputs_to?(logger, STDOUT)
# => true
```
To accomplish this we must look inside of an instance variable of standard lib's Logger `@logdev`. There is a related Ruby proposal to expose this method in a standard way: https://bugs.ruby-lang.org/issues/11955
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
y-yagi/make_generated_controller_test_file_work_correctly
make generated controller test work correctly
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Since the `#file_name` that not consideration for the namespace, if generate a controller with a namespace,
not the correct url helper generation, it had become an error to run the test.
Modified to generate the correct url helper, even if it is produced a namespace with controller.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Per-form CSRF tokens
|
| | | | | | |
|
| |/ / / /
|/| | | |
| | | | |
| | | | | |
Add tests for detecting bad options for runner
|
|/ / / / |
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
prathamesh-sonpatki/create-application-model-under-namespaced-dir-in-plugin
Create application_record.rb under namespaced directory in plugin
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Earlier it was creating application_record.rb under `app/models`, after
this change, it will create application_record.rb under
`app/models/plugin_name` similar to other application classes.
|
| | | | | |
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Configurable redirect and secure cookies for ActionDispatch::SSL
|
| | |/ /
| |/| | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Two USAGE files were referring to Active Record and Active Model
without a space, which is incorrect because we're referring to
the framework name and not the constants.
|
|/ / /
| | |
| | |
| | | |
It was removed by mistake at 877a411d0c16baa4e670dae9a28f5cfcc201adc1
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- This fixes an error thrown by Thor because type of default value of
`:rc` option which is `:boolean` does not match with it's default type
which is `string`.
- Ref - https://github.com/erikhuda/thor/blob/master/lib/thor/parser/option.rb#L125
|
| | | |
|
|\ \ \
| | | |
| | | | |
Plugin Usage and Installation instructions
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Didn't like the constant being at the top of the file, gave it overdue importance.
Now that `color_output` expects a result we can shorten some of the flexibility
from earlier:
* Inline COLOR_CODES constant (keep local variable for readability,
but don't need names of colors at run time).
* Inline color variable in `color_output`. Looks just as clear without it.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Focus `color_output`'s intent on coloring output by a result. We aren't meant
to pass it arbitrary codes to color output.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The word color is being thrown all around with slightly different meanings.
Right now, I understand it. But I'd like to be more immediately clear.
|
| | | |
| | | |
| | | |
| | | | |
I got the blues because we aren't coloring any lines blue.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The static red color wouldn't paint skips in their designated yellow.
Use the color name we got from the result label earlier, which marks
skips as yellow.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
I should have replaced the summary reporter with a subclass
the first time I wrote this.
For whatever reason, I didn't. Do it right and slim the methods added
to Minitest in the process.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Minitest by default includes a summary reporter and a progress reporter.
To print colored output, we have to replace the progress reporter.
|
|\ \ \ \
| | | | |
| | | | | |
Add colored output to the new test reporter.
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
seeds.rb.tt: fix English.
|
| | | | | | |
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
remove cors initializer from rails app
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
`rack-cors` gem is defined in Gemfile by default only if the api,
not defined by default in rails app.
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
[ci skip]
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
Fix .keep file issue with ActionCable
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Fixes #22708
Make sure the channels file is create in assets/javascript/ so require
tree works in asset pipeline.
|
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
[ci skip]
The old link is 404 not found.
The link matches what the rest of the documentation already points to:
* https://github.com/rails/rails/blame/2de2263118d6763c11a02db05079a5b7a97a0a34/guides/source/getting_started.md#L2052
* https://github.com/rails/rails/blame/2de2263118d6763c11a02db05079a5b7a97a0a34/README.md#L74
|
|\ \ \ \
| | | | |
| | | | | |
Ensure Action Cable files are removed when `skip_action_cable` is set.
|
| | |_|/
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The Action Cable generators creates four files which need to be removed
if `skip_action_cable` is set.
1. `app/assets/javascripts/cable.coffee`
2. `app/channels/application_cable/channel.rb`
3. `app/channels/application_cable/connection.rb`
4. `config/redis/cable.yml`
Fixes #22669.
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Ensure that assets are enabled back after the test that tests assets are disabled
|
| | | | |
| | | | |
| | | | |
| | | | | |
disabled
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | | |
teknofire/fix-using-add_resource-with-a-block-after-gem-call
Fix using add_resource with a block after gem in custom generators
|
| |/ / /
| | | |
| | | |
| | | | |
generator template.
|
|\ \ \ \
| | | | |
| | | | | |
Action Cable channel generator doesn't create JS assets if options[:rails][:assets] is false
|
| |/ / / |
|
|\ \ \ \
| | | | |
| | | | | |
display detailed information in inline reporting
|