| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
[ci skip]
|
|\
| |
| | |
Un-hide helper and assets options for controller generator
|
| |
| |
| |
| |
| |
| |
| |
| | |
These options were hidden via 9b36cf0fa4cbdcb2e2072ef1b8179a98b13efce3,
but these options have tests written for them, and I believe that they
are supposed to be public API.
Fixes #24168.
|
| |
| |
| |
| | |
environments
|
|\ \
| | |
| | | |
Cable: Generate .js or .coffee files while generating channel as per the javascript engine of the application
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
javascript engine of the application
- Now we will detect what javascript engine user is using and based on
that we will generate either `.js` or `.coffee` version of the channel
file.
- This also needs a change in coffee-rails to override the `js_template`
method. Related PR https://github.com/rails/coffee-rails/pull/72.
- Currently coffee-rails gem sets
`config.app_generators.javascript_engine` to `:coffee` and using this
information we override the `js_template` to set the extension as
`.coffee` in coffee-rails gem.
- Using this approach, we can keep the `channel.js` and `channel.coffee`
files in the Rails repository itself.
- Additionally the `js_template` method can act as public interface for
coffee-rails gem to hook into and change the extension to `.coffee`
without maintaining the actual asset files.
[Prathamesh Sonpatki, Matthew Draper]
|
|/ /
| |
| |
| |
| | |
Sorry, I missed a few places in my last PR. This should be the last of
'em :grimacing:
|
| |
| |
| |
| | |
Conventionally envs are ordered development -> test -> production.
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
It is related with https://github.com/rack/rack/commit/7b66d2cdb80a4d6b44fa8c61d92e25fbbda1f152
|
| |
| |
| |
| | |
[ci skip]
|
| | |
|
|\ \
| | |
| | | |
remove unnessary option setting from test runner
|
| | |
| | |
| | |
| | |
| | | |
In order to prevent `OptionParser::ParseError` when specify the rake options to
`routes` task.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If run the test over the `rake` command, because of the test patterns is passed
via `rake_run` method, do not need to be obtained from the argv.
This probably fixes #24372.
|
| | |
| | |
| | |
| | | |
`railtie` is already a string!
|
| | |
| | |
| | |
| | | |
- Followup of https://github.com/rails/rails/pull/24709.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In Ruby 2.4 the `to_time` method for both `DateTime` and `Time` will
preserve the timezone of the receiver when converting to an instance
of `Time`. Since Rails 5.0 will support Ruby 2.2, 2.3 and later we
need to introduce a compatibility layer so that apps that upgrade do
not break. New apps will have a config initializer file that defaults
to match the new Ruby 2.4 behavior going forward.
For information about the changes to Ruby see:
https://bugs.ruby-lang.org/issues/12189
https://bugs.ruby-lang.org/issues/12271
Fixes #24617.
|
|/ / |
|
|\ \
| | |
| | | |
using rails dev:cache instead of rake dev:cache
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
y-yagi/use_wrapper_file_to_add_rake_task_for_engines
use wrapper file to add rake task for engines
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`bundler` provides wrapper file to add rask tasks.
https://github.com/bundler/bundler/blob/master/lib/bundler/gem_tasks.rb
Instead of directly call method, by which require this file,
it can be used without updating of Rakefile if task has been added.
|
|/ / / |
|
|\| |
| | |
| | |
| | | |
Add ActiveSupport::TimeZone.country_zones helper
|
|/ / |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Railties' `config` method instatiates a Rails::Railtie::Configuration
object. Rails::Configuration is not used in this file.
The patch does not replace the file being required with the one for
Rails::Railtie::Configuration because that one is autoloaded. See the
spot where this patch changes double quotes with single quotes.
Rails::Railtie::Configuration does depend on Rails::Configuration, and
it requires it accordingly.
|
|\ \
| | |
| | | |
Added notice when a database is successfully created or dropped.
|
| | | |
|
|/ /
| |
| |
| | |
`cable.js` is required for other Channels.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Before this, while generating a channel, we were not creating
`cable.js` if it does not already exist.
- We have similar code for application mailer here -
https://github.com/rails/rails/commit/0b3ae023d27197417541932632055cd6be4810c4.
- Based on the comment -
https://github.com/rails/rails/issues/24418#issuecomment-205421995.
|
|\ \
| | |
| | | |
Railties CHANGELOG Pass [ci skip]
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- Added missing config to complete config names
- Fixed route generators changelog grammar.
- rake:stats => rake stats
- Fixed grammar of assert_file change
- Make sure we end all sentences
[ci skip]
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
prathamesh-sonpatki/add-config-to-deprecation-warning
Add `config` to the deprecation warnings of deprecated config options
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The pass touches a few minor things.
One important aspect is that the wording treats "railtie" as a
regular noun. This is so because Railtie is a constant and
generally the text refers to "classes that act as railties",
which is different.
Railties are so fundamental in Rails that deserve a noun,
like engine, class, array, application, etc. They have a
meaning per se, beyond constants.
Also, make clear an extension's railtie does not need to
be called "Railtie" or have "Railtie" in their class name.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Idiomatically trailing hashes in method calls do not use
explicit curlies.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Rake includes (an extended version of) FileUtils in tasks.
It is more idiomatic that they use this provided interface.
|
|/ / /
| | |
| | |
| | |
| | |
| | | |
With the exception of what is loaded in active_support/rails,
each file is responsible for its own dependencies. You cannot
rely on runtime order of execution.
|
|/ /
| |
| |
| |
| |
| | |
This was added in a4c358f, but `config.assets` has been removed in 5172d93.
Also, do not use env path to `Sprockets::Cache::FileStore` even `sprockets-rails`.
ref: https://github.com/rails/sprockets-rails/blob/master/lib/sprockets/railtie.rb#L129
|
|\ \
| | |
| | | |
generate ApplicationJob if it does not already exist
|
| | |
| | |
| | |
| | |
| | |
| | | |
ActiveJob jobs now inherit from ApplicationJob by default.
However, when updating to Rails 5 from the old Rails,
since there is a possibility that ApplicationJob does not exist.
|
| | |
| | |
| | |
| | |
| | |
| | | |
* Updated syntax
* Updated tests to match syntax
|
|\ \ \
| | | |
| | | | |
remove unused `require`
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
Also, make sure to call the +complete+ hooks if +run+ fails.
|