| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | |
| | | |
| | | |
| | | | |
Using of "`" is preferable over "'" to express console command in output log
|
|/ / /
| | |
| | |
| | | |
These were added in #30101, after #31084 it became redundant.
|
| | |
| | |
| | |
| | |
| | | |
Since isolation application is generated with the `--skip-gemfile`
option, so `active_storage:install` is not executed.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In order to execute the `rails` command, need to run bundle install in
advance.
Therefore, if skipped bundle install, `rails` command may fail and
should not do it.
|
| | |
| | |
| | |
| | | |
`ScaffoldBase` was changed to `ResourceHelpers` by 0efedf2.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Ensure that `bin/rails db:migrate` with specified `VERSION` reverts
all migrations only if `VERSION` is `0`.
Raise error if target migration doesn't exist.
|
|\ \ \
| | | |
| | | | |
Provide initialization of Active Storage
|
| | | |
| | | |
| | | |
| | | | |
new`
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Omit `rails activestorage:install` for jdbcmysql, jdbc and shebang tests
AppGeneratorTest#test_config_jdbcmysql_database
rails aborted!
LoadError: Could not load 'active_record/connection_adapters/mysql_adapter'.
Make sure that the adapter in config/database.yml is valid.
If you use an adapter other than 'mysql2', 'postgresql' or 'sqlite3' add
the necessary adapter gem to the Gemfile.
(compressed)
bin/rails:4:in `<main>'
Tasks: TOP => activestorage:install => environment
(See full trace by running task with --trace)
AppGeneratorTest#test_config_jdbc_database
rails aborted!
LoadError: Could not load 'active_record/connection_adapters/jdbc_adapter'.
Make sure that the adapter in config/database.yml is valid.
If you use an adapter other than 'mysql2', 'postgresql' or 'sqlite3' add
the necessary adapter gem to the Gemfile.
(compressed)
bin/rails:4:in `<main>'
Tasks: TOP => activestorage:install => environment
(See full trace by running task with --trace)
AppGeneratorTest#test_shebang_is_added_to_rails_file
/home/ubuntu/.rbenv/versions/2.4.1/bin/ruby: no Ruby script found in input (LoadError)
Prevent PendingMigrationError in tests
* Run `bin/rails db:migrate RAILS_ENV=test` in test_cases before start tests to prevent PendingMigrationError
* FileUtils.rm_r("db/migrate")
* --skip-active-storage
Fix failed tests in `railties/test/railties/engine_test.rb`
Related to #30111
Imporve `SharedGeneratorTests#test_default_frameworks_are_required_when_others_are_removed`
- Explicitly skip active_storage
- Ensure that skipped frameworks are commented
- Ensure that default frameworks are not commented
Fix error `Errno::ENOSPC: No space left on device - sendfile`
Since `rails new` runs `rails active_storage:install`
that boots an app.
Since adding Bootsnap 0312a5c67e35b960e33677b5358c539f1047e4e1
during booting an app, it creates the cache:
264K tmp/cache/bootsnap-load-path-cache
27M tmp/cache/bootsnap-compile-cache
* teardown_app must remove app
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
is used
Closes #30102
Revert part 787fe90dc0a7c5b91bb5af51f2858ea8c4676268
--skip-active-storage pass throughs `rails plugin new`
Add changelog entry about default initialization of Active Storage
|
| | | |
| | | |
| | | |
| | | | |
Since f182831, this file does not use methods added by `module/introspection`.
|
|\ \ \ \
| | | | |
| | | | | |
Generate the correct path in nested scaffold generator
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Currently, namespaced scaffold generator will generate an incorrect path
and the generated file will not work properly.
```
$ ./bin/rails g scaffold admin/user
$ ./bin/rails db:migrate
$ ./bin/rails t test/controllers
# Running:
E
Error:
Admin::UsersControllerTest#test_should_create_admin_user:
NameError: undefined local variable or method `admin_admin_users_url' for #<Admin::UsersControllerTest:0x000055a59f25ff68>
Did you mean? admin_users
test/controllers/admin/users_controller_test.rb:20:in `block (2 levels) in <class:UsersControllerTest>'
test/controllers/admin/users_controller_test.rb:19:in `block in <class:UsersControllerTest>'
bin/rails test test/controllers/admin/users_controller_test.rb:18
```
This is because combine `controller_class_path` and `singular_table_name`
to generate route.
https://github.com/rails/rails/blob/360698aa245b45349d1d1b12e1afb34759515e69/railties/lib/rails/generators/named_base.rb#L172
Normally, if using namspaced generator, table name already contains
namespace. Therefore, adding `controller_class_path` adds extra namespace.
Since it is special only when explicitly specifying `model-name`, it is
modified to change the value only when `model-name`is specified.
Follow up of #30729
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Remove unused `secrets.yml` template
|
| | | |
| | | |
| | | |
| | | |
| | | | |
`secrets.yml` no longer used since #30067.
Together, removed `app_secret` method that only used in `secrets.yml`
|
|\ \ \ \
| | | | |
| | | | | |
Change `VENDOR_PATH` to `APP_ROOT` in `bin/yarn`
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This variable was initially used to hold the vendor directory.
https://github.com/rails/rails/commit/3dac36b
Therefore, the variable name `VENDOR_PATH` was appropriate.
However, `package.json` is now placed in the root of the project.
https://github.com/rails/rails/commit/8e9e943
Therefore, like other bin scripts, I think the variable name `APP_ROOT`
is appropriate.
https://github.com/rails/rails/blob/2c845f6b03ddf2aa233b00385d24d769a4a34fa6/railties/lib/rails/generators/rails/app/templates/bin/setup.tt#L5
https://github.com/rails/rails/blob/2c845f6b03ddf2aa233b00385d24d769a4a34fa6/railties/lib/rails/generators/rails/app/templates/bin/update.tt#L5
|
| | | | | |
|
|/ / / /
| | | |
| | | | |
Improve a code style recommendation following Rubocop instructions https://codeclimate.com/github/rails/rails/issues
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Because `options` here is not AS::HWIA but an instance of Thor::CoreExt::HWIA
that looks very similar to ours but behaves slightly different, we need to keep
this object be an instance of Thor::CoreExt::HWIA.
Since Ruby 2.5 has Hash#slice that returns a new Hash instance now,
we need to avoid calling `slice` on this tricky object.
|
| | | |
| | | |
| | | |
| | | | |
This basically reverts 618268b4b9382f4bcf004a945fe2d85c0bd03e32
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
bogdanvlviv/fix_ar_internal_metadata_for_a_test_database
Fix `bin/rails db:setup` and `bin/rails db:test:prepare` create wrong ar_internal_metadata's data for a test database.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
database connection
When load schema from `structure.sql`, database connection isn't
established. `ActiveRecord::Tasks::DatabaseTasks.load_schema` has to
establish database connection since it executes
```
ActiveRecord::InternalMetadata.create_table
ActiveRecord::InternalMetadata[:environment] = environment
```
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
ar_internal_metadata's data for a test database.
Before:
```
$ RAILS_ENV=test rails dbconsole
> SELECT * FROM ar_internal_metadata;
key|value|created_at|updated_at
environment|development|2017-09-11 23:14:10.815679|2017-09-11 23:14:10.815679
```
After:
```
$ RAILS_ENV=test rails dbconsole
> SELECT * FROM ar_internal_metadata;
key|value|created_at|updated_at
environment|test|2017-09-11 23:14:10.815679|2017-09-11 23:14:10.815679
```
Fixes #26731.
|
| | | | |
| | | | |
| | | | |
| | | | | |
chromedriver-helper by default
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove unnecessary `allow_failure: true` option
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | | |
`routes` task always returns zero to status, so status is not to non-zeno.
Ref: https://github.com/rails/rails/blob/b1867c480dd5476948ff0492ea2f91e2c2fcb04b/railties/lib/rails/tasks/routes.rake#L30
|
|/ / / /
| | | |
| | | |
| | | | |
Ref: https://github.com/rails/rails/blob/3be123ba26cad461a80d7d680819e71c1388a241/railties/test/isolation/abstract_unit.rb#L243
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In this test file, "server option" refers to the server used to start
Rails(e.g. `puma`, `thin`).
But this test, "server option" is not specified. Therefore, I think that
it is incorrect that `server_option` is included in the test name.
|
| | | |
| | | |
| | | |
| | | | |
option[:daemonize] to true, otherwise the option[:daemonize] will be set to false
|
| | | |
| | | |
| | | |
| | | | |
Ruby 2.5 warns about this. Ref: https://travis-ci.org/rails/rails/jobs/286338999
|
|\ \ \ \
| | | | |
| | | | | |
Improve railties' tests
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Remove redundant setting `RAILS_ENV` for `db:test:prepare`.
`db:test:prepare` doesn't require it.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
TestHelpers::Generation#rails
See #30520
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Simplify parse arguments in `ConsoleTest`
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | | |
If need a parse result of arguments, can obtain it by creating
an instance of the command.
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* Use `gem 'redis', '~> 4.0'` for new app Gemfiles
* Loosen Action Cable redis-rb dep to `>= 3.3, < 5`
* Bump redis-namespace for looser Redis version dep
* Avoid using the underlying `redis.client` directly
* Use `Redis.new` instead of `Redis.connect`
|
|/ / /
| | |
| | |
| | |
| | |
| | | |
The `abstract_unit` loads `rails/all`. Therefore, `Rails` is definitely defined.
Also, since `Info` is autoloaded, do not need to explicitly load the file.
https://github.com/rails/rails/blob/3ede539357acc91e377611cea9dd5f30678e7b2a/railties/lib/rails.rb#L29
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When puma/puma#1403 is merged Puma will support the Early Hints status
code for sending assets before a request has finished.
While the Early Hints spec is still in draft, this PR prepares Rails to
allowing this status code.
If the proxy server supports Early Hints, it will send H2 pushes to the
client.
This PR adds a method for setting Early Hints Link headers via Rails,
and also automatically sends Early Hints if supported from the
`stylesheet_link_tag` and the `javascript_include_tag`.
Once puma supports Early Hints the `--early-hints` argument can be
passed to the server to enable this or set in the puma config with
`early_hints(true)`. Note that for Early Hints to work
in the browser the requirements are 1) a proxy that can handle H2,
and 2) HTTPS.
To start the server with Early Hints enabled pass `--early-hints` to
`rails s`.
This has been verified to work with h2o, Puma, and Rails with Chrome.
The commit adds a new option to the rails server to enable early hints
for Puma.
Early Hints spec:
https://tools.ietf.org/html/draft-ietf-httpbis-early-hints-04
[Eileen M. Uchitelle, Aaron Patterson]
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Since warning was issued due to duplication of test names, fix the test
name to a meaningful name.
This fixes following warnings:
```
railties/test/generators/named_base_test.rb:141: warning: method redefined; discarding old test_scaffold_plural_names
railties/test/generators/named_base_test.rb:62: warning: previous definition of test_scaffold_plural_names was here
```
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
See the changelog entry.
Remove `secrets.secret_token` from the bug report templates,
since we don't accept bug reports for Rails versions that
don't support a `secret_key_base`.
[ claudiob & Kasper Timm Hansen ]
|
|\ \
| | |
| | | |
Nested scaffold should be fine
|
| | | |
|
|\ \ \
| |/ /
|/| | |
Align `bin/update`'s Yarn usage with `bin/setup`
|
| | | |
|
| | |
| | |
| | |
| | | |
`about_yml_plugins` is no longer used since 82b9b15
|
|\ \ \
| | | |
| | | | |
Respect quiet option in all process of `rails new` command
|